Remove seperator line from extensions card |
||||||||||
Issue descriptionRemove the separator line, between buttons and extension description.
,
May 10 2018
What about the padding? Does it need to be modified? Specifically: Before there was a 16px padding between the horizontal separator and the description text above, and 8px padding between horizontal separator and the buttons below. Now that there is no separator, should we just have 16px total?
,
May 11 2018
Spec attached
,
May 11 2018
,
May 11 2018
,
May 11 2018
,
May 11 2018
,
May 12 2018
,
May 12 2018
,
May 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/907f20ac463508fd34ea8c9c91a6e13321169de7 commit 907f20ac463508fd34ea8c9c91a6e13321169de7 Author: Esmael El-Moslimany <aee@chromium.org> Date: Sat May 12 02:34:57 2018 MD Extensions: remove separator from extensions card Bug: 842002 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id343156de4540c33d1db130c9260e9b3fc861ddc Reviewed-on: https://chromium-review.googlesource.com/1055818 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#558098} [modify] https://crrev.com/907f20ac463508fd34ea8c9c91a6e13321169de7/chrome/browser/resources/md_extensions/item.html
,
May 12 2018
,
May 14 2018
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #68.0.3430.0 as per the comment #11. Attaching screenshot for reference. Hence, the fix is working as expected. 1. Adding the verified labels as fix is working as expected. Note: Able to reproduce the issue on chrome version on 68.0.3425.0 with out fix. Thanks...!! TE-Verified-M68 TE-Verified-68.0.3430.0 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by namratakannan@chromium.org
, May 10 2018