New issue
Advanced search Search tips

Issue 842002 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 831852



Sign in to add a comment

Remove seperator line from extensions card

Project Member Reported by namratakannan@chromium.org, May 10 2018

Issue description

Remove the separator line, between buttons and extension description.



 
Screen Shot 2018-05-10 at 4.39.07 PM.png
640 KB View Download
Description: Show this description

Comment 2 by dpa...@chromium.org, May 10 2018

Blocking: 831852
Cc: aee@chromium.org
Components: -UI -UI>Browser>WebUI UI>Browser>ExtensionsManagement
What about the padding? Does it need to be modified? Specifically:

Before there was a 16px padding between the horizontal separator and the description text above, and 8px padding between horizontal separator and the buttons below.

Now that there is no separator, should we just have 16px total?
Spec attached
card with spec.png
18.8 KB View Download

Comment 4 by dpa...@chromium.org, May 11 2018

Status: Available (was: Untriaged)

Comment 5 by aee@chromium.org, May 11 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Assigned (was: Available)

Comment 6 by aee@chromium.org, May 11 2018

Status: Started (was: Assigned)

Comment 7 by dpa...@chromium.org, May 11 2018

Labels: M-68

Comment 8 by dpa...@chromium.org, May 12 2018

Labels: -ProjMDRefersh

Comment 9 by dpa...@chromium.org, May 12 2018

Labels: Proj-MaterialDesign-Refresh-WebUI
Project Member

Comment 10 by bugdroid1@chromium.org, May 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/907f20ac463508fd34ea8c9c91a6e13321169de7

commit 907f20ac463508fd34ea8c9c91a6e13321169de7
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Sat May 12 02:34:57 2018

MD Extensions: remove separator from extensions card

Bug:  842002 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id343156de4540c33d1db130c9260e9b3fc861ddc
Reviewed-on: https://chromium-review.googlesource.com/1055818
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558098}
[modify] https://crrev.com/907f20ac463508fd34ea8c9c91a6e13321169de7/chrome/browser/resources/md_extensions/item.html

Comment 11 by aee@chromium.org, May 12 2018

Status: Fixed (was: Started)
Cc: phanindra.mandapaka@chromium.org
Labels: TE-Verified-M68 TE-Verified-68.0.3430.0
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #68.0.3430.0 as per the comment #11.
Attaching screenshot for reference.
Hence, the fix is working as expected. 
1. Adding the verified labels as fix is working as expected.
Note: Able to reproduce the issue on chrome version on 68.0.3425.0 with out fix.

Thanks...!!

TE-Verified-M68
TE-Verified-68.0.3430.0
840220.png
589 KB View Download

Sign in to add a comment