Add validity check kSettingPagesPerSheet once new print preview UI feature rolls out |
|||||
Issue descriptionIn print_settings_conversion.cc PrintSettingsFromJobSettings function checks for print settings are set, once new print preview feature is released, we need to check for "Pages Per Sheet" value is set in job_settings. Currently since "Pages Per Sheet" value is not in the old print preview UI print ticket, checking for validity the same way as that for Landscape, DuplexMode, etc. will cause coredump.
,
Dec 17
,
Dec 17
We can do this now since the old Print Preview code is gone.
,
Dec 17
I can take care of that.
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5837bcdd93a751e9f996a49a67c35bf4a0ddd1b commit d5837bcdd93a751e9f996a49a67c35bf4a0ddd1b Author: xlou <xlou@chromium.org> Date: Tue Dec 18 01:46:32 2018 Print Preview: Add validity check for kSettingPagesPerSheet. It was not checked because pagesPerSheet was only added to the new print preview UI, adding the validity check caused coredump. Now since the old print preview UI is gone, we can add the check. Bug: 842000 Change-Id: I413be9f89c7baca135275bd27fc228e23d0f202e Reviewed-on: https://chromium-review.googlesource.com/c/1381133 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Shirleen Lou <xlou@chromium.org> Cr-Commit-Position: refs/heads/master@{#617334} [modify] https://crrev.com/d5837bcdd93a751e9f996a49a67c35bf4a0ddd1b/printing/print_settings_conversion.cc
,
Dec 18
,
Dec 18
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xlou@chromium.org
, May 10 2018