New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841981 link

Starred by 2 users
Status: Fixed
Owner:
chanli@chromium.org
Closed: May 2018
Cc:
chanli@chromium.org
█ robert...@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] handle unexpected None values in build info

Project Member Reported by chanli@chromium.org, May 10 2018 
https://pantheon.corp.google.com/errors/CMLKy5f-7o2o0QE?time=P30D&project=findit-for-me

Cause: for some broken builds, some information is missing from build info, and those fields are set to None. 

When getting info, use 'd.get(k) or default' instead of 'd.get(k, default)' so that None values can be covered.
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d4f68a09b09dc60a7c4c469c818e6d21bbd80a53

commit d4f68a09b09dc60a7c4c469c818e6d21bbd80a53
Author: Chan <chanli@chromium.org>
Date: Fri May 11 17:52:33 2018

[Findit] Handle unexpected None values when extract build info.

For some broken builds, some information is missing from build info, and those fields are set to None. When getting info, use 'd.get(k) or default' instead of 'd.get(k, default)' so that None values can be covered.


Bug:  841981 
Change-Id: Idfd6a97fa339e85e61c6e18afc75998b7d41185d
Reviewed-on: https://chromium-review.googlesource.com/1054644
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/d4f68a09b09dc60a7c4c469c818e6d21bbd80a53/appengine/findit/waterfall/buildbot.py

Comment 2 by chanli@chromium.org, May 11 2018

Cc: chanli@chromium.org
 Issue 842320  has been merged into this issue.

Comment 3 by chanli@chromium.org, May 11 2018

Status: Fixed (was: Started)
►

Sign in to add a comment