arc: race condition upreving android container. |
||
Issue descriptionIt seems we have race condition running cros_mark_android_as_stable.py We have following base logic: Test if resource does not exist in target basket then copy it to this basket. It works fine if running as single command. However when multiple boards try to uprev at near the same time then Test if resource does not exist in target basket may be true for few boards but only one has a chance to succeed. Others would receive: PreconditionException: 412 Precondition Failed This can explains for example: https://uberchromegw.corp.google.com/i/chromeos/builders/cyan-nyc-android-pfq/builds/2040 +Constables including next week.
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/96c193e47eb5ea45aa672e196f8872264c3e8c5c commit 96c193e47eb5ea45aa672e196f8872264c3e8c5c Author: khmel@google.com <khmel@google.com> Date: Fri May 11 19:10:51 2018 arc: Retry copying resource in case race condition for android uprev This retry copying resource in case gs returns error for already copied resource. TEST=Manually, simulate error condition. BUG= chromium:841937 Change-Id: I6e7950f477876463f2449abc8127a42e18c28833 Reviewed-on: https://chromium-review.googlesource.com/1054506 Commit-Ready: Yury Khmel <khmel@google.com> Tested-by: Yury Khmel <khmel@google.com> Reviewed-by: Yury Khmel <khmel@google.com> [modify] https://crrev.com/96c193e47eb5ea45aa672e196f8872264c3e8c5c/scripts/cros_mark_android_as_stable.py
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f812c075051dd302e9bae4572715bce9a78f8bd9 commit f812c075051dd302e9bae4572715bce9a78f8bd9 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 11 21:16:45 2018 Roll src/third_party/chromite/ 746c45d5d..7657336de (3 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/746c45d5d8b1..7657336de212 $ git log 746c45d5d..7657336de --date=short --no-merges --format='%ad %ae %s' 2018-05-08 mikenichols [chromite] Capture job_name and git timing for ts_mon in cbuildbot runs. 2018-05-10 khmel arc: Retry copying resource in case race condition for android uprev 2018-05-09 achuith cros_run_vm_test: Support for --host-cmd Created with: roll-dep src/third_party/chromite BUG= chromium:829289 , chromium:841937 , chromium:832374 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7712f93eb43ad2661af0fe11a71a9b228ce916ad Reviewed-on: https://chromium-review.googlesource.com/1055816 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558020} [modify] https://crrev.com/f812c075051dd302e9bae4572715bce9a78f8bd9/DEPS
,
May 15 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by uekawa@google.com
, May 11 2018