Mass bot_update failures on bots opting out of deps via custom_deps |
|||
Issue description^
,
May 10 2018
The spec revert appears to have worked. This also appeared to affect the chromium.gpu.fyi builders. Sample build failures include: - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20FYI%20Mac%20Builder/7471 - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20FYI%20Linux%20Builder/7560 - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20FYI%20Win%20x64%20Builder/4130 - https://ci.chromium.org/buildbot/chromium.perf/Android%20Builder%20Perf/9858
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/3d894aa45e08b1d0d93483aa885df11e8156d93d commit 3d894aa45e08b1d0d93483aa885df11e8156d93d Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu May 10 22:42:21 2018 bot_update: Fix manifest creation. It fails when both the revision and the url are None. Bug: 841936 Change-Id: Idef45a015624a92226d4ccd38ed5b978bf786993 Reviewed-on: https://chromium-review.googlesource.com/1053996 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/3d894aa45e08b1d0d93483aa885df11e8156d93d/recipes/recipe_modules/bot_update/resources/bot_update.py [modify] https://crrev.com/3d894aa45e08b1d0d93483aa885df11e8156d93d/tests/bot_update_coverage_test.py
,
May 10 2018
,
May 10 2018
This happened more widely than just on chromium.perf -- seems like anything that set custom_deps to None (including anything that used the chrome_internal gclient config, https://chromium.googlesource.com/chromium/tools/build/+/bbdecec6895b7b60d1b1afc2dbfe3ab94293ee54/scripts/slave/recipe_modules/chromium/gclient_config.py#231) failed similarly.
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f07767740d1143e791b27b169817073b19a2c05 commit 5f07767740d1143e791b27b169817073b19a2c05 Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 11 00:05:25 2018 Roll src/third_party/depot_tools/ e877b1776..219130867 (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e877b1776a14..2191308678e4 $ git log e877b1776..219130867 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 jbudorick Revert "gclient: Get rid of parsed_url." 2018-05-10 ehmaldonado bot_update: Assert no syncing of refs/remotes/* Created with: roll-dep src/third_party/depot_tools BUG= chromium:841936 ,chromium:840445 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I52a88ffeda4b56309156e3fc377eebdbc3ae8138 Reviewed-on: https://chromium-review.googlesource.com/1054635 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557732} [modify] https://crrev.com/5f07767740d1143e791b27b169817073b19a2c05/DEPS
,
May 11 2018
Issue 841943 has been merged into this issue.
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81a3b828c376c285abf615d0573024b44cb46463 commit 81a3b828c376c285abf615d0573024b44cb46463 Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 11 02:18:13 2018 Roll src/third_party/depot_tools/ 219130867..3d894aa45 (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2191308678e4..3d894aa45e08 $ git log 219130867..3d894aa45 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 ehmaldonado bot_update: Fix manifest creation. Created with: roll-dep src/third_party/depot_tools BUG= chromium:841936 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iacfd5922774e48e10d9829e21f2b75138803b6d2 Reviewed-on: https://chromium-review.googlesource.com/1054853 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557770} [modify] https://crrev.com/81a3b828c376c285abf615d0573024b44cb46463/DEPS |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 10 2018