New issue
Advanced search Search tips

Issue 841931 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

rendering.desktop/gmail in rendering.desktop failing on chromium.perf/Win 10 Perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 10 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of charliea@chromium.org

rendering.desktop/gmail in rendering.desktop failing on chromium.perf/Win 10 Perf

Builders failed on: 
- Win 10 Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Win%2010%20Perf

The failure looks like we're timing out at IsJavascriptExpressionTrue:

File "c:\b\s\w\ir\tools\perf\page_sets\top_25_smooth.py", line 44, in RunPageInteractions
    'window.__scrollableElementForTelemetry != null')
  File "c:\b\s\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\actions\action_runner.py", line 261, in WaitForJavaScriptCondition
    return self._tab.WaitForJavaScriptCondition(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\browser\web_contents.py", line 239, in WaitForJavaScriptCondition
    return self._inspector_backend.WaitForJavaScriptCondition(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\inspector_backend.py", line 302, in WaitForJavaScriptCondition
    e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 60s for IsJavaScriptExpressionTrue.

Based on the flakiness dashboard, it looks like there's a bimodal distribution of how long this test takes to run, even when it passes: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=rendering.desktop&builder=chromium.perf%3AWin%2010%20Perf

I suspect that, to fix the flakiness, either this bimodal distribution needs to be fixed or we need to extend that 60s timeout

This has been happening as far back as the flakiness dashboard seems to have history. I'm going to go ahead and disable the story and assign this bug to the benchmark owners.
 
Cc: sadrul@chromium.org
Components: Speed>Benchmarks>Waterfall
Owner: vmi...@chromium.org
Labels: -Pri-1 Pri-2
Moving down to P2 now that test is disabled
Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d69a37bd38aeee2326267faf713d0f9e0896462b

commit d69a37bd38aeee2326267faf713d0f9e0896462b
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri May 11 16:18:51 2018

Disable rendering.desktop/gmail on Windows

The story is flaky, failing >10% of the time

TBR=nednguyen@chromium.org
CC=vmiura@chromium.org, sadrul@chromium.org

Bug:  841931 
Change-Id: Id949871eb6ebb87b4ffca76ebfe6d1f91cbec154
Reviewed-on: https://chromium-review.googlesource.com/1055589
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557897}
[modify] https://crrev.com/d69a37bd38aeee2326267faf713d0f9e0896462b/tools/perf/expectations.config

Comment 4 by sadrul@chromium.org, Jun 12 2018

Components: Internals>GPU>Metrics
Status: Assigned (was: Available)
Status: Fixed (was: Assigned)
rendering.desktop/gmail has been re-recorded as rendering.desktop/gmail_2018 and is now re-enabled.

Sign in to add a comment