New issue
Advanced search Search tips

Issue 841922 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: ----



Sign in to add a comment

virtual/.../video-controls-focus-movement-on-hide.html in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.12 (retina)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 10 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of dmurph@chromium.org

virtual/.../video-controls-focus-movement-on-hide.html in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.12 (retina)

Builders failed on: 
- WebKit Mac10.12 (retina): 
  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20%28retina%29

Because of a pre-opening that wasn't good, we have quite a lot of suspect CLs, starting with this build:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20%28retina%29/860

and ending with this one, where the failure definitely happened:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20%28retina%29/864
 

Comment 2 by dmu...@chromium.org, May 10 2018

Owner: steimel@chromium.org
Status: Assigned (was: Available)
Going to assign to that team and hope they can figure it out. Going to be really hard to find the CL, unless you really know what you're looking for.

Attaching layouttest output diff.
video-controls-focus-movement-on-hide-pretty-diff.html
1.3 KB View Download

Comment 3 by dmu...@chromium.org, May 10 2018

Labels: OS-Mac
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d987cb0c5f5acef554a4c88a30f0c45c43816c24

commit d987cb0c5f5acef554a4c88a30f0c45c43816c24
Author: Daniel Murphy <dmurph@chromium.org>
Date: Thu May 10 19:59:17 2018

Disabling video-controls-focus-movement-on-hide.html

TBR: steimel@chromium.org
Bug: 841922
Change-Id: I5e79703e97153a4cd4d2346554901f24c895d334
Reviewed-on: https://chromium-review.googlesource.com/1054418
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557638}
[modify] https://crrev.com/d987cb0c5f5acef554a4c88a30f0c45c43816c24/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Project Member

Comment 6 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f128197594369e55a52df4538323ff7bd96dd30e

commit f128197594369e55a52df4538323ff7bd96dd30e
Author: Max Morin <maxmorin@chromium.org>
Date: Fri May 11 09:36:15 2018

Disable flaky video-controls-focus-movement-on-hide.html

Also has issues on 10.13 and a Windows 7 bot.

Tbr: steimel@chromium.org
No-Try: true
Bug: 833658, 841922
Change-Id: If202d5a9750d5e3b96e8022884bd0ed088840466
Reviewed-on: https://chromium-review.googlesource.com/1054235
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557823}
[modify] https://crrev.com/f128197594369e55a52df4538323ff7bd96dd30e/third_party/WebKit/LayoutTests/TestExpectations

Comment 7 by horo@chromium.org, May 15 2018

Cc: tmartino@chromium.org
 Issue 842824  has been merged into this issue.

Comment 8 by horo@chromium.org, May 15 2018

Components: Blink>Media>Controls

Comment 9 by flackr@chromium.org, May 16 2018

This is still failing regularly as an unexpected failure despite #4 on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20%28retina%29/
Project Member

Comment 10 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c885b1a7bb863bd7090f1d5f59e79ac51147b9c9

commit c885b1a7bb863bd7090f1d5f59e79ac51147b9c9
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Wed May 16 20:17:01 2018

Replicate existing expectations into virtual/video-surface-layer flavour

This CL replicates existing test expectations for
media/video-controls-focus-movement-on-hide.html
into the virtual/video-surface-layer flavour of the test.

Before this CL:

crbug.com/833658 [ Linux Win Mac ] media/... [ Pass Failure ]
crbug.com/841922 [ Mac10.12 Mac10.13 Win7 ] virtual/video-surface-layer/media/... [ Failure Pass ]

After this CL:

crbug.com/833658 [ Linux Win Mac ] media/... [ Pass Failure ]
crbug.com/841922 [ Linux Win Mac] virtual/video-surface-layer/media/... [ Pass Failure ]

Bug: 833658, 841922
Change-Id: Ib3de8102f5e947215133f42c2dc522d612394789
Reviewed-on: https://chromium-review.googlesource.com/1062587
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559260}
[modify] https://crrev.com/c885b1a7bb863bd7090f1d5f59e79ac51147b9c9/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment