New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841920 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Allow for auto revert for analyses that didn't file the bug

Project Member Reported by lijeffrey@chromium.org, May 10 2018

Issue description

any analysis with a bug attached should be revertable
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/37fa24b8bddbe360703b206c8e406922eebb96d4

commit 37fa24b8bddbe360703b206c8e406922eebb96d4
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu May 10 20:00:20 2018

[Findit] Flake Analyzer - Allow for analyses to be reverted as long as they have bugs

The root cause is the field MasterFlakeAnalysis.has_filed_bug is only True if the
analysis itself was the one responsible for filing the bug, and not that any bug is
associated with the analysis. This should not be checked for in auto revert, as multiple
analyses can reach the same conclusion, and only 1 of them is the one that files the bug.
If that analysis decides not to auto revert, no analysis can auto revert subsequently even
if they come to more drastic conclusions (e.g. first one bails out due to insufficient
confidence, but a second analysis detects the same CL introduced a new flaky test and has
higher confidence). This field also doesn't work if the bug was filed by CTF.

This change switches to see if any bug is associated with the analysis, and not that the
particular analysis was responsible for filing it.

Bug:  841920 
Change-Id: Ib7fec9664a2db3e8849a1a3697c6179f6f0d0a1d
Reviewed-on: https://chromium-review.googlesource.com/1054410
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/37fa24b8bddbe360703b206c8e406922eebb96d4/appengine/findit/services/flake_failure/culprit_util.py
[modify] https://crrev.com/37fa24b8bddbe360703b206c8e406922eebb96d4/appengine/findit/services/flake_failure/test/culprit_util_test.py

Status: Fixed (was: Assigned)

Sign in to add a comment