Issue metadata
Sign in to add a comment
|
10.2% regression in sizes at 556874:556874 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 10 2018
Assigning to vtsyrklevich@chromium.org because this is the only CL in range: Reland "[CFI] Enable cfi-icall for official Linux x64 builds" This is a reland of a6889a090458a2653794c6e63387d6db743dc7f9 now that crrev.com/c/1044502 crrev.com/c/1043259 and crrev.com/c/1043283 fix the previously discovered issues. Original change's description: > [CFI] Enable cfi-icall for official Linux x64 builds > > The measured size impact is 1.5% and perf impact is ~1%. > > Bug: 701919 > Change-Id: I541242711bc85cc124ff3a2680171577e75475bd > Reviewed-on: https://chromium-review.googlesource.com/1033918 > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554828} Bug: 701919 Change-Id: I1a518d356cc6f3599545e594204ce360b4e0360a Reviewed-on: https://chromium-review.googlesource.com/1045565 Reviewed-by: Peter Collingbourne <pcc@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#556874}
,
May 15 2018
This bug is being tracked by https://bugs.llvm.org/show_bug.cgi?id=37474 Also, looking at this made me realize that we're pulling in the -Wl,--export-dynamic ldflag for all builds, filed as https://bugs.chromium.org/p/chromium/issues/detail?id=843317
,
Jun 12 2018
Now that [1] is fixed and clang has been rolled so [2] has landed the size regression is now down to 1.4% [3]. I'm going to keep this bug open to track landing [4] which should reduce the size a bit further. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=843317 [2] https://reviews.llvm.org/D47594 [3] https://chromeperf.appspot.com/report?sid=08667dc920902c38df8f1f61344c7e3640cdf2d76822fac8f94eef3e560985ed&start_rev=556241&end_rev=566400 [4] https://reviews.llvm.org/D47652
,
Jul 13
,
Jul 30
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, May 10 2018