New issue
Advanced search Search tips

Issue 841915 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.7% regression in sizes at 556874:556874

Project Member Reported by majidvp@chromium.org, May 10 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 10 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=841915

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=ed24ffa8939f1f648ecb06ce4b3fb0be7f161db48bf52e767fc2b359e00089b7


Bot(s) for this bug's original alert(s):

linux
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, May 10 2018

Owner: vtsyrklevich@chromium.org
Status: Assigned (was: Untriaged)
Assigning to vtsyrklevich@chromium.org because this is the only CL in range:
Reland "[CFI] Enable cfi-icall for official Linux x64 builds"

This is a reland of a6889a090458a2653794c6e63387d6db743dc7f9 now that crrev.com/c/1044502 crrev.com/c/1043259 and crrev.com/c/1043283 fix the previously discovered issues.

Original change's description:
> [CFI] Enable cfi-icall for official Linux x64 builds
>
> The measured size impact is 1.5% and perf impact is ~1%.
>
> Bug:  701919 
> Change-Id: I541242711bc85cc124ff3a2680171577e75475bd
> Reviewed-on: https://chromium-review.googlesource.com/1033918
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554828}

Bug:  701919 
Change-Id: I1a518d356cc6f3599545e594204ce360b4e0360a
Reviewed-on: https://chromium-review.googlesource.com/1045565
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556874}
Status: WontFix (was: Assigned)
This size regression is expected for this change as noted in the commit.

Sign in to add a comment