New issue
Advanced search Search tips

Issue 841906 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

Uncaught Exception failing on chromium.perf/Win 10 High-DPI Perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 10 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of charliea@chromium.org

Uncaught Exception failing on chromium.perf/Win 10 High-DPI Perf

Builders failed on: 
- Win 10 High-DPI Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Win%2010%20High-DPI%20Perf

Link to the exception here: https://www.google.com/url?q=https://logs.chromium.org/v/?s%3Dchrome%252Fbb%252Fchromium.perf%252FWin_10_High-DPI_Perf%252F1921%252F%252B%252Frecipes%252Fsteps%252FUncaught_Exception%252F0%252Flogs%252Fexception%252F0&sa=D&source=hangouts&ust=1526064223115000&usg=AFQjCNETetymFf1KFplEE2zd0BvNbUbeYA

End of callstack: ...
  File "E:\b\rr\tmpjchvf_\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\recipe_api.py", line 377, in run_step
    return self._engine.run_step(step_config)
  File "E:\b\rr\tmpjchvf_\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\run.py", line 232, in run_step
    step_result = open_step.run()
  File "E:\b\rr\tmpjchvf_\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\step_runner.py", line 243, in run
    return construct_step_result(rendered_step, retcode)
  File "E:\b\rr\tmpjchvf_\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_engine\step_runner.py", line 687, in construct_step_result
    result = ph.result(step_result.presentation, td)
  File "E:\b\rr\tmpjchvf_\rw\checkout\scripts\slave\.recipe_deps\recipe_engine\recipe_modules\raw_io\api.py", line 190, in result
    shutil.rmtree(to_nuke)
  File "E:\b\depot_tools\win_tools-2_7_6_bin\python\bin\lib\shutil.py", line 239, in rmtree
    onerror(os.listdir, path, sys.exc_info())
  File "E:\b\depot_tools\win_tools-2_7_6_bin\python\bin\lib\shutil.py", line 237, in rmtree
    names = os.listdir(path)
WindowsError: [Error 3] The system cannot find the path specified: u'\\\\?\\c:\\users\\chrome~1\\appdata\\local\\temp\\tmpka6qbw\\*.*'

This is causing every other run on win-high-dpi to fail altogether.
 
Components: Infra>Platform>Recipes Speed>Benchmarks>Waterfall
Labels: -Pri-2 Pri-1
maruel@ suggested adding an os.exists check around that api.pi:190, which I'm doing now.
Cc: mar...@chromium.org
Owner: charliea@chromium.org
Status: Assigned (was: Available)
Charlie, looks like you're addressing this in https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/1054369. As such, tentatively assigning this back to you, but please LMK if you'd like trooper assistance w/ something here.
Project Member

Comment 4 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/2ee036b744812ca2e9b30fae453ebe3e4dd83f5e

commit 2ee036b744812ca2e9b30fae453ebe3e4dd83f5e
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri May 11 14:24:15 2018

api.py: Check if to_leak directory exists before deleting it

On the chromium.perf/win-high-dpi bots, this directory doesn't exist
some ~50% of the time when we try to call shutil.rmtree, resulting in
an uncaught exception.

R=maruel@chromium.org

TBR=estaab@chromium.org
Bug:  841906 
Change-Id: Ia7062c3948188cf8f6ee600f2006c2cca5d30606
Reviewed-on: https://chromium-review.googlesource.com/1054369
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>

[modify] https://crrev.com/2ee036b744812ca2e9b30fae453ebe3e4dd83f5e/recipe_modules/raw_io/api.py

Status: Fixed (was: Assigned)

Sign in to add a comment