Issue metadata
Sign in to add a comment
|
Drop clang-syntax from Chrome OS build flags |
||||||||||||||||||||||
Issue descriptionChrome OS targets are built with -clang-syntax flag. Occasionally, this flag also gets passed on to host builds (for packages that also build something on host) e.g. by calling tc-getBUILD_CC. Filter it from host clang wrapper to avoid any such issues.
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1c1e20b2995076e535e95422197d6c24335e3675 commit 1c1e20b2995076e535e95422197d6c24335e3675 Author: Manoj Gupta <manojgupta@google.com> Date: Fri May 11 02:40:50 2018 make.conf: Drop clang-syntax flag for target builds. Get rid of the '-clang-syntax' flag for target builds since clang is the default compiler now. BUG= chromium:841903 TEST=No more clang-syntax flag when building. Change-Id: I7cceea21387ea5cbbc176d14d0685466eed68d26 Reviewed-on: https://chromium-review.googlesource.com/1054426 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/1c1e20b2995076e535e95422197d6c24335e3675/chromeos/config/make.conf.generic-target
,
May 11 2018
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c2b8c724b6c43238921de51468e070781762dfd5 commit c2b8c724b6c43238921de51468e070781762dfd5 Author: Manoj Gupta <manojgupta@google.com> Date: Fri May 11 19:10:57 2018 platform: Drop support for clang-syntax. Clang is the default compiler now. So there isn't much value in keeping around the special 'clang-syntax' flag. BUG= chromium:841903 TEST=No more clang-syntax flag when building. Change-Id: Ia11d5b36878654493a40e560a83f74226094646e Reviewed-on: https://chromium-review.googlesource.com/1054436 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/c2b8c724b6c43238921de51468e070781762dfd5/eclass/cros-workon.eclass [modify] https://crrev.com/c2b8c724b6c43238921de51468e070781762dfd5/eclass/platform.eclass
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/aad546f2a06fd7cbc9f00c573d33f2e2a4402afb commit aad546f2a06fd7cbc9f00c573d33f2e2a4402afb Author: Manoj Gupta <manojgupta@google.com> Date: Fri May 11 19:10:58 2018 common-mk: Remove clang-syntax flag. Drop 'clang-syntax' flag from common.gypi. Clang is the default compiler now. So there isn't much value in the special 'clang-syntax' flag. BUG= chromium:841903 TEST=No more clang-syntax flag when building. Change-Id: I1f284aefc9cac2d5627239bf31d4b42898901218 Reviewed-on: https://chromium-review.googlesource.com/1054432 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/aad546f2a06fd7cbc9f00c573d33f2e2a4402afb/common-mk/common.gypi
,
May 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ba96baafaac49481bbdeddae2f13903a4e735872 commit ba96baafaac49481bbdeddae2f13903a4e735872 Author: Manoj Gupta <manojgupta@google.com> Date: Sun May 13 01:12:59 2018 llvm host wrapper: Accept "-clang-syntax" flag. Occasionally "-clang-syntax" flag may leak to host flags if a pckage uses same CFLAGS for target and host builds (host compiler invoked as tc-getBUILD_CC). Move the "-clang-syntax" flag to the common wrapper only flags so that host wrapper can simnply ignore it. BUG= chromium:841903 TEST=x86_64-pc-linux-clang accepts (ignores) -clang-syntax. Change-Id: I4b43a421e5f360d87e0424e64d32b10ca9d02005 Reviewed-on: https://chromium-review.googlesource.com/1055485 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [rename] https://crrev.com/ba96baafaac49481bbdeddae2f13903a4e735872/sys-devel/llvm/llvm-7.0_pre328903_p20180425-r3.ebuild [modify] https://crrev.com/ba96baafaac49481bbdeddae2f13903a4e735872/sys-devel/gcc/files/sysroot_wrapper.body [modify] https://crrev.com/ba96baafaac49481bbdeddae2f13903a4e735872/sys-devel/gcc/gcc-9999.ebuild [modify] https://crrev.com/ba96baafaac49481bbdeddae2f13903a4e735872/sys-devel/llvm/files/wrapper_script_common
,
May 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/66e47ffc269c88889d81c43554151734364e1686 commit 66e47ffc269c88889d81c43554151734364e1686 Author: Manoj Gupta <manojgupta@google.com> Date: Sat May 19 00:19:56 2018 Remove some uses of filter_clang_syntax. We are not passing "-clang-syntax" to packages anymore. So lets remove the flag filtering from the packages. BUG= chromium:841903 TEST=Packages still build. Change-Id: I778debe82654b5ce81e9efbb9464e44809554824 Reviewed-on: https://chromium-review.googlesource.com/1064794 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Yunlian Jiang <yunlian@chromium.org> [modify] https://crrev.com/66e47ffc269c88889d81c43554151734364e1686/chromeos/config/env/sys-boot/gnu-efi [modify] https://crrev.com/66e47ffc269c88889d81c43554151734364e1686/chromeos/config/env/sys-devel/binutils [delete] https://crrev.com/3761a17cec5af019a11dd02c77016b273293013f/chromeos/config/env/dev-util/valgrind [modify] https://crrev.com/66e47ffc269c88889d81c43554151734364e1686/chromeos/config/env/dev-libs/elfutils [delete] https://crrev.com/3761a17cec5af019a11dd02c77016b273293013f/chromeos/config/env/sys-devel/llvm [modify] https://crrev.com/66e47ffc269c88889d81c43554151734364e1686/chromeos/config/env/sys-boot/syslinux [modify] https://crrev.com/66e47ffc269c88889d81c43554151734364e1686/chromeos/config/env/sys-boot/chromeos-mrc [modify] https://crrev.com/66e47ffc269c88889d81c43554151734364e1686/chromeos/config/env/dev-libs/libusb [delete] https://crrev.com/3761a17cec5af019a11dd02c77016b273293013f/chromeos/config/env/dev-lang/luajit [delete] https://crrev.com/3761a17cec5af019a11dd02c77016b273293013f/chromeos/config/env/sys-power/iasl [modify] https://crrev.com/66e47ffc269c88889d81c43554151734364e1686/chromeos/config/env/net-libs/serf [modify] https://crrev.com/66e47ffc269c88889d81c43554151734364e1686/chromeos/config/env/sys-devel/gdb [delete] https://crrev.com/3761a17cec5af019a11dd02c77016b273293013f/chromeos/config/env/dev-embedded/libftdi
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0721e6874fe6fa422dc97c48224ab4c751afa0c8 commit 0721e6874fe6fa422dc97c48224ab4c751afa0c8 Author: Manoj Gupta <manojgupta@google.com> Date: Tue May 22 19:56:25 2018 common-mk: Remove clang-syntax flag. Drop 'clang-syntax' flag from platform2.py. Clang is the default compiler now. So there isn't much value in the special 'clang-syntax' flag. BUG= chromium:841903 TEST=No more clang-syntax flag when building. Change-Id: I5dcb099ce7d0709f21805902fe140f606100f870 Reviewed-on: https://chromium-review.googlesource.com/1068022 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/0721e6874fe6fa422dc97c48224ab4c751afa0c8/common-mk/platform2.py
,
Jun 4 2018
"clang-syntax" is removed from the builds. Still leaving the support in compiler wrapper for any occasional testing. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by llozano@chromium.org
, May 10 2018