New issue
Advanced search Search tips

Issue 841889 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 841768
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

ResolutionNotificationControllerTest fails on MSan

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 10 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of dmurph@chromium.org

fails on MSan:

ResolutionNotificationControllerTest.Timeout
ResolutionNotificationControllerTest.Close
ResolutionNotificationControllerTest.Basic
ResolutionNotificationControllerTest.ClickMeansAccept
ResolutionNotificationControllerTest.Fallback
ResolutionNotificationControllerTest.AcceptButton
ResolutionNotificationControllerTest.MultipleResolutionChange

Builders failed on: 
- Linux ChromiumOS MSan Tests: 
  https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests

First failure:
https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7079

Sheriff-o-matic is having trouble working for some reason - we'll have to use the bot's commits as the commit range.
 

Comment 1 by dmu...@chromium.org, May 10 2018

Log:

[ RUN      ] ResolutionNotificationControllerTest.Basic
==4650==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x48e5f7e in ash::Shelf::IsHorizontalAlignment() const ./../../ash/shelf/shelf.cc:128:11
    #1 0x4a0d135 in ash::WebNotificationItem::AnimationProgressed(gfx::Animation const*) ./../../ash/system/message_center/notification_tray.cc:193:25
    #2 0x7a049e1 in gfx::LinearAnimation::Step(base::TimeTicks) ./../../ui/gfx/animation/linear_animation.cc:78:17
    #3 0x7a00bfd in gfx::AnimationContainer::Run() ./../../ui/gfx/animation/animation_container.cc:91:13
    #4 0x50af6ed in Run ./../../base/callback.h:125:12
    #5 0x50af6ed in base::Timer::RunScheduledTask() ./../../base/timer/timer.cc:263:0
    #6 0x518a3f1 in Run ./../../base/callback.h:96:12
    #7 0x518a3f1 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:101:0
    #8 0x4faaad4 in base::MessageLoop::RunTask(base::PendingTask*) ./../../base/message_loop/message_loop.cc:319:25
    #9 0x4fad86a in DeferOrRunPendingTask ./../../base/message_loop/message_loop.cc:329:5
    #10 0x4fad86a in base::MessageLoop::DoDelayedWork(base::TimeTicks*) ./../../base/message_loop/message_loop.cc:413:0
    #11 0x51746f6 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:220:27
    #12 0x5010a3d in Run ./../../base/run_loop.cc:131:14
    #13 0x5010a3d in base::RunLoop::RunUntilIdle() ./../../base/run_loop.cc:144:0
    #14 0x8ee4e95 in RunAllPendingInMessageLoop ./../../ash/test/ash_test_helper.cc:268:12
    #15 0x8ee4e95 in ash::AshTestHelper::TearDown() ./../../ash/test/ash_test_helper.cc:223:0
    #16 0x8edaa11 in ash::AshTestBase::TearDown() ./../../ash/test/ash_test_base.cc:186:21
    #17 0x44a9a9b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #18 0x44ab519 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #19 0x44e1dd4 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #20 0x44e06c2 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #21 0x520e3a6 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #22 0x520e3a6 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
    #23 0x521645e in Run ./../../base/callback.h:96:12
    #24 0x521645e in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0
    #25 0x5215c6e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) ./../../base/test/launcher/unit_test_launcher.cc:576:10
    #26 0x20156b2 in main ./../../ash/test/ash_unittests.cc:14:10
    #27 0x7fd353499f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
    #28 0x617599 in _start ??:0:0
  Uninitialized value was created by a heap deallocation
    #0 0x689e09 in operator delete(void*) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cc:74:44
    #1 0x4aecacf in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2321:5
    #2 0x4aecacf in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2634:0
    #3 0x4aecacf in ash::StatusAreaWidget::~StatusAreaWidget() ./../../ash/system/status_area_widget.cc:131:0
    #4 0x4aedbec in ash::StatusAreaWidget::~StatusAreaWidget() ./../../ash/system/status_area_widget.cc:128:39
    #5 0x495e6bb in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2321:5
    #6 0x495e6bb in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2634:0
    #7 0x495e6bb in ash::ShelfWidget::Shutdown() ./../../ash/shelf/shelf_widget.cc:239:0
    #8 0x4896e5f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:489:11
    #9 0x498b50a in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1393:19
    #10 0x49819ec in ash::Shell::~Shell() ./../../ash/shell.cc:822:3
    #11 0x498b89c in ash::Shell::~Shell() ./../../ash/shell.cc:718:17
    #12 0x8f3e969 in Shutdown ./../../ash/window_manager.cc:247:3
    #13 0x8f3e969 in ash::WindowManager::~WindowManager() ./../../ash/window_manager.cc:89:0
    #14 0x8f3f45c in ash::WindowManager::~WindowManager() ./../../ash/window_manager.cc:88:33
    #15 0x8f498be in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2321:5
    #16 0x8f498be in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2634:0
    #17 0x8f498be in ash::WindowManagerService::~WindowManagerService() ./../../ash/window_manager_service.cc:54:0
    #18 0x8f4a00c in ash::WindowManagerService::~WindowManagerService() ./../../ash/window_manager_service.cc:46:47
    #19 0x8ee4e30 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2321:5
    #20 0x8ee4e30 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2634:0
    #21 0x8ee4e30 in ash::AshTestHelper::TearDown() ./../../ash/test/ash_test_helper.cc:215:0
    #22 0x8edaa11 in ash::AshTestBase::TearDown() ./../../ash/test/ash_test_base.cc:186:21
    #23 0x44a9a9b in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #24 0x44ab519 in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #25 0x44e1dd4 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #26 0x44e06c2 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
    #27 0x520e3a6 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #28 0x520e3a6 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0
    #29 0x521645e in Run ./../../base/callback.h:96:12
    #30 0x521645e in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) ./../../base/test/launcher/unit_test_launcher.cc:225:0
SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/ash_unittests+0x48e5f7e)
Exiting
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6370aecafa241206aa031d26344effbb2d8b50f

commit b6370aecafa241206aa031d26344effbb2d8b50f
Author: Daniel Murphy <dmurph@chromium.org>
Date: Thu May 10 18:37:37 2018

Revert "cros - Update appearance of resolution change notification."

This reverts commit f57e1c35076dedd3a90ab55adae20772404b6702.

Reason for revert: There are ash and mash_ash failures, reverting because it's ash-related. See  crbug.com/841889 


Original change's description:
> cros - Update appearance of resolution change notification.
> 
> This removes the last raster asset in ash_resources.grd, so remove that
> file and the associated build target.
> 
> Bug:  840509 ,505953
> Change-Id: I43ec69b5b8b9fc34aa71a1b65f204447e73b133c
> Reviewed-on: https://chromium-review.googlesource.com/1050523
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557292}

TBR=jamescook@chromium.org,sky@chromium.org,estade@chromium.org

Change-Id: I4b0ce3e1d01b5b8e390216b379f4158380f542b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  840509 , 505953,  841889 
Reviewed-on: https://chromium-review.googlesource.com/1054118
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557598}
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/BUILD.gn
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/display/resolution_notification_controller.cc
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/resources/BUILD.gn
[add] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/resources/ash_resources.grd
[add] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/resources/default_100_percent/cros/notification/display_notification_icon.png
[add] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/resources/default_200_percent/cros/notification/display_notification_icon.png
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/system/bluetooth/bluetooth_notification_controller.cc
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/system/locale/locale_notification_controller.cc
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/system/power/battery_notification.cc
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/system/power/dual_role_notification.cc
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/system/power/peripheral_battery_notifier.cc
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/system/power/tray_power.cc
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/system/screen_security/screen_capture_tray_item.cc
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/ash/system/screen_security/screen_share_tray_item.cc
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/chrome/browser/ui/app_list/DEPS
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/chrome/browser/ui/app_list/crostini/crostini_app_model_builder.cc
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/chrome/chrome_paks.gni
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/chrome/test/BUILD.gn
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/tools/check_grd_for_unused_strings.py
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/tools/gritsettings/resource_ids
[modify] https://crrev.com/b6370aecafa241206aa031d26344effbb2d8b50f/tools/resources/find_unused_resources.py

Comment 3 by dmu...@chromium.org, May 10 2018

Cc: est...@chromium.org
Owner: est...@chromium.org
Status: Assigned (was: Available)
Evan says the fix is in the CQ. Assigning to them.

Comment 4 by est...@chromium.org, May 10 2018

Mergedinto: 841768
Status: Duplicate (was: Assigned)

Sign in to add a comment