New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841877 link

Starred by 2 users
Status: Assigned
Owner:
mxnguyen@chromium.org
Cc:
sorin@chromium.org
█ amp@chromium.org
█ bartekn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Media Router QA channel does not update using --extension-updater-test-request flag

Project Member Reported by dbbrooks@chromium.org, May 10 2018 
Chrome: 68.0.3423.2
Platform: All platforms

Note: this works if you use 68.0.3409.2. So somewhere between that and 68.0.3423.2 it stopped working.

Repro steps:
(1) Start Chrome dev (M68) with the --show-component-extension-options flag.
(2) On the Chrome://extensions page, check the version of Chrome Media Router. It will show 6818.430.0.0 which is the release version.
(3) Close and restart Chrome again, adding the --extension-updater-test-request flag.
(4) Again, on the Chrome://extensions page, check the version of Chrome Media Router. 

Expected: The MR QA channel version 6818.507.0.0 should be loaded. 

Actual: The release version is still used. 

If a new user data directory is created, e.g --user-data-dir=<new dir>, then the QA channel is loaded. This has always worked without having to use a new directory, until now. The only exception is when the QA version is lower than the released version, which isn't the case here.

Comment 1 by rdevlin....@chromium.org, May 11 2018

Cc: sorin@chromium.org
Owner: mxnguyen@chromium.org
Status: Assigned (was: Untriaged)
I'm not familiar with this flag (looks like amp@ added it in revision 466f001b62c8782eecf2809a94e5ba69f92a4556).  Maybe something to do with the new update client work?

Comment 2 by mxnguyen@chromium.org, May 11 2018

Cc: bartekn@chromium.org

Comment 3 by mxnguyen@chromium.org, May 11 2018 

Thank you for bringing up the issue. 

I think what happened is the machine running this test is selected for the experiment of the new extension updater. The new extension updater doesn't have this "testrequest" attribute in its update check requests, as the result, the QA version is never updated due to the missing "testrequest" attribute. I'll provide a fix for this problem soon.
Project Member

Comment 4 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55afbe42e3931c4835c53104ea805e41ac8e0f18

commit 55afbe42e3931c4835c53104ea805e41ac8e0f18
Author: Minh X. Nguyen <mxnguyen@chromium.org>
Date: Fri May 18 22:04:26 2018

[update_client] Separate the command line switches from the configurator.

Bug: 841877, 722942
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I17995c9163537d45ff566158663c7262dd8c2807
Reviewed-on: https://chromium-review.googlesource.com/1057898
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Minh Nguyen <mxnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560063}
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/chrome_extension_downloader_factory.cc
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/chrome_update_client_config.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/extension_update_client_command_line_config_policy.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/extension_update_client_command_line_config_policy.h
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/extension_update_client_command_line_config_policy_unittest.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/extension_updater_switches.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/browser/extensions/updater/extension_updater_switches.h
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/chrome/test/BUILD.gn
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/BUILD.gn
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/component_updater_command_line_config_policy.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/component_updater_command_line_config_policy.h
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/configurator_impl.cc
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/configurator_impl.h
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/component_updater/configurator_impl_unittest.cc
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/update_client/BUILD.gn
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/update_client/command_line_config_policy.cc
[add] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/components/update_client/command_line_config_policy.h
[modify] https://crrev.com/55afbe42e3931c4835c53104ea805e41ac8e0f18/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc
►

Sign in to add a comment