Presubmit checks to make sure that new UI doesn't break VR |
||||
Issue descriptionAlthough we have a plan to make sure that existing UI doesn't break VR, any new UI has the potential to break the VR experience. We need to add presubmit checks to make sure that new UI elements follow the design (using ModalDialogManager or UiWidgetFactory).
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2636351c5580998b06cd0ea6ba41d85702d1add6 commit 2636351c5580998b06cd0ea6ba41d85702d1add6 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Mon May 28 14:12:28 2018 Presubmit checks to stop AlertDialog.Builder Presubmit check is added to make sure that no new instance of AlertDialog is added to the code. All the current instances are whitelisted. The whitelist must be updated when one of the existing AlertDialogs is replaced with ModalDialogView. This is not the only presubmit check that is needed, more presubmit checks are needed for the rest of the 2D Popups. Note that previous presubmit check had a minor mistake in its whitelist. This CL also fixes that issue. Bug: 841863 Change-Id: I0d5c3a604f1544730c6df0b272a5971f9a00ac21 Reviewed-on: https://chromium-review.googlesource.com/1064553 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#562255} [modify] https://crrev.com/2636351c5580998b06cd0ea6ba41d85702d1add6/chrome/android/java/src/PRESUBMIT.py [modify] https://crrev.com/2636351c5580998b06cd0ea6ba41d85702d1add6/chrome/android/java/src/PRESUBMIT_test.py
,
Jul 9
,
Aug 2
,
Aug 27
|
||||
►
Sign in to add a comment |
||||
Comment 1 by yfried...@chromium.org
, May 10 2018