Vertical separator in Settings should be 32px |
||||||
Issue description
Vertical separator in Settings UI should be same height as buttons (32px).
Example: Next to Sign-in/sign out in People
Next to Reset to Default in Appearances
,
May 10 2018
Posting before/after screenshots.
,
May 10 2018
Candidate CL at https://chromium-review.googlesource.com/c/chromium/src/+/1054552
,
May 11 2018
,
May 12 2018
,
May 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d30fa167b5e4019d8b61b3a82591281f6e8e0bf2 commit d30fa167b5e4019d8b61b3a82591281f6e8e0bf2 Author: dpapad <dpapad@chromium.org> Date: Sat May 12 00:51:21 2018 WebUI MD Refresh: Adjust separator height/margin and button height. - Changing button and separator height to 32px. - Changing separator margin to 16px. - Removing obsolete logic to use a negative margin for non primary buttons. It is obsolete since both types of buttons now have a border and they can use the same amount of margin. Bug: 841858 , 832173 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1b3bf0d5a7f6b4e81bc5e25a16b422a54487214b Reviewed-on: https://chromium-review.googlesource.com/1054552 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#558075} [modify] https://crrev.com/d30fa167b5e4019d8b61b3a82591281f6e8e0bf2/chrome/browser/resources/settings/appearance_page/appearance_page.html [modify] https://crrev.com/d30fa167b5e4019d8b61b3a82591281f6e8e0bf2/chrome/browser/resources/settings/controls/controlled_button.html [modify] https://crrev.com/d30fa167b5e4019d8b61b3a82591281f6e8e0bf2/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/d30fa167b5e4019d8b61b3a82591281f6e8e0bf2/ui/webui/resources/cr_elements/paper_button_style_css.html
,
May 14 2018
Verified the fix on Mac 10.12.6, Windows-10 and Ubuntu 14.04 using Chrome version #68.0.3430.0 as per the comment #0 and #2. Attaching screen shot for reference. Observed that the height of vertical separator and sign in button are same. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version with out fix. Thanks...!!
,
May 14 2018
,
May 14 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpa...@chromium.org
, May 10 2018Components: -UI>Browser>WebUI UI>Settings
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)