k-rate-panner test is flaky |
||
Issue descriptionSee, for example, https://travis-ci.org/w3c/web-platform-tests/jobs/377051289 The (success) message prints out the number of places where the difference of two arrays is not zero. But the number of such places changes on each run. This is really weird. The test should be completely deterministic and the differences should be the same. And if you replace the OscillatorNode with a ConstantSourceNode, the flakiness goes away.
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8f7147a8446881dc80c9570183cd4d935e5e63e commit b8f7147a8446881dc80c9570183cd4d935e5e63e Author: Raymond Toy <rtoy@chromium.org> Date: Mon Jun 18 19:21:05 2018 Fix flaky k-rate-panner test Change the testing scheme for k-rate panner to verify that the output is piecewise constant for a constant source when the automation rate is set to k-rate. Reduce the duration of the test as well; Just a few render quanta is enough to verify that the output is piece-wise constant and different from the a-rate output. Also updated k-rate-constant-source.html to use the same doTest method since the special case is supported. Didn't actually figure out the underlying flakiness of the original test. Bug: 841856 Change-Id: I8e9807e530fc3b1452bae521a2660be3fbe104f9 Reviewed-on: https://chromium-review.googlesource.com/1076809 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568100} [modify] https://crrev.com/b8f7147a8446881dc80c9570183cd4d935e5e63e/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/automation-rate-testing.js [modify] https://crrev.com/b8f7147a8446881dc80c9570183cd4d935e5e63e/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source.html [modify] https://crrev.com/b8f7147a8446881dc80c9570183cd4d935e5e63e/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner.html
,
Jun 22 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by rtoy@chromium.org
, Jun 8 2018