WebUI MD Refresh: Update corner radius of all cards |
|||||||||||||||||||||
Issue descriptionUpdate cards in Setting, Bookmarks, Extensions, Downloads, History 1. 4dp corner radius 2. Elevation: #3C4043, 30% (0,1,2,0) #3C4043, 15% (0,1,3,1)
,
May 10 2018
,
May 11 2018
i will take this issue. Please assign me as an owner.
,
May 11 2018
Targeting M68 for corner radius, M69 for elevation.
,
May 11 2018
,
May 12 2018
Reducing the scope of this bug. Filed separate bug for elevation.
,
May 12 2018
,
May 15 2018
attached screenshots
,
May 15 2018
Assigning to myself for tracking. Thanks Eui-sang for sending the CL :)
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55c107386ba87bc1139a3361269f7adf5d389a5e commit 55c107386ba87bc1139a3361269f7adf5d389a5e Author: Euisang Lim <eui-sang.lim@samsung.com> Date: Wed May 16 22:17:49 2018 [WebUI] Update corner radius of all cards Apply 4dp corner radius to cards in Settings, Bookmarks, Extensions, Downloads, and History. Add --cr-card-border-radius in cr_elements/shared_vars_css.html to be used in all files. Bug: 841848 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id509e89be2b3c97f6d9b60662ab959b3fca59469 Reviewed-on: https://chromium-review.googlesource.com/1056928 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559308} [modify] https://crrev.com/55c107386ba87bc1139a3361269f7adf5d389a5e/chrome/browser/resources/md_bookmarks/list.html [modify] https://crrev.com/55c107386ba87bc1139a3361269f7adf5d389a5e/chrome/browser/resources/md_downloads/item.html [modify] https://crrev.com/55c107386ba87bc1139a3361269f7adf5d389a5e/chrome/browser/resources/md_extensions/item.html [modify] https://crrev.com/55c107386ba87bc1139a3361269f7adf5d389a5e/chrome/browser/resources/md_extensions/keyboard_shortcuts.html [modify] https://crrev.com/55c107386ba87bc1139a3361269f7adf5d389a5e/chrome/browser/resources/md_history/history_item.html [modify] https://crrev.com/55c107386ba87bc1139a3361269f7adf5d389a5e/chrome/browser/resources/md_history/shared_style.html [modify] https://crrev.com/55c107386ba87bc1139a3361269f7adf5d389a5e/chrome/browser/resources/md_history/synced_device_card.html [modify] https://crrev.com/55c107386ba87bc1139a3361269f7adf5d389a5e/chrome/browser/resources/settings/settings_page/settings_section.html [modify] https://crrev.com/55c107386ba87bc1139a3361269f7adf5d389a5e/ui/webui/resources/cr_elements/shared_vars_css.html
,
May 17 2018
Able to reproduce this issue on build without fix(68.0.3430.0), hence verifying the fix on latest canary 68.0.3433.0 using Mac, Windows 10 and Ubuntu 14.04 Now observing rounded corners(When compared to build without fix) in History, Bookmarks, extensions , settings, Downloads. As fix is working as expected adding Verified labels. Thanks!
,
May 18 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by namratakannan@chromium.org
, May 10 2018