New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841839 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 831852



Sign in to add a comment

Background color to #F8F9FA(GG50) from #F1F1F1

Project Member Reported by namratakannan@chromium.org, May 10 2018

Issue description

Change the background color for Web UI pages(Settings, Extensions,History,Bookmarks,Downloads) from #F!F!F! to #F8F9FA (GG50) for MD Refresh



 
Description: Show this description

Comment 2 by dpa...@chromium.org, May 10 2018

Blocking: 831852
Status: Available (was: Untriaged)
i will take this issue.

Comment 4 by dpa...@chromium.org, May 11 2018

Labels: M-68

Comment 5 by dpa...@chromium.org, May 12 2018

Labels: Proj-MaterialDesign-Refresh-WebUI
https://chromium-review.googlesource.com/c/chromium/src/+/1055029 seems ready to be submitted.
Could somebody help me submit this patch to the CQ since I don't have try job access? 
Also, I can't edit the bug as fixed or closed.
I submitted for you, should be landing soon
Owner: scottchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 9 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/311cb1b4bd88be4517d3734f117a0b74edd1bd7c

commit 311cb1b4bd88be4517d3734f117a0b74edd1bd7c
Author: Euisang Lim <eui-sang.lim@samsung.com>
Date: Fri May 18 14:57:40 2018

[WebUI] Change the background color for Web UI pages

Change the background color for Web UI pages(Settings, Extensions,
History, Bookmarks, Downloads) from #F1F1F1 to #F8F9FA(GG50)
for MD Refresh.

Change the background-color of each files of Settings, Extensions,
and Downloads.

Change --md-background-color in ui/webui for History and Bookmarks
which use var(--md-background-color).

Bug:  841839 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib6eeb53f38e385f1de617e5eaba83e8325d7119a
Reviewed-on: https://chromium-review.googlesource.com/1055029
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559893}
[modify] https://crrev.com/311cb1b4bd88be4517d3734f117a0b74edd1bd7c/chrome/browser/resources/md_downloads/downloads.html
[modify] https://crrev.com/311cb1b4bd88be4517d3734f117a0b74edd1bd7c/chrome/browser/resources/md_extensions/extensions.html
[modify] https://crrev.com/311cb1b4bd88be4517d3734f117a0b74edd1bd7c/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/311cb1b4bd88be4517d3734f117a0b74edd1bd7c/ui/webui/resources/css/md_colors.css

Status: Fixed (was: Started)
Cc: jmukthavaram@chromium.org
Labels: Needs-Feedback
Could you please let us know the exact steps to verify this issue from TE End & what are all the flags to be enabled to check this issue.

 Tried to launch chrome with --md-background-color flag but no difference in background color observed in chrome UI pages (chrome://settings,chrome://Bookmarks,chrome://history & chrome://extensions on Canary-	68.0.3436.0.

Thanks..!




It doesn't seem like the change is on canary yet, pleaes wait another day or two to verify.
>  Tried to launch chrome with --md-background-color flag but no difference in background color observed in chrome UI pages 

Also note that there is no --md-background-color flag. That's not the right way to try to verify this change.

Sign in to add a comment