New issue
Advanced search Search tips

Issue 841830 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug

Blocked on:
issue 847284

Blocking:
issue 843903


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Unify Trace and TraceWrappers

Project Member Reported by mlippautz@chromium.org, May 10 2018

Issue description

Tracking bug for work related to unifying Trace and TraceWrappers methods.

Design doc: https://docs.google.com/document/d/1WSZHM0WhWlYfI8Jb4ZPjtib7zbegm_cN6P-MfbR6Pkw
 
Peria already worked on this in 6a7273d9d2067df31de6f5412e5b8f97cde20189.

  cleanup: Code clean-up around Trace() and TraceWrappers()

  - Drops two unnecessary TraceWrappers(). They just call TW() of parent classes.
  - Add a trace in Trace().


  Bug: 581412
  Change-Id: I726fcea1872488ab98541b8a7cce233793815da8
  Reviewed-on: https://chromium-review.googlesource.com/1053336
  Reviewed-by: Kentaro Hara <haraken@chromium.org>
  Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#557464}

Comment 2 by peria@chromium.org, May 11 2018

Thank you for filing this tracking bug. I put a wrong issue for the CL. :(

Comment 3 by peria@chromium.org, May 11 2018

Spreadsheet to track which files we need work for before the unification;
https://docs.google.com/spreadsheets/d/1EQikfa2bZIYn2deltkWv8tmaA0jGsBDbXaqu1orpC8E/edit#gid=0
Project Member

Comment 4 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a299bcef98da5b6fb1eea35ac86060a9b9250e2

commit 2a299bcef98da5b6fb1eea35ac86060a9b9250e2
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Mon May 14 04:50:24 2018

oilpan: Trace Node::GetEventTargetData()

The target object is already traced in Oilpan from a static persistent map,
but this CL adds a trace to make TraceWrappers() a subset of
Trace() for unification.


Bug:  841830 
Change-Id: I3bec0361aa34ac7a0dc82fcb0cf3d823ea58057a
Reviewed-on: https://chromium-review.googlesource.com/1055013
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558197}
[modify] https://crrev.com/2a299bcef98da5b6fb1eea35ac86060a9b9250e2/third_party/blink/renderer/core/dom/node.cc

peria-san: Would you investigate how to merge TraceWrappers into Trace before Michael comes to Tokyo? Is there any blocker for making that change?


Comment 6 by peria@chromium.org, May 17 2018

I'm trying to unify locally. Let me share if I find some concerns or questions.

- Currently, we have no blink::Visitor::Trace(const TraceWrapperV8Reference<V8Type>&). Hence the current call graph is not a subgraph. We'll need to work for it again.
- Don't we need to take care TraceWrappersWithManualBarrier()? I mean, can we simply replace it with visitor->Trace()?
- There seems to be some untracked Trace() and TraceWrappers() in test code.
  e.g. bindings/core/v8/script_wrappable_marking_visitor_test.cc
Owner: peria@chromium.org
> - Currently, we have no blink::Visitor::Trace(const TraceWrapperV8Reference<V8Type>&). Hence the current call graph is not a subgraph. We'll need to work for it again.

Yes. Let's chat with Michael and figure out how to do this.

> - Don't we need to take care TraceWrappersWithManualBarrier()? I mean, can we simply replace it with visitor->Trace()?

Right. We'll need to introduce TraceAsTraceWrappersWithManualWriteBarrier(). Otherwise the GC cannot understand that it should visit the raw pointer as a TraceWrapperMember. Let's chat with Michael next week.

> - There seems to be some untracked Trace() and TraceWrappers() in test code.

Would you mind fixing it?


Comment 8 by peria@chromium.org, May 17 2018

>> - Currently, we have no blink::Visitor::Trace(const TraceWrapperV8Reference<V8Type>&). Hence the current call graph is not a subgraph. We'll need to work for it again.
>
> Yes. Let's chat with Michael and figure out how to do this.

We can define few new blink::Visitor::Trace() as empty methods to cover not-yet-Traced types. Then we can make TW graph a subgraph of Trace graph.


>> - Don't we need to take care TraceWrappersWithManualBarrier()? I mean, can we simply replace it with visitor->Trace()?
>
> Right. We'll need to introduce TraceAsTraceWrappersWithManualWriteBarrier(). Otherwise the GC cannot understand that it should visit the raw pointer as a TraceWrapperMember. Let's chat with Michael next week.

I think Visitor::TraceWithBarrier() can trace as usual Trace(), and SWVisitor::TraceWithBarrier() overloads it as it works.


>> - There seems to be some untracked Trace() and TraceWrappers() in test code.
>
> Would you mind fixing it?
Yes, will do. :)

Comment 9 by peria@chromium.org, May 18 2018

> - There seems to be some untracked Trace() and TraceWrappers() in test code.

HandleContainer and Base classes in bindings/core/v8/script_wrappable_marking_visitor_test.cc seem to be the only case, but they need Visitor::Trace(TWMemberV8Reference).
Blocking: 843903
Project Member

Comment 12 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/457c305ce7a951809eb627a852158366df0ec238

commit 457c305ce7a951809eb627a852158366df0ec238
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Wed May 23 12:06:57 2018

[oilpan] Move name callbacks into GCInfo

This moves the NameCallback from the fast path (trace descriptor) to a
slow path in GCInfo. It also allows for implementing naming for the rest
of the DOM.

Bug:  chromium:841830 
Change-Id: I61e8043855eb673ea173b92627e78df3e7eff0ab
Reviewed-on: https://chromium-review.googlesource.com/1069964
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561040}
[modify] https://crrev.com/457c305ce7a951809eb627a852158366df0ec238/third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc
[modify] https://crrev.com/457c305ce7a951809eb627a852158366df0ec238/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.cc
[modify] https://crrev.com/457c305ce7a951809eb627a852158366df0ec238/third_party/blink/renderer/platform/bindings/script_wrappable_visitor.h
[modify] https://crrev.com/457c305ce7a951809eb627a852158366df0ec238/third_party/blink/renderer/platform/heap/BUILD.gn
[modify] https://crrev.com/457c305ce7a951809eb627a852158366df0ec238/third_party/blink/renderer/platform/heap/garbage_collected.h
[modify] https://crrev.com/457c305ce7a951809eb627a852158366df0ec238/third_party/blink/renderer/platform/heap/gc_info.h
[modify] https://crrev.com/457c305ce7a951809eb627a852158366df0ec238/third_party/blink/renderer/platform/heap/gc_info_test.cc
[add] https://crrev.com/457c305ce7a951809eb627a852158366df0ec238/third_party/blink/renderer/platform/heap/name_traits.h
[modify] https://crrev.com/457c305ce7a951809eb627a852158366df0ec238/third_party/blink/renderer/platform/heap/trace_traits.h

Project Member

Comment 13 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26c540f3dc126c1406bdfa340e809656d94b9591

commit 26c540f3dc126c1406bdfa340e809656d94b9591
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Thu May 24 00:37:28 2018

[wrapper-tracing] Use name for missed write barriers

This avoids writing a pointer for each traced wrapper on dispatch. It
also brings the wrapper tracing descriptor closer to the regular trace
descriptor.

Bug:  chromium:841830 
Change-Id: I6be7566a465184b12d9021926b3a61cd66934bc6
Reviewed-on: https://chromium-review.googlesource.com/1067572
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561335}
[modify] https://crrev.com/26c540f3dc126c1406bdfa340e809656d94b9591/third_party/blink/renderer/platform/bindings/script_wrappable_visitor_verifier.h
[modify] https://crrev.com/26c540f3dc126c1406bdfa340e809656d94b9591/third_party/blink/renderer/platform/heap/blink_gc.h
[modify] https://crrev.com/26c540f3dc126c1406bdfa340e809656d94b9591/third_party/blink/renderer/platform/heap/garbage_collected.h
[modify] https://crrev.com/26c540f3dc126c1406bdfa340e809656d94b9591/third_party/blink/renderer/platform/heap/trace_traits.h

Project Member

Comment 14 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/784b75f41cd3f8c59f57eced481c9545d32d2016

commit 784b75f41cd3f8c59f57eced481c9545d32d2016
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Thu May 24 06:05:31 2018

[wrapper-tracing] Move visitor parts to blink::Visitor

Move wrapper tracing visitation to regular blink::Visitor and inherit
from that in blink::ScriptWrappableVisitor. This is prework for removing
TraceWrappers and solely rely on Trace methods, even for wrapper tracing.

The bigger idea is to bring Trace in sync with TraceWrappers and drop
TraceWrappers completely. The visitors should distinguish which part
of the graph the would like to trace.

Bug:  chromium:841830 
Change-Id: Iae4d000318f8fd2f81eb9c66ed0a625699bada34
Reviewed-on: https://chromium-review.googlesource.com/1068890
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561395}
[modify] https://crrev.com/784b75f41cd3f8c59f57eced481c9545d32d2016/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.cc
[modify] https://crrev.com/784b75f41cd3f8c59f57eced481c9545d32d2016/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.h
[modify] https://crrev.com/784b75f41cd3f8c59f57eced481c9545d32d2016/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc
[modify] https://crrev.com/784b75f41cd3f8c59f57eced481c9545d32d2016/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.h
[modify] https://crrev.com/784b75f41cd3f8c59f57eced481c9545d32d2016/third_party/blink/renderer/platform/bindings/script_wrappable_visitor.h
[modify] https://crrev.com/784b75f41cd3f8c59f57eced481c9545d32d2016/third_party/blink/renderer/platform/bindings/script_wrappable_visitor_verifier.h
[modify] https://crrev.com/784b75f41cd3f8c59f57eced481c9545d32d2016/third_party/blink/renderer/platform/heap/incremental_marking_test.cc
[modify] https://crrev.com/784b75f41cd3f8c59f57eced481c9545d32d2016/third_party/blink/renderer/platform/heap/marking_verifier.h
[modify] https://crrev.com/784b75f41cd3f8c59f57eced481c9545d32d2016/third_party/blink/renderer/platform/heap/marking_visitor.h
[modify] https://crrev.com/784b75f41cd3f8c59f57eced481c9545d32d2016/third_party/blink/renderer/platform/heap/visitor.h

Project Member

Comment 15 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53607a11346131adac452b1a050ec5c6a5b5516e

commit 53607a11346131adac452b1a050ec5c6a5b5516e
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Thu May 24 09:27:04 2018

[wrapper-tracing] Remove dead code leftover

Bug:  chromium:841830 
Change-Id: I0e00b0eca368d6471996288677eb45ea09a55977
Reviewed-on: https://chromium-review.googlesource.com/1071407
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561439}
[modify] https://crrev.com/53607a11346131adac452b1a050ec5c6a5b5516e/third_party/blink/renderer/platform/bindings/script_wrappable_visitor.h

Project Member

Comment 16 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68d0a5f03bfddab66aebe21dfe088cdc855c5e5d

commit 68d0a5f03bfddab66aebe21dfe088cdc855c5e5d
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Fri May 25 00:04:09 2018

[wrapper-tracing] Allow tracing wrappers from ScriptWrappable

This CL duplicates SW::TraceWrappers into SW::Trace which is require to
rely solely on Trace.

Bug:  chromium:841830 
Change-Id: I27ef0b4590b1bb1ba26bd59308fa718a06ab6936
Reviewed-on: https://chromium-review.googlesource.com/1071028
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561698}
[modify] https://crrev.com/68d0a5f03bfddab66aebe21dfe088cdc855c5e5d/third_party/blink/renderer/platform/bindings/dom_data_store.h
[modify] https://crrev.com/68d0a5f03bfddab66aebe21dfe088cdc855c5e5d/third_party/blink/renderer/platform/bindings/dom_wrapper_world.cc
[modify] https://crrev.com/68d0a5f03bfddab66aebe21dfe088cdc855c5e5d/third_party/blink/renderer/platform/bindings/dom_wrapper_world.h
[modify] https://crrev.com/68d0a5f03bfddab66aebe21dfe088cdc855c5e5d/third_party/blink/renderer/platform/bindings/script_wrappable.cc
[modify] https://crrev.com/68d0a5f03bfddab66aebe21dfe088cdc855c5e5d/third_party/blink/renderer/platform/bindings/script_wrappable.h
[modify] https://crrev.com/68d0a5f03bfddab66aebe21dfe088cdc855c5e5d/third_party/blink/renderer/platform/heap/visitor.h

Project Member

Comment 17 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c352304174e122e28308f213b36d9eb96d594e1

commit 6c352304174e122e28308f213b36d9eb96d594e1
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Fri May 25 04:00:28 2018

[wrapper-tracing] Add ScriptWrappableVisitor unit tests

Add unit tests that make sure that visitor dispatch reaches the expected leafs.

Bug:  chromium:841830 
Change-Id: I7dba068b66759312a41adfd0a2090af8b007e6fe
Reviewed-on: https://chromium-review.googlesource.com/1072212
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561762}
[modify] https://crrev.com/6c352304174e122e28308f213b36d9eb96d594e1/third_party/blink/renderer/bindings/bindings.gni
[add] https://crrev.com/6c352304174e122e28308f213b36d9eb96d594e1/third_party/blink/renderer/bindings/core/v8/script_wrappable_visitor_test.cc
[modify] https://crrev.com/6c352304174e122e28308f213b36d9eb96d594e1/third_party/blink/renderer/core/testing/death_aware_script_wrappable.h

Project Member

Comment 18 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f4f9c38ab9dc07a07176da93a5d56e52e04979

commit 90f4f9c38ab9dc07a07176da93a5d56e52e04979
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Fri May 25 04:56:10 2018

[oilpan] Add TraceWrapperV8Reference to Trace

This is in preparation of using Trace instead of TraceWrappers for
wrapper tracing.

Bug:  chromium:841830 
Change-Id: I59a2ee4ad923361109ee387be76f8d08d1b67413
Reviewed-on: https://chromium-review.googlesource.com/1072214
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561771}
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.h
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/bindings/core/v8/v8_abstract_event_listener.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/core/dom/events/custom_event.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/core/events/error_event.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/core/events/pop_state_event.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/core/events/promise_rejection_event.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/core/layout/custom/css_layout_definition.h
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/core/script/module_script.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/core/timing/performance_mark.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/modules/animationworklet/animator.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/modules/animationworklet/animator_definition.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/modules/animationworklet/animator_definition.h
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/modules/csspaint/css_paint_definition.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/modules/csspaint/css_paint_definition.h
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/modules/webaudio/audio_worklet_processor_definition.h
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/platform/bindings/callback_function_base.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/platform/bindings/callback_function_base.h
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/platform/bindings/callback_interface_base.cc
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/platform/bindings/callback_interface_base.h
[modify] https://crrev.com/90f4f9c38ab9dc07a07176da93a5d56e52e04979/third_party/blink/renderer/platform/bindings/trace_wrapper_v8_string.h

Project Member

Comment 19 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a398ea4fb1d4cb1b78bef5c8f1c663e049235a3e

commit a398ea4fb1d4cb1b78bef5c8f1c663e049235a3e
Author: Trent Apted <tapted@chromium.org>
Date: Fri May 25 06:18:15 2018

Revert "[wrapper-tracing] Add ScriptWrappableVisitor unit tests"

This reverts commit 6c352304174e122e28308f213b36d9eb96d594e1.

Reason for revert: suspected for webkit_unit_tests failing on Android CFI since

https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/1351

ScriptWrappableVisitorTest.InObjectUsingTraceWrapperMember

fails with

../../third_party/blink/renderer/core/testing/death_aware_script_wrappable.h:85:7: runtime error: control flow integrity check for type 'blink::(anonymous namespace)::InObjectContainer' failed during virtual call (vtable address 0xe0726938)
0xe0726938: note: vtable is of type 'blink::(anonymous namespace)::InObjectContainer'

Stack Trace:
  RELADDR   FUNCTION                                                                                                                                                                                                                                                                                                                                                                                                                                     FILE:LINE
   205e4f5  blink::DeathAwareScriptWrappable::TraceWrappers(blink::ScriptWrappableVisitor*) const   

Original change's description:
> [wrapper-tracing] Add ScriptWrappableVisitor unit tests
> 
> Add unit tests that make sure that visitor dispatch reaches the expected leafs.
> 
> Bug:  chromium:841830 
> Change-Id: I7dba068b66759312a41adfd0a2090af8b007e6fe
> Reviewed-on: https://chromium-review.googlesource.com/1072212
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561762}

TBR=haraken@chromium.org,mlippautz@chromium.org

Change-Id: I1728cfd29313c0f7dfbaeb41c9045d82fd193f89
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:841830 
Reviewed-on: https://chromium-review.googlesource.com/1072988
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561785}
[modify] https://crrev.com/a398ea4fb1d4cb1b78bef5c8f1c663e049235a3e/third_party/blink/renderer/bindings/bindings.gni
[delete] https://crrev.com/a4bfe5018c396854f74249422088c9fa84046dff/third_party/blink/renderer/bindings/core/v8/script_wrappable_visitor_test.cc
[modify] https://crrev.com/a398ea4fb1d4cb1b78bef5c8f1c663e049235a3e/third_party/blink/renderer/core/testing/death_aware_script_wrappable.h

Project Member

Comment 20 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0396620cbfb09b4ff8f827eb8b5ad8096262cbc2

commit 0396620cbfb09b4ff8f827eb8b5ad8096262cbc2
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Fri May 25 09:08:24 2018

Reland "[wrapper-tracing] Add ScriptWrappableVisitor unit tests"

Add unit tests that make sure that visitor dispatch reaches the expected leafs.

Reland:
- Avoid anon namespace in header file.

This reverts commit a398ea4fb1d4cb1b78bef5c8f1c663e049235a3e.

Bug:  chromium:841830 
Change-Id: I870d7f06baac17661a0d8bd16ee4ece78f8cdda6
Reviewed-on: https://chromium-review.googlesource.com/1073168
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561814}
[modify] https://crrev.com/0396620cbfb09b4ff8f827eb8b5ad8096262cbc2/third_party/blink/renderer/bindings/bindings.gni
[add] https://crrev.com/0396620cbfb09b4ff8f827eb8b5ad8096262cbc2/third_party/blink/renderer/bindings/core/v8/script_wrappable_visitor_test.cc
[modify] https://crrev.com/0396620cbfb09b4ff8f827eb8b5ad8096262cbc2/third_party/blink/renderer/core/testing/death_aware_script_wrappable.h

Project Member

Comment 21 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48c1e429898e65fb247d51679c806c81000c2e60

commit 48c1e429898e65fb247d51679c806c81000c2e60
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Fri May 25 11:20:43 2018

[oilpan] Convert manual wrapper tracing to Trace methods

Wrapper tracing uses TraceWrappersWithManualWriteBarrier when dealing
with raw pointers. These uses need to use TraceWithWrappers in an Oilpan
world as they would not be properly forwarded otherwise.

Bug:  chromium:841830 
Change-Id: I725d2fbc8a8ac1f8387e4efeae5b74f02a294ed7
Reviewed-on: https://chromium-review.googlesource.com/1073171
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561827}
[modify] https://crrev.com/48c1e429898e65fb247d51679c806c81000c2e60/third_party/blink/renderer/core/css/css_rule.cc
[modify] https://crrev.com/48c1e429898e65fb247d51679c806c81000c2e60/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/48c1e429898e65fb247d51679c806c81000c2e60/third_party/blink/renderer/core/dom/node.cc

Project Member

Comment 22 by bugdroid1@chromium.org, May 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76af5edea4d58e3b0580bf9cc1da9a3bb0f36b1b

commit 76af5edea4d58e3b0580bf9cc1da9a3bb0f36b1b
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Sun May 27 00:46:13 2018

[wrapper-tracing] Fix marking test

Bug:  chromium:841830 
Change-Id: I2eae53abc9c571c2cbf5ff39337a0b2088deb5eb
Reviewed-on: https://chromium-review.googlesource.com/1074767
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562135}
[modify] https://crrev.com/76af5edea4d58e3b0580bf9cc1da9a3bb0f36b1b/third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc

Description: Show this description
Description: Show this description
Project Member

Comment 25 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8a7216a351ff121d661f5fa87b1c0e79fbd3935

commit c8a7216a351ff121d661f5fa87b1c0e79fbd3935
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Mon May 28 09:47:27 2018

[wrapper-tracing] Dispatch through Trace instead of TraceWrappers

Dispatch through T::Trace instead of T::TraceWrappers for wrapper
tracing.

Bug:  chromium:841830 
Change-Id: Idacc09961d68a5ffedb66b4196097c9a79259c4b
Reviewed-on: https://chromium-review.googlesource.com/1071368
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562223}
[modify] https://crrev.com/c8a7216a351ff121d661f5fa87b1c0e79fbd3935/third_party/blink/renderer/bindings/core/v8/script_wrappable_visitor_test.cc
[modify] https://crrev.com/c8a7216a351ff121d661f5fa87b1c0e79fbd3935/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.cc
[modify] https://crrev.com/c8a7216a351ff121d661f5fa87b1c0e79fbd3935/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.h
[modify] https://crrev.com/c8a7216a351ff121d661f5fa87b1c0e79fbd3935/third_party/blink/renderer/core/dom/element_rare_data.h
[modify] https://crrev.com/c8a7216a351ff121d661f5fa87b1c0e79fbd3935/third_party/blink/renderer/core/dom/events/event_listener_map.h
[modify] https://crrev.com/c8a7216a351ff121d661f5fa87b1c0e79fbd3935/third_party/blink/renderer/platform/bindings/active_script_wrappable_base.cc
[modify] https://crrev.com/c8a7216a351ff121d661f5fa87b1c0e79fbd3935/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc
[modify] https://crrev.com/c8a7216a351ff121d661f5fa87b1c0e79fbd3935/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.h
[modify] https://crrev.com/c8a7216a351ff121d661f5fa87b1c0e79fbd3935/third_party/blink/renderer/platform/bindings/script_wrappable_visitor.h
[modify] https://crrev.com/c8a7216a351ff121d661f5fa87b1c0e79fbd3935/third_party/blink/renderer/platform/bindings/script_wrappable_visitor_verifier.h
[modify] https://crrev.com/c8a7216a351ff121d661f5fa87b1c0e79fbd3935/third_party/blink/renderer/platform/heap/trace_traits.h

Blockedon: 847284
Project Member

Comment 27 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/213626dae8591c0126dea31c4b27f9706620a499

commit 213626dae8591c0126dea31c4b27f9706620a499
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 03:23:53 2018

[wrapper-tracing] Update reference documentation

Drive-by: Switch to style where each sentence starts on a new line.

No-try: true
Bug:  chromium:841830 
Change-Id: I822199a8dcaffe449e37cd4bed30d2a092b46419
Reviewed-on: https://chromium-review.googlesource.com/1074775
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562323}
[modify] https://crrev.com/213626dae8591c0126dea31c4b27f9706620a499/third_party/blink/renderer/platform/bindings/TraceWrapperReference.md

Project Member

Comment 28 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3

commit 7ec34252d0c95897b2f2f1c92216639b4cd0ebe3
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 05:01:05 2018

[wrapper-tracing] Remove TraceWrappers from core/svg/

Binary size improvement: -288B

Bug:  chromium:841830 ,  chromium:847284 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iedc9e6b1a3bc61aff0bb773fe2fdfc46cdece5d8
Reviewed-on: https://chromium-review.googlesource.com/1075834
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562339}
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/properties/svg_animated_property.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/properties/svg_list_property_tear_off_helper.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/properties/svg_property_tear_off.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_angle.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_angle.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_boolean.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_enumeration_base.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_integer.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_integer.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_length.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_length.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_length_list.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_number.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_number.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_number_list.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_preserve_aspect_ratio.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_rect.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_string.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_string.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_transform_list.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_matrix_tear_off.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_matrix_tear_off.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_script_element.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_script_element.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/platform/bindings/trace_wrapper_base.h

Project Member

Comment 29 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa42974329a179b1986dab4dddc398902f8ef9ba

commit fa42974329a179b1986dab4dddc398902f8ef9ba
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 06:44:09 2018

[wrapper-tracing] Remove TraceWrappers from core/html/

Binary size improvement: -4KiB

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: Ic59ceccaed0f9a9bd2151ea530b7f8eb8bc505f2
Reviewed-on: https://chromium-review.googlesource.com/1075871
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562353}
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/custom/custom_element_definition.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/custom/custom_element_reaction_stack.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/custom/custom_element_reaction_stack.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/custom/custom_element_registry.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/custom/custom_element_registry.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_anchor_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_link_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_link_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_script_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_script_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_template_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_template_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/imports/html_import_tree_root.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/imports/html_import_tree_root.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/imports/html_imports_controller.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/imports/html_imports_controller.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/parser/html_document_parser.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/parser/html_document_parser.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track_cue_list.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track_cue_list.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track_list.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track_list.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/track_list_base.h

Project Member

Comment 30 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf1785109d0dd93694aa33182eda78b18aec77f6

commit bf1785109d0dd93694aa33182eda78b18aec77f6
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 07:44:49 2018

[wrapper-tracing] Remove TraceWrappers from core/css/

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: I9cb741229dd486713834bc2e6e27f3ed88903d89
Reviewed-on: https://chromium-review.googlesource.com/1075882
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562363}
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/css_rule.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/css_rule.h
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/css_style_sheet.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/css_style_sheet.h
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/font_face_set_document.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/font_face_set_document.h
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_engine.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_engine.h
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_rule_css_style_declaration.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_rule_css_style_declaration.h
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_sheet_collection.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_sheet_collection.h

Project Member

Comment 31 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/274beea116d9822b81f94c1113569e9515ee3c52

commit 274beea116d9822b81f94c1113569e9515ee3c52
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 08:01:31 2018

[wrapper-tracing] Remove TraceWrappers from modules/

Binary size improvement: -4KiB

Bug:  chromium:841830 ,  chromium:847284 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8aebe5179f5710a284ddc4631446a2e3cdbe8786
Reviewed-on: https://chromium-review.googlesource.com/1075868
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562365}
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animator.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animator.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animator_definition.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animator_definition.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/csspaint/css_paint_definition.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/csspaint/css_paint_definition.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/filesystem/local_file_system.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/filesystem/local_file_system.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geo_notifier.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geo_notifier.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geolocation.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geolocation.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geolocation_watchers.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geolocation_watchers.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/navigator_geolocation.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/navigator_geolocation.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/idb_observer.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/idb_observer.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/indexed_db_client.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/indexed_db_client.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/locks/lock_manager.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/locks/lock_manager.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/locks/navigator_locks.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/mediasession/media_session.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/mediasession/media_session.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/nfc/navigator_nfc.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/nfc/navigator_nfc.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/nfc/nfc.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/nfc/nfc.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/remoteplayback/availability_callback_wrapper.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/remoteplayback/availability_callback_wrapper.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/remoteplayback/remote_playback.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/remoteplayback/remote_playback.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/serviceworkers/service_worker_container_client.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/vr/vr_display.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/vr/vr_display.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webaudio/audio_worklet_processor_definition.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webaudio/audio_worklet_processor_definition.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_context_group.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_context_group.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_context_object.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_context_object.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_framebuffer.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_framebuffer.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_program.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_program.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_shared_object.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_shared_object.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_transform_feedback.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_transform_feedback.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_vertex_array_object_base.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_vertex_array_object_base.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webmidi/midi_port.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webmidi/midi_port.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_canvas_input_provider.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_canvas_input_provider.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_frame_request_callback_collection.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_frame_request_callback_collection.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_session.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_session.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_webgl_layer.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_webgl_layer.h

Project Member

Comment 32 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b7b0f5f0082df7cd0957f920660ac3266bd431b

commit 3b7b0f5f0082df7cd0957f920660ac3266bd431b
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 09:29:40 2018

[wrapper-tracing] Remove TraceWrappers from core/dom/

Binary size improvement: -4KiB

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: Ic0b4e1ddd8e4104973c45d634b6c37a2db880bcc
Reviewed-on: https://chromium-review.googlesource.com/1075911
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562377}
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-merged-nodes-expected.txt
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-with-event-listener-expected.txt
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-with-multiple-retainers-expected.txt
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/attr.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/attr.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/container_node.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/container_node.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/document_parser.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/element_rare_data.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/element_rare_data.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/custom_event.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/custom_event.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/event_listener.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/event_listener_map.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/event_listener_map.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/event_target.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/event_target.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/frame_request_callback_collection.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/frame_request_callback_collection.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/mutation_observer.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/mutation_observer.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/mutation_observer_registration.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/mutation_observer_registration.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/mutation_record.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_iterator.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_iterator.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_iterator_base.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_iterator_base.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_lists_node_data.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_lists_node_data.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_rare_data.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_rare_data.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/scripted_animation_controller.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/scripted_animation_controller.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/scripted_idle_task_controller.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/scripted_idle_task_controller.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/shadow_root.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/shadow_root.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/shadow_root_v0.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/static_node_list.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/tree_walker.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/tree_walker.h

Project Member

Comment 33 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865

commit ba8c3904ecbe2a2b50f6a9c53f0ea97498460865
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 11:45:30 2018

[wrapper-tracing] Remove TraceWrappers from core/{events,frame,script}/

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: I6d10de185826f6147a4477ac95891e0ae62315dd
Reviewed-on: https://chromium-review.googlesource.com/1075954
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562388}
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/error_event.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/error_event.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/pop_state_event.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/pop_state_event.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/promise_rejection_event.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/promise_rejection_event.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/registered_event_listener.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/dom_window.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/dom_window.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/local_dom_window.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/navigator.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/navigator.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/html_parser_script_runner.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/html_parser_script_runner.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/modulator.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/modulator_impl_base.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_map.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_map.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_pending_script.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_pending_script.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_script.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_script.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/script_loader.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/script_runner.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/script_runner.h

Project Member

Comment 34 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5474d2f467e8eca77930f52e8bfe4505a9e01431

commit 5474d2f467e8eca77930f52e8bfe4505a9e01431
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 14:40:32 2018

[wrapper-tracing] Remove TraceWrappers leftovers from core/

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: Id3d317c2ce8d3d001aa96fc747b69372d85132d3
Reviewed-on: https://chromium-review.googlesource.com/1075958
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562421}
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/element_intersection_observer_data.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/element_intersection_observer_data.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/intersection_observer.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/intersection_observer.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/intersection_observer_delegate.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/layout/custom/css_layout_definition.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/mojo/mojo_watcher.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/mojo/mojo_watcher.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/resize_observer/resize_observer.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/resize_observer/resize_observer.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/testing/death_aware_script_wrappable.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/dom_window_performance.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/dom_window_performance.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance_mark.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance_mark.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance_observer.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance_observer.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/window_performance.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/worker_global_scope_performance.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/worker_global_scope_performance.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_animation_frame_provider.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_global_scope.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_navigator.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_navigator.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worklet_global_scope.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worklet_global_scope.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h

Project Member

Comment 35 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d

commit b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 14:51:25 2018

[wrapper-tracing] Remove TraceWrappers from bindings/

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: I175b8401dac02efbb93b332a6e916195ab099cb1
Reviewed-on: https://chromium-review.googlesource.com/1075960
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562423}
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.h
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/v8_abstract_event_listener.cc
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/v8_abstract_event_listener.h
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/v8_intersection_observer_delegate.cc
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/v8_intersection_observer_delegate.h

Project Member

Comment 36 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61c4b64e531cb4ed1408029767488c2810733c1e

commit 61c4b64e531cb4ed1408029767488c2810733c1e
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Wed May 30 03:00:14 2018

[wrapper-tracing] Remove TraceWrappers from platform/{bindings,heap}/

Removes TraceWrappers handling from platform code as all uses now dispatch
through T::Trace.

Binary size improvement: -38KiB

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: Iec82306835828cd8cba7569d8afe33e09250d419
Reviewed-on: https://chromium-review.googlesource.com/1077112
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562709}
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/bindings/core/v8/script_wrappable_visitor_test.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/core/dom/frame_request_callback_collection.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/callback_function_base.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/callback_function_base.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/callback_interface_base.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/callback_interface_base.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/dom_data_store.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/dom_wrapper_world.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/dom_wrapper_world.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.h
[delete] https://crrev.com/10cc9570a11e9428b1db8c9acf9108a8198f143e/third_party/blink/renderer/platform/bindings/script_wrappable_visitor.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable_visitor.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable_visitor_verifier.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/trace_wrapper_base.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/trace_wrapper_member.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/trace_wrapper_v8_reference.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/trace_wrapper_v8_string.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/blink_gc.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/garbage_collected.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/incremental_marking_test.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/marking_verifier.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/marking_visitor.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/trace_traits.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/visitor.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/supplementable.h

Owner: mlippautz@chromium.org
Status: Fixed (was: Available)
This one is fixed. Any new work in that area should get its own tracking bug.
Project Member

Comment 38 by bugdroid1@chromium.org, Jul 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf7893388e2900e0a7bd0feb0139e55f99e3da45

commit bf7893388e2900e0a7bd0feb0139e55f99e3da45
Author: Victor Costan <pwnall@chromium.org>
Date: Sat Jul 07 20:25:00 2018

Blink GC: Remove GC_PLUGIN_IGNORE from TraceWrapperBase.

This CL moves GeolocationWatchers XRFrameRequestCallbackCollection to
the Oilpan heap, per the blink-gc warnings.

Bug:  841830 
Change-Id: Iaa883e485b9d7e0d3b577afa28fb8c2414f7162b
Reviewed-on: https://chromium-review.googlesource.com/1127842
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573174}
[modify] https://crrev.com/bf7893388e2900e0a7bd0feb0139e55f99e3da45/third_party/blink/renderer/modules/geolocation/geolocation.cc
[modify] https://crrev.com/bf7893388e2900e0a7bd0feb0139e55f99e3da45/third_party/blink/renderer/modules/geolocation/geolocation.h
[modify] https://crrev.com/bf7893388e2900e0a7bd0feb0139e55f99e3da45/third_party/blink/renderer/modules/geolocation/geolocation_watchers.h
[modify] https://crrev.com/bf7893388e2900e0a7bd0feb0139e55f99e3da45/third_party/blink/renderer/modules/xr/xr_frame_request_callback_collection.h
[modify] https://crrev.com/bf7893388e2900e0a7bd0feb0139e55f99e3da45/third_party/blink/renderer/modules/xr/xr_session.cc
[modify] https://crrev.com/bf7893388e2900e0a7bd0feb0139e55f99e3da45/third_party/blink/renderer/modules/xr/xr_session.h
[modify] https://crrev.com/bf7893388e2900e0a7bd0feb0139e55f99e3da45/third_party/blink/renderer/platform/bindings/trace_wrapper_base.h

Sign in to add a comment