Fix webRequest auth events with network service |
|||
Issue descriptionThere's a flaky test which is disabled for this: ExtensionWebRequestApiTest.DISABLED_WebRequestAuthRequired There's also a websockets test ExtensionWebRequestApiTest.WebSocketRequestAuthRequired
,
May 14 2018
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06a3103dbafdf0e088e8c8c947fc4da35eff163f commit 06a3103dbafdf0e088e8c8c947fc4da35eff163f Author: Jun Cai <juncai@chromium.org> Date: Wed May 16 00:39:29 2018 Network Service: Recategorize some webRequest auth events related browser tests This CL moves two webRequest auth events related browser tests to a new category. Bug: 841827 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I09d64ad7aef47c5388151b7e7ae50b0db382cfb1 Reviewed-on: https://chromium-review.googlesource.com/1060306 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#558901} [modify] https://crrev.com/06a3103dbafdf0e088e8c8c947fc4da35eff163f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74b988896f3e2411fcc1e3c079764ca1fec245b0 commit 74b988896f3e2411fcc1e3c079764ca1fec245b0 Author: Ken Rockot <rockot@chromium.org> Date: Tue May 29 19:30:25 2018 Re-enable WebRequestAuthRequired test. ExtensionWebRequestApiTest.WebRequestAuthRequired has been disabled forever. It was originally disabled for flakiness, but neither the flaky crashes nor the code which was crashing appear to exist anymore. This CL makes some minor updates to the test expectations and re-enables the test. Bug: 140976, 841827 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I97879b51e600cff684defcbef37fcfbae3dfda62 Reviewed-on: https://chromium-review.googlesource.com/1076683 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#562546} [modify] https://crrev.com/74b988896f3e2411fcc1e3c079764ca1fec245b0/chrome/browser/extensions/api/web_request/web_request_apitest.cc [modify] https://crrev.com/74b988896f3e2411fcc1e3c079764ca1fec245b0/chrome/test/data/extensions/api_test/webrequest/test_auth_required.js [modify] https://crrev.com/74b988896f3e2411fcc1e3c079764ca1fec245b0/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4dd430bc5c6f5e9ee2346845e73264a53f01987 commit f4dd430bc5c6f5e9ee2346845e73264a53f01987 Author: Thiemo Nagel <tnagel@chromium.org> Date: Wed May 30 09:29:31 2018 Revert "Re-enable WebRequestAuthRequired test." This reverts commit 74b988896f3e2411fcc1e3c079764ca1fec245b0. Reason for revert: Flaking on Linux ChromiumOS MSan Tests https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7361 https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7363 https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7364 [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired [14149:14149:0529/223016.256914:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [14149:14299:0529/223016.655436:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [14149:14299:0529/223016.656150:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [14149:14149:0529/223023.245267:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() [14149:14372:0529/223023.626405:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico [14149:14149:0529/223024.849020:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223027.955574:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223031.378924:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223034.498789:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223216.859287:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) BrowserTestBase received signal: Terminated. Backtrace: #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 #4 0x7fe3e82dacb0 in killpg ??:? #5 0x7fe3e82dacb0 in ?? ??:0 #6 0x7fe3e83a26d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #44 0x7fe3e82c5f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 #45 0x000000a511ba in _start ??:0:0 Original change's description: > Re-enable WebRequestAuthRequired test. > > ExtensionWebRequestApiTest.WebRequestAuthRequired has been disabled > forever. It was originally disabled for flakiness, but neither the > flaky crashes nor the code which was crashing appear to exist anymore. > > This CL makes some minor updates to the test expectations and re-enables > the test. > > Bug: 140976, 841827 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I97879b51e600cff684defcbef37fcfbae3dfda62 > Reviewed-on: https://chromium-review.googlesource.com/1076683 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562546} TBR=rockot@chromium.org,karandeepb@chromium.org Change-Id: I31e6774d763450d791f05397214a355e77419e44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 140976, 841827 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1078487 Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#562773} [modify] https://crrev.com/f4dd430bc5c6f5e9ee2346845e73264a53f01987/chrome/browser/extensions/api/web_request/web_request_apitest.cc [modify] https://crrev.com/f4dd430bc5c6f5e9ee2346845e73264a53f01987/chrome/test/data/extensions/api_test/webrequest/test_auth_required.js [modify] https://crrev.com/f4dd430bc5c6f5e9ee2346845e73264a53f01987/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb commit 5f734e3228cd68c306c7870cfd4e8ae9a56e41cb Author: Ken Rockot <rockot@chromium.org> Date: Wed Jun 13 01:41:03 2018 Auth interception for WebRequest + NetworkService Enables the onAuthRequired WebRequest event to fire (and potentially block) as expected when the Network Service is enabled. Bug: 841827 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia8d13bf8465438dee780de36f6b34bcdc681f1a7 Reviewed-on: https://chromium-review.googlesource.com/1081659 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#566678} [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/android_webview/browser/aw_content_browser_client.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/android_webview/browser/aw_content_browser_client.h [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/chrome/browser/ui/login/login_handler.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/chrome/browser/ui/login/login_handler.h [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/chrome/test/data/extensions/api_test/webrequest/test_auth_required.js [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/content/browser/loader/navigation_url_loader_impl.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/content/browser/network_service_client.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/content/browser/network_service_client.h [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/content/public/browser/content_browser_client.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/content/public/browser/content_browser_client.h [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/content/shell/browser/layout_test/layout_test_content_browser_client.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/content/shell/browser/layout_test/layout_test_content_browser_client.h [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/content/shell/browser/shell_content_browser_client.h [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/extensions/browser/api/web_request/web_request_api.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/extensions/browser/api/web_request/web_request_api.h [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/services/network/network_service_unittest.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/services/network/public/mojom/network_service.mojom [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/services/network/url_loader.cc [modify] https://crrev.com/5f734e3228cd68c306c7870cfd4e8ae9a56e41cb/services/network/url_loader_unittest.cc
,
Jun 14 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by yhirano@chromium.org
, May 11 2018