New issue
Advanced search Search tips

Issue 841824 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Display User-Selected PPD in Edit Printer Dialog

Project Member Reported by valleau@chromium.org, May 10 2018

Issue description

If a printer is added with a user-selected PPD file, then the edit printer dialog should indicate to the user the PPD file which is currently in use.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f8257d2ccaf72d1d3063a0d4d7871e0b1b7859

commit 90f8257d2ccaf72d1d3063a0d4d7871e0b1b7859
Author: David Valleau <valleau@chromium.org>
Date: Tue May 15 02:32:20 2018

Display User-Selected PPDs in Edit Printer Dialog

BUG= chromium:841824 
R=skau@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I35fb1f1366449ac68639d30ce04aeb2105c498cc
Reviewed-on: https://chromium-review.googlesource.com/1054692
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558591}
[modify] https://crrev.com/90f8257d2ccaf72d1d3063a0d4d7871e0b1b7859/chrome/app/settings_strings.grdp
[modify] https://crrev.com/90f8257d2ccaf72d1d3063a0d4d7871e0b1b7859/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html
[modify] https://crrev.com/90f8257d2ccaf72d1d3063a0d4d7871e0b1b7859/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.js
[modify] https://crrev.com/90f8257d2ccaf72d1d3063a0d4d7871e0b1b7859/chrome/browser/resources/settings/printing_page/cups_set_manufacturer_model_behavior.js
[modify] https://crrev.com/90f8257d2ccaf72d1d3063a0d4d7871e0b1b7859/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/90f8257d2ccaf72d1d3063a0d4d7871e0b1b7859/chromeos/printing/printer_translator.cc

Comment 2 by skau@chromium.org, May 16 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/530301071c4ddbb28e5a7b1a6a35f199e55e84dd

commit 530301071c4ddbb28e5a7b1a6a35f199e55e84dd
Author: David Valleau <valleau@chromium.org>
Date: Thu May 17 16:22:09 2018

Fixing add printer dialog to display user selected PPD

The add printer dialog was not displaying the PPD selected by the user
due to some changes made to the edit printer dialog. This change fixes
this issue.

R=michaelpg@chromium.org

Bug:  841824 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7d1a0f69263e73ccfe1b8abbdb45ea32e8b8f094
Reviewed-on: https://chromium-review.googlesource.com/1063107
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559558}
[modify] https://crrev.com/530301071c4ddbb28e5a7b1a6a35f199e55e84dd/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Status: Fixed (was: Started)

Sign in to add a comment