Issue metadata
Sign in to add a comment
|
MacViews: Bookmark bar tab order is wrong |
||||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3425.0 OS: macOS What steps will reproduce the problem? (1) #views-browser-windows (2) Show bookmark bar (3) Have apps installed (4) Tab into the bookmark bar (may require some extra tabbing until https://chromium-review.googlesource.com/c/chromium/src/+/1052854 makes it into a Canary build) What is the expected result? The items in the bookmark bar are tabbed through left to right (so Apps button, bookmark buttons, chevron, "Other Bookmarks") What happens instead? Apps button is tabbed to last (after "Other bookmarks") Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
May 10 2018
,
Jun 11 2018
,
Jun 12 2018
I'm actually going to grab this since it'll get fixed in the process of fixing issue 712248 (and is less trivial than it seems for Reasons)
,
Jun 22 2018
,
Jul 2
,
Jul 12
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c749d1a7c1b700d60797bea7f7d22830aef7ccce commit c749d1a7c1b700d60797bea7f7d22830aef7ccce Author: Leonard Grey <lgrey@chromium.org> Date: Fri Aug 17 17:50:32 2018 Track bookmark bar buttons independently of the parent's hierarchy Currently, the bookmark bar uses the view hierarchy as its "model": bookmark buttons are force ordered to the child view index that matches their order in the model node (so that child_at(i) is the ith button), and GetBookmarkButtonCount() is implemented as: `return child_count() - 6;` This is fragile, and less than ideal for keyboard traversal. This change tracks the buttons separately in a vector, and maintains proper focus traversal. This is setup for Cocoa-style button dragging (as well as a fix for issue 841785 ). Bug: 712248, 841785 Change-Id: I236e34503d021ff0f27974f731f6abcb4d62f829 Reviewed-on: https://chromium-review.googlesource.com/1177908 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584117} [modify] https://crrev.com/c749d1a7c1b700d60797bea7f7d22830aef7ccce/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/c749d1a7c1b700d60797bea7f7d22830aef7ccce/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h [modify] https://crrev.com/c749d1a7c1b700d60797bea7f7d22830aef7ccce/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test_helper.h [modify] https://crrev.com/c749d1a7c1b700d60797bea7f7d22830aef7ccce/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
,
Aug 28
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by spqc...@chromium.org
, May 10 2018