New issue
Advanced search Search tips

Issue 841781 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews: Command-click on a bookmark folder should open all

Project Member Reported by lgrey@chromium.org, May 10 2018

Issue description

68.0.3425.0 Mac

1) #views-browser-windows 
2) Show bookmark bar
3) Have a bookmark bar folder with multiple items in it
4) Command+click

Expected: All bookmarks in the folder open (or if there are many items, a confirmation dialogue is shown)
Actual: Folder opens
 
Owner: weili@chromium.org
Status: Assigned (was: Untriaged)
[mac bug triage] Assigning to weili@ to have a look

Comment 2 by weili@chromium.org, May 17 2018

 Issue 840491  has been merged into this issue.

Comment 3 by weili@chromium.org, May 17 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1

commit 7b400d427204a1c6ac816ce361b9ea2a5d8d65e1
Author: Wei Li <weili@chromium.org>
Date: Mon Jun 04 22:06:19 2018

Cmd/Ctrl+Click on a bookmark folder to open all

Click with Command on Mac, or click with control on other platforms, on
a bookmark folder should open all the bookmarks in new background tabs.
This CL adds such action.

In order to test such action, this CL also modified ui controls across
platforms to be able to handle modifier keys for mouse events. The test
added would work across platforms.

BUG= 170072 , 841781 

Change-Id: Idbe1160d7f13f8cec003f086d948252b612276ed
Reviewed-on: https://chromium-review.googlesource.com/1068253
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564258}
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ash/test/ui_controls_factory_ash.cc
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/chrome/test/BUILD.gn
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/chrome/test/base/interactive_test_utils.cc
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/chrome/test/base/interactive_test_utils.h
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/chrome/test/base/interactive_test_utils_cocoa.mm
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/chrome/test/base/interactive_test_utils_common_views.cc
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ui/aura/test/ui_controls_factory_aurawin.cc
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ui/aura/test/ui_controls_factory_aurax11.cc
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ui/aura/test/ui_controls_factory_ozone.cc
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ui/base/test/ui_controls.h
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ui/base/test/ui_controls_aura.cc
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ui/base/test/ui_controls_aura.h
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ui/base/test/ui_controls_internal_win.cc
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ui/base/test/ui_controls_internal_win.h
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ui/base/test/ui_controls_mac.mm
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ui/base/test/ui_controls_win.cc
[modify] https://crrev.com/7b400d427204a1c6ac816ce361b9ea2a5d8d65e1/ui/views/test/ui_controls_factory_desktop_aurax11.cc

Comment 5 by weili@chromium.org, Jun 4 2018

Status: Fixed (was: Started)

Sign in to add a comment