New issue
Advanced search Search tips

Issue 841777 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move buildbucket hostname to service config

Project Member Reported by no...@chromium.org, May 10 2018

Issue description

Introduce service-level LUCI scheduler config that defines buildbucket hostname.
Remove buildbucket hostname from project-level configs.
 
meh, shouldn't skylark-based generation of configs paper over repetitive nature of config?

Comment 2 by no...@chromium.org, May 10 2018

it is not only about repetition. Project-level configs is our API and we are requiring users to specify the buildbucket hostname, like there may me multiple different buildbucket hosts for a given LUCI deployment.

My motivation to file this bug was to reduce attack surface (scheduler schedules builds  in different buckets / projects/ buildbucket servers). The context was go/luci-buckets. However, after that I've realized that other instances of buildbucket wouldn't allow a different luci-scheduler to schedule builds.

Comment 3 by mar...@chromium.org, May 21 2018

Status: Available (was: Untriaged)
By buildbucket hostname, you mean the appengine hostname?

Comment 4 by no...@chromium.org, May 22 2018

I mean what’s being specified now, “cr-buildbucket.appspot.com

Sign in to add a comment