Some features are using the old style of experiment checking (FieldTrialList). We should migrate to base::Feature.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c23a1158bb403e301b13e354218257eed055003 commit 6c23a1158bb403e301b13e354218257eed055003 Author: Mathieu Perreault <mathp@chromium.org> Date: Fri May 11 18:08:05 2018 [Autofill] Modernize how we check for credit card upload enablement Change from checking the group name, to base::Feature Bug: 841772 Test: AutofillExperimentsTest Change-Id: I576c309e82f5275ec4367116612fb8c8d5ebf06b Reviewed-on: https://chromium-review.googlesource.com/1053756 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#557938} [modify] https://crrev.com/6c23a1158bb403e301b13e354218257eed055003/chrome/browser/about_flags.cc [modify] https://crrev.com/6c23a1158bb403e301b13e354218257eed055003/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/6c23a1158bb403e301b13e354218257eed055003/components/autofill/core/browser/autofill_experiments.h [modify] https://crrev.com/6c23a1158bb403e301b13e354218257eed055003/components/autofill/core/browser/autofill_experiments_unittest.cc [modify] https://crrev.com/6c23a1158bb403e301b13e354218257eed055003/components/autofill/core/common/autofill_switches.cc [modify] https://crrev.com/6c23a1158bb403e301b13e354218257eed055003/components/autofill/core/common/autofill_switches.h [modify] https://crrev.com/6c23a1158bb403e301b13e354218257eed055003/testing/variations/fieldtrial_testing_config.json [modify] https://crrev.com/6c23a1158bb403e301b13e354218257eed055003/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/431e0fc33ecbee34cbf43e676b1083cb2502ea23 commit 431e0fc33ecbee34cbf43e676b1083cb2502ea23 Author: Mathieu Perreault <mathp@chromium.org> Date: Wed May 16 14:32:59 2018 [Autofill] Remove touch bar autofill feature, which is launched now Cleaning up a Feature which has been launched for some time now. Bug: 841772 Test: existing Change-Id: I1edd1bf91d31f89021530f0b70adafb6081e17e2 Reviewed-on: https://chromium-review.googlesource.com/1061477 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#559082} [modify] https://crrev.com/431e0fc33ecbee34cbf43e676b1083cb2502ea23/chrome/browser/about_flags.cc [modify] https://crrev.com/431e0fc33ecbee34cbf43e676b1083cb2502ea23/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/431e0fc33ecbee34cbf43e676b1083cb2502ea23/chrome/browser/flag_descriptions.h [modify] https://crrev.com/431e0fc33ecbee34cbf43e676b1083cb2502ea23/chrome/browser/ui/autofill/autofill_popup_controller_impl_mac.mm [modify] https://crrev.com/431e0fc33ecbee34cbf43e676b1083cb2502ea23/chrome/browser/ui/cocoa/autofill/credit_card_autofill_touch_bar_controller.mm [modify] https://crrev.com/431e0fc33ecbee34cbf43e676b1083cb2502ea23/chrome/browser/ui/cocoa/autofill/credit_card_autofill_touch_bar_controller_unittest.mm [modify] https://crrev.com/431e0fc33ecbee34cbf43e676b1083cb2502ea23/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/431e0fc33ecbee34cbf43e676b1083cb2502ea23/components/autofill/core/browser/autofill_experiments.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87dfd770d144843eaddeab27693c137e83ece4a6 commit 87dfd770d144843eaddeab27693c137e83ece4a6 Author: Jared Saul <jsaul@google.com> Date: Fri May 18 21:28:32 2018 Fold AutofillUpstream waterfall testing config study into existing OfferUploadCreditCards study Bug: 841772 Change-Id: I6edff494d1c48f226bc4cffd9fab0049408ecc4b Reviewed-on: https://chromium-review.googlesource.com/1066559 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#560048} [modify] https://crrev.com/87dfd770d144843eaddeab27693c137e83ece4a6/testing/variations/fieldtrial_testing_config.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2945060c369411b144d28db5091a692be62be7a commit a2945060c369411b144d28db5091a692be62be7a Author: Mathieu Perreault <mathp@google.com> Date: Fri May 25 17:00:38 2018 [Autofill] Cleaning up some unlaunched experiments in Autofill dropdown Removing support for various experiments, except the feature code for |isIconAtStart| on Android, which may be useful in the future and used by other features reusing the dropdown. Bug: 841772 Test: visual Change-Id: I5a73b706ec30652348957a84ea6e095e493f006a Reviewed-on: https://chromium-review.googlesource.com/1061582 Reviewed-by: Tao Bai <michaelbai@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#561917} [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/chrome/browser/about_flags.cc [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/chrome/browser/flag_descriptions.h [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/chrome/browser/ui/autofill/autofill_popup_layout_model.h [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/components/autofill/android/java/src/org/chromium/components/autofill/AutofillPopup.java [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/components/autofill/core/browser/autofill_experiments.h [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java [modify] https://crrev.com/a2945060c369411b144d28db5091a692be62be7a/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8afe7b3a327d279544591b5b846a4302ddc73f35 commit 8afe7b3a327d279544591b5b846a4302ddc73f35 Author: Mathieu Perreault <mathp@google.com> Date: Tue May 29 21:41:41 2018 [Autofill] Remove unused Autofill dropdown feature on Android The HTTP-not-secure warning was removed, so removing the supporting code for some of its visual changes (one-line support, bigger text, etc.) Bug: 841772 Change-Id: I7f01bbd9fdcdf3d75b8b4f7c0a46c318cc4c884c Reviewed-on: https://chromium-review.googlesource.com/1075510 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#562603} [modify] https://crrev.com/8afe7b3a327d279544591b5b846a4302ddc73f35/components/autofill/android/java/res/values/colors.xml [modify] https://crrev.com/8afe7b3a327d279544591b5b846a4302ddc73f35/components/autofill/android/java/res/values/dimens.xml [modify] https://crrev.com/8afe7b3a327d279544591b5b846a4302ddc73f35/components/autofill/android/java/src/org/chromium/components/autofill/AutofillSuggestion.java [modify] https://crrev.com/8afe7b3a327d279544591b5b846a4302ddc73f35/ui/android/java/src/org/chromium/ui/DropdownAdapter.java [modify] https://crrev.com/8afe7b3a327d279544591b5b846a4302ddc73f35/ui/android/java/src/org/chromium/ui/DropdownItem.java [modify] https://crrev.com/8afe7b3a327d279544591b5b846a4302ddc73f35/ui/android/java/src/org/chromium/ui/DropdownItemBase.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77426482b3a48563a7a7f4990d44bbd4849e08e6 commit 77426482b3a48563a7a7f4990d44bbd4849e08e6 Author: Mathieu Perreault <mathp@chromium.org> Date: Fri Jun 22 16:06:17 2018 [Autofill] Remove some fieldtrial configs that no longer exist. Bug: 841772 Change-Id: I9b311730c66e3d6ad99e0db5c908425957becaa3 Reviewed-on: https://chromium-review.googlesource.com/1111906 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#569644} [modify] https://crrev.com/77426482b3a48563a7a7f4990d44bbd4849e08e6/testing/variations/fieldtrial_testing_config.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36b2de306fa5e2c93cecd4d3883a372c13f5fd39 commit 36b2de306fa5e2c93cecd4d3883a372c13f5fd39 Author: sebsg <sebsg@chromium.org> Date: Tue Jul 10 21:37:46 2018 [AF] Remove unused autofill suggestion limit field trial. Bug: 841772 Change-Id: I776e01a71231f4fe54fb25a698af0fc74bc95041 Reviewed-on: https://chromium-review.googlesource.com/1129368 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#573920} [modify] https://crrev.com/36b2de306fa5e2c93cecd4d3883a372c13f5fd39/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/36b2de306fa5e2c93cecd4d3883a372c13f5fd39/components/autofill/core/browser/personal_data_manager_unittest.cc [modify] https://crrev.com/36b2de306fa5e2c93cecd4d3883a372c13f5fd39/testing/variations/fieldtrial_testing_config.json
Over to Seb to carry the baton
Comment 1 by bugdroid1@chromium.org
, May 11 2018