New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841766 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Autofill] placeholder vs. value disambiguation.

Project Member Reported by parastoog@chromium.org, May 10 2018

Issue description

Sometimes the website puts a value on the field by running a JS. The entered value is practically a placeholder, but is detected as a value entered by the user. Therefore the autofill will not fill the field.

Example:

www.kohls.com
 

Comment 1 by se...@chromium.org, May 29 2018

Cc: est...@chromium.org ranjitkan@chromium.org thestig@chromium.org tkonch...@chromium.org zkoch@chromium.org smokana@chromium.org
 Issue 542835  has been merged into this issue.
Cc: parastoog@chromium.org
 Issue 802082  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308

commit 2dcd14f9e24eb3ab725b27abce9aa1ee84e96308
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Fri Jun 01 17:08:39 2018

[Autofill] Placeholder vs. Value Disambiguation.

Problem:
Sometimes the website puts a value on the field by running a JS.
The entered value is practically a placeholder, but is detected as a
value entered by the user. Therefore the autofill will not fill the
field. Another case is where the website prefills the form by the
data from the previous form.

Solution:
On the renderer side, when deciding to autofill or not, only consider
the values entered by the user.

When moving on the autofill dropdown, we'll move from Preview to
Clear Suggested Value. Previously, we would rely on value checking
for clearing a suggested value. Now that we only consider the
values entered by the renderer, we need to distinguish between a
previewed field and an autofilled one. We should only clear the
previewed fields.)

Fixes: www.kohls.com, rakuten.com, oup.com (Prefilled State),
www.shopdisney.com (for clearing)

Bug:  841766 ,  841314 , 841346
Change-Id: If9d8bd4e25982de57ae7d8ec26cb530dce311c7c
Reviewed-on: https://chromium-review.googlesource.com/1069226
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563690}
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/chrome/browser/about_flags.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/components/autofill/content/renderer/autofill_agent.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/components/autofill/content/renderer/autofill_agent.h
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/components/autofill/content/renderer/form_autofill_util.h
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/components/autofill/content/renderer/form_cache.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/components/autofill/content/renderer/password_autofill_agent.h
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/public/BUILD.gn
[add] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/public/web/web_autofill_state.h
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/public/web/web_form_control_element.h
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/renderer/core/exported/web_form_control_element.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/renderer/core/html/forms/html_form_control_element.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/renderer/core/html/forms/html_form_control_element.h
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/renderer/core/html/forms/html_input_element.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/renderer/core/html/forms/html_select_element.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/renderer/core/html/forms/html_text_area_element.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/renderer/core/html/forms/text_control_element.h
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/renderer/core/html/forms/text_control_inner_elements.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/2dcd14f9e24eb3ab725b27abce9aa1ee84e96308/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment