New issue
Advanced search Search tips

Issue 841759 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: May 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Dynamic Forms fix for forms without a name.

Project Member Reported by se...@chromium.org, May 10 2018 
We are using the form name when checking whether to trigger a refill.

However some forms have no name. Also, all synthetic forms have no name.

As a fallback, check the name for Autofill of the first field of the form, if one is present.
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f32e98d77230e5c0010d7020fa659bcab628c6b6

commit f32e98d77230e5c0010d7020fa659bcab628c6b6
Author: sebsg <sebsg@chromium.org>
Date: Fri May 11 14:43:01 2018

[AF] Dynamic forms for forms with no name.

If the name of the form is empty, use the NameForAutofill of the first
field, if present, as the identifier to decide whether to trigger a
dynamic refill.

Bug:  841759 
Change-Id: I50b024fad4cfea71bc56d97587e76d1ab09dbd4e
Reviewed-on: https://chromium-review.googlesource.com/1048634
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557875}
[modify] https://crrev.com/f32e98d77230e5c0010d7020fa659bcab628c6b6/chrome/browser/autofill/autofill_interactive_uitest.cc
[add] https://crrev.com/f32e98d77230e5c0010d7020fa659bcab628c6b6/chrome/test/data/autofill/dynamic_form_no_name.html
[add] https://crrev.com/f32e98d77230e5c0010d7020fa659bcab628c6b6/chrome/test/data/autofill/dynamic_form_with_no_name_select_options_change.html
[add] https://crrev.com/f32e98d77230e5c0010d7020fa659bcab628c6b6/chrome/test/data/autofill/dynamic_synthetic_form.html
[add] https://crrev.com/f32e98d77230e5c0010d7020fa659bcab628c6b6/chrome/test/data/autofill/dynamic_synthetic_form_select_options_change.html
[modify] https://crrev.com/f32e98d77230e5c0010d7020fa659bcab628c6b6/components/autofill/content/renderer/autofill_agent.cc
[modify] https://crrev.com/f32e98d77230e5c0010d7020fa659bcab628c6b6/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/f32e98d77230e5c0010d7020fa659bcab628c6b6/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/f32e98d77230e5c0010d7020fa659bcab628c6b6/components/autofill/core/browser/form_structure.h

Comment 2 by se...@chromium.org, May 14 2018

Status: Fixed (was: Started)
►

Sign in to add a comment