New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841758 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocked on:
issue 838698
issue 844472
issue 844509
issue 848820
issue 848841
issue 848844

Blocking:
issue 535784
issue 842724



Sign in to add a comment

Enable upstreaming credit card in iOS after form submission

Project Member Reported by mahmadi@chromium.org, May 10 2018

Issue description

iOS is missing the infobar for upstreaming credit cards after form submission. The CC upstreaming infobar was never implemented in iOS due to limitations in infobars not allowing having complex infobars. After a refactoring of infobars in iOS ( crbug.com/838698 ), the CC upstreaming can now be implemented and launchd in iOS. This bug is to track that effort. 
 
Status: Started (was: Assigned)
Blockedon: 838698

Comment 3 by dlkumar@google.com, May 10 2018

Cc: dlkumar@google.com
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fd9f202b07b2dad2420c30d542d60fa09fa16b7

commit 3fd9f202b07b2dad2420c30d542d60fa09fa16b7
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu May 10 17:39:24 2018

[AF] Renames the flag that controls GPay branding in CC upstream infobar

Renames the existing flag, kAutofillUpstreamUseGooglePayOnAndroidBranding,
to kAutofillUpstreamUseGooglePayBrandingOnMobile as it also controls GPay
branding in iOS.

Adds an entry to the about flags page in iOS in order to control the flag.

Bug:841758

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I40d961f0106e14f37c5091ffbda7ac72620dd43c
Reviewed-on: https://chromium-review.googlesource.com/1053430
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557573}
[modify] https://crrev.com/3fd9f202b07b2dad2420c30d542d60fa09fa16b7/chrome/browser/about_flags.cc
[modify] https://crrev.com/3fd9f202b07b2dad2420c30d542d60fa09fa16b7/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/3fd9f202b07b2dad2420c30d542d60fa09fa16b7/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/3fd9f202b07b2dad2420c30d542d60fa09fa16b7/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/3fd9f202b07b2dad2420c30d542d60fa09fa16b7/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/3fd9f202b07b2dad2420c30d542d60fa09fa16b7/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/3fd9f202b07b2dad2420c30d542d60fa09fa16b7/ios/chrome/browser/ios_chrome_flag_descriptions.h

Project Member

Comment 5 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3fd7cded8993e5438e02a89f10e29f18d916fe0

commit c3fd7cded8993e5438e02a89f10e29f18d916fe0
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri May 11 21:40:22 2018

[AF] Controls upstreaming credit cards from chrome://flags

Adds an entry to about flags page in iOS in order to control the feature.

Bug:  841758 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id61d8f4a63f0c6a89ec4c643640e1870d58c2ae7
Reviewed-on: https://chromium-review.googlesource.com/1055904
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558026}
[modify] https://crrev.com/c3fd7cded8993e5438e02a89f10e29f18d916fe0/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/c3fd7cded8993e5438e02a89f10e29f18d916fe0/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/c3fd7cded8993e5438e02a89f10e29f18d916fe0/ios/chrome/browser/ios_chrome_flag_descriptions.h

Blocking: 535784
Project Member

Comment 7 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fac4bc9b94020f2f23d9b761d9c616e27167fe51

commit fac4bc9b94020f2f23d9b761d9c616e27167fe51
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed May 16 19:55:55 2018

[AF] Makes the credit card save infobar dismiss prompt title-case aware

This only affects Mac and iOS. Android and Linux will keep using the
non-title-cased version.

Bug:  841758 
Change-Id: I82d0c4e6ffc5d6e9975ffd18f33c56957023592e
Reviewed-on: https://chromium-review.googlesource.com/1061589
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559241}
[modify] https://crrev.com/fac4bc9b94020f2f23d9b761d9c616e27167fe51/components/components_strings.grd

Project Member

Comment 8 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb6902dfacee67552d1adc69ab6707da31c2f633

commit bb6902dfacee67552d1adc69ab6707da31c2f633
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed May 16 20:21:13 2018

[AF] Replaces old credit card save infobar icon in iOS with the new ones

Replaces the iOS icon with what's being used on Android.

Bug:  841758 
Change-Id: I31576c9bd4925c91ca28afe46c9071d97cb0ea43
Reviewed-on: https://chromium-review.googlesource.com/1061586
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559262}
[modify] https://crrev.com/bb6902dfacee67552d1adc69ab6707da31c2f633/components/resources/default_100_percent/autofill/infobar_autofill_cc.png
[modify] https://crrev.com/bb6902dfacee67552d1adc69ab6707da31c2f633/components/resources/default_200_percent/autofill/infobar_autofill_cc.png
[add] https://crrev.com/bb6902dfacee67552d1adc69ab6707da31c2f633/components/resources/default_300_percent/autofill/infobar_autofill_cc.png

Blockedon: 844509 844472

Comment 10 by jsaul@google.com, May 18 2018

Cc: jsaul@google.com
Blocking: 842724
Project Member

Comment 12 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d9047342eb58945395bc5e1ff99291ca76cee74

commit 1d9047342eb58945395bc5e1ff99291ca76cee74
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed May 23 18:23:42 2018

[AF] Refactors the Android save CC infobar and the mobile save CC delegate

Changes in this CL include:
- Using RTL-aware utility functions for the credit card obfuscated labels.
- Removing some android specific logic (e.g., messages, GPay logo resource
  id) in favor of common logic that can be shared with iOS.
- Adding pngcrushed GPay logo resources to be used by iOS.
- Removing unused strings.

Bug:841758

Change-Id: I616397ed07a6dbe05b91472e2f2b68b2a65c2093
Reviewed-on: https://chromium-review.googlesource.com/1055872
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561166}
[modify] https://crrev.com/1d9047342eb58945395bc5e1ff99291ca76cee74/chrome/android/java/src/org/chromium/chrome/browser/infobar/AutofillSaveCardInfoBar.java
[modify] https://crrev.com/1d9047342eb58945395bc5e1ff99291ca76cee74/chrome/browser/android/resource_id.h
[modify] https://crrev.com/1d9047342eb58945395bc5e1ff99291ca76cee74/chrome/browser/ui/android/infobars/autofill_save_card_infobar.cc
[modify] https://crrev.com/1d9047342eb58945395bc5e1ff99291ca76cee74/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/1d9047342eb58945395bc5e1ff99291ca76cee74/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.h
[modify] https://crrev.com/1d9047342eb58945395bc5e1ff99291ca76cee74/components/resources/autofill_scaled_resources.grdp
[add] https://crrev.com/1d9047342eb58945395bc5e1ff99291ca76cee74/components/resources/default_100_percent/autofill/infobar_autofill_googlepay_with_divider.png
[add] https://crrev.com/1d9047342eb58945395bc5e1ff99291ca76cee74/components/resources/default_200_percent/autofill/infobar_autofill_googlepay_with_divider.png
[add] https://crrev.com/1d9047342eb58945395bc5e1ff99291ca76cee74/components/resources/default_300_percent/autofill/infobar_autofill_googlepay_with_divider.png

Project Member

Comment 13 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13

commit e9a9a50cde0bb358c75d7ec18e7e43ab79522a13
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed May 23 21:13:11 2018

[AF] New infobar for saving credit cards in iOS  (local & upstream)

- Supports the new Infobar UI via the feature flag InfobarsUIReboot
- Supports GPay branding (shorter title, GPay logo, desctiption message)
  via the feature flag AutofillUpstreamUseGooglePayOnAndroidBranding

mocks: https://drive.google.com/drive/folders/1N8KNauAjwWkHSpVPXJjqdCu3FWT4iLjp

Bug:  841758 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4308ab6a192f3330bc8c667f561eb563097de90b
Reviewed-on: https://chromium-review.googlesource.com/1058312
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561254}
[modify] https://crrev.com/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13/ios/chrome/browser/infobars/infobar_container_view.mm
[modify] https://crrev.com/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13/ios/chrome/browser/infobars/infobar_controller.mm
[modify] https://crrev.com/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13/ios/chrome/browser/ui/autofill/BUILD.gn
[delete] https://crrev.com/92e232642e3a174df5530b6a5b090272cf04641e/ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm
[modify] https://crrev.com/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[add] https://crrev.com/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13/ios/chrome/browser/ui/autofill/save_card_infobar_controller.h
[add] https://crrev.com/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13/ios/chrome/browser/ui/autofill/save_card_infobar_controller.mm
[add] https://crrev.com/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13/ios/chrome/browser/ui/autofill/save_card_infobar_view.h
[add] https://crrev.com/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
[add] https://crrev.com/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13/ios/chrome/browser/ui/autofill/save_card_infobar_view_delegate.h
[modify] https://crrev.com/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13/ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
[modify] https://crrev.com/e9a9a50cde0bb358c75d7ec18e7e43ab79522a13/ios/chrome/browser/ui/infobars/infobar_view_sizing.h

Status: Fixed (was: Started)
Project Member

Comment 15 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c296713ec2aa11ba37699cba3c783661b4c00ef

commit 7c296713ec2aa11ba37699cba3c783661b4c00ef
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu May 24 17:08:25 2018

[AF] Field trial for the GPay branding on the cc upstreaming infobar on iOS

Bug:  841758 
Change-Id: Ice6932221f401e20251926fe2cb41ba6f9061f52
Reviewed-on: https://chromium-review.googlesource.com/1070622
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561534}
[modify] https://crrev.com/7c296713ec2aa11ba37699cba3c783661b4c00ef/testing/variations/fieldtrial_testing_config.json

Blockedon: 848844
Blockedon: 848841
Blockedon: 848820
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e2c0ac9c10e5671cbf5b66957f2c79a02b9638a

commit 6e2c0ac9c10e5671cbf5b66957f2c79a02b9638a
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Jul 26 18:56:39 2018

[AF][IOS] Makes the new CC save infobar the default infobar for local save

Bug:  841758 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1475b5ccf301eb83cdecc0b9fbd2ba5d56092416
Reviewed-on: https://chromium-review.googlesource.com/1151488
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578388}
[modify] https://crrev.com/6e2c0ac9c10e5671cbf5b66957f2c79a02b9638a/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm

Sign in to add a comment