New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841756 link

Starred by 2 users
Status: Fixed
Owner:
█ loonyb...@chromium.org
Last visit > 30 days ago
Closed: Jul 20
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Optimized image policy image color inversion fails when an image has the border-radius property set

Project Member Reported by iclell...@chromium.org, May 10 2018 
The logic which inverts the image colors when an image policy is violated seems to fail when the images has a border radius > 0 px.

This is independent of border-width; so it does not seem to depend on whether the image content is actually clipped or not by the border curvature.

I can't tell whether the inversion is not happening, or is being applied twice, in this case -- but either way is incorrect :)

Comment 1 by iclell...@chromium.org, May 10 2018 

Attaching simple repro case
test.html
200 bytes View Download

Comment 2 by schenney@chromium.org, May 10 2018 

Maybe due to the use of a border radius mask?

Comment 3 by iclell...@chromium.org, May 31 2018

Blocking: -837346

Comment 4 by iclell...@chromium.org, May 31 2018

Labels: -M-68 Target-69

Comment 5 by loonyb...@chromium.org, Jul 19

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e

commit 1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e
Author: Luna Lu <loonybear@chromium.org>
Date: Thu Jul 19 22:52:27 2018

Bug fix for optimized image policy image color inversion fails with border radius


The cause is when there is a border radius, current code path only
copies the border radius properties to be painted.
This CL fixes the problem by copying other properties when image
policy is violated.


Bug:  841756 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I29ed9b9860de3ae3f07217fd33d517c4c42909e5
Reviewed-on: https://chromium-review.googlesource.com/1138973
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576673}
[add] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-image-policies-with-border-radius-expected.png
[add] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-image-policies-with-border-radius-expected.txt
[add] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/http/tests/images/feature-policy-image-policies-with-border-radius.html
[add] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/http/tests/images/resources/frame-with-images-with-border-radius.html
[modify] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-expected.png
[modify] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-expected.txt
[modify] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/images/resources/frame-with-max-downscaling-image-test-images.html
[modify] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-expected.png
[modify] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/platform/mac/images/feature-policy-max-downscaling-image-expected.txt
[modify] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-expected.png
[modify] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/platform/mac/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-expected.txt
[add] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-expected.txt
[modify] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/virtual/exotic-color-space/images/feature-policy-max-downscaling-image-expected.png
[add] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/WebKit/LayoutTests/virtual/gpu-rasterization/images/feature-policy-max-downscaling-image-expected.png
[modify] https://crrev.com/1c11e7d534f1a466b5ea5314c6fc93bc74ec8a8e/third_party/blink/renderer/core/paint/replaced_painter.cc

Comment 7 by loonyb...@chromium.org, Jul 20

Status: Fixed (was: Started)
►

Sign in to add a comment