inspired by danakj cleaning up Blink compositor integration
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd620b69bd94904966229f927f9f408f28edf8f5 commit fd620b69bd94904966229f927f9f408f28edf8f5 Author: Jeremy Roman <jbroman@chromium.org> Date: Thu May 10 18:22:24 2018 Radically simplify Blink scrollbar painting. This collapses most of the logic for painting composited scrollbars into ScrollbarLayerDelegate. There was only one path and lots of indirection before, most of which can now go away. This allows WebScrollbarImpl, WebScrollbarThemeClientImpl, WebScrollbarThemeGeometryNative and WebScrollbarThemePainter to be deleted. Bits of WebScrollbar remain, since there are a handful of places that still use enums defined in its header. Bug: 841751 Change-Id: Id37c75bc50e5138b44c5d6ba0add08f73ad71f0c Reviewed-on: https://chromium-review.googlesource.com/1052919 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557591} [modify] https://crrev.com/fd620b69bd94904966229f927f9f408f28edf8f5/third_party/blink/public/BUILD.gn [modify] https://crrev.com/fd620b69bd94904966229f927f9f408f28edf8f5/third_party/blink/public/platform/web_compositor_support.h [modify] https://crrev.com/fd620b69bd94904966229f927f9f408f28edf8f5/third_party/blink/public/platform/web_scrollbar.h [delete] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/third_party/blink/public/platform/web_scrollbar_theme_geometry.h [delete] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/third_party/blink/public/platform/web_scrollbar_theme_painter.h [modify] https://crrev.com/fd620b69bd94904966229f927f9f408f28edf8f5/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc [modify] https://crrev.com/fd620b69bd94904966229f927f9f408f28edf8f5/third_party/blink/renderer/platform/BUILD.gn [delete] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/third_party/blink/renderer/platform/exported/web_scrollbar_impl.cc [delete] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/third_party/blink/renderer/platform/exported/web_scrollbar_impl.h [delete] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/third_party/blink/renderer/platform/exported/web_scrollbar_theme_client_impl.cc [delete] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/third_party/blink/renderer/platform/exported/web_scrollbar_theme_client_impl.h [delete] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/third_party/blink/renderer/platform/exported/web_scrollbar_theme_geometry_native.cc [delete] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/third_party/blink/renderer/platform/exported/web_scrollbar_theme_geometry_native.h [delete] https://crrev.com/fcc242582725ec49fed096fc3d4d794ac455d76e/third_party/blink/renderer/platform/exported/web_scrollbar_theme_painter.cc [modify] https://crrev.com/fd620b69bd94904966229f927f9f408f28edf8f5/third_party/blink/renderer/platform/geometry/int_point.cc [modify] https://crrev.com/fd620b69bd94904966229f927f9f408f28edf8f5/third_party/blink/renderer/platform/geometry/int_point.h [modify] https://crrev.com/fd620b69bd94904966229f927f9f408f28edf8f5/third_party/blink/renderer/platform/scroll/scrollbar.cc [modify] https://crrev.com/fd620b69bd94904966229f927f9f408f28edf8f5/third_party/blink/renderer/platform/scroll/scrollbar_layer_delegate.cc [modify] https://crrev.com/fd620b69bd94904966229f927f9f408f28edf8f5/third_party/blink/renderer/platform/scroll/scrollbar_layer_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/684f55e03db425bf17f91ec0c1133608e4caac2a commit 684f55e03db425bf17f91ec0c1133608e4caac2a Author: Jeremy Roman <jbroman@chromium.org> Date: Sat May 12 03:25:37 2018 Replace remaining uses of WebScrollbar::Orientation with ScrollbarOrientation. Bug: 841751 Change-Id: I965b442ef21d0f199574d8d4ff04fc03af7158b9 Reviewed-on: https://chromium-review.googlesource.com/1054248 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558104} [modify] https://crrev.com/684f55e03db425bf17f91ec0c1133608e4caac2a/third_party/blink/public/platform/web_scrollbar.h [modify] https://crrev.com/684f55e03db425bf17f91ec0c1133608e4caac2a/third_party/blink/renderer/core/frame/visual_viewport.cc [modify] https://crrev.com/684f55e03db425bf17f91ec0c1133608e4caac2a/third_party/blink/renderer/core/frame/visual_viewport.h [modify] https://crrev.com/684f55e03db425bf17f91ec0c1133608e4caac2a/third_party/blink/renderer/platform/scroll/scrollbar.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f4525242b17f03f4fe3edd8b24a4e6e19b61d80 commit 1f4525242b17f03f4fe3edd8b24a4e6e19b61d80 Author: Jeremy Roman <jbroman@chromium.org> Date: Tue May 15 14:15:54 2018 Inline the aliased definition of WebFrameOwnerProperties::ScrollingMode. There are no uses aside from the ones in WebFrameOwnerProperties. With that gone, remove web_scrollbar.h, which has become empty. Bug: 841751 Change-Id: I542ba4f26b70feed999f7a108a5a67636fb65e23 Reviewed-on: https://chromium-review.googlesource.com/1054331 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#558694} [modify] https://crrev.com/1f4525242b17f03f4fe3edd8b24a4e6e19b61d80/third_party/blink/public/BUILD.gn [delete] https://crrev.com/16b5675d433ff43b918e7595a142ff4b47b2aaab/third_party/blink/public/platform/web_scrollbar.h [modify] https://crrev.com/1f4525242b17f03f4fe3edd8b24a4e6e19b61d80/third_party/blink/public/web/web_frame_owner_properties.h [modify] https://crrev.com/1f4525242b17f03f4fe3edd8b24a4e6e19b61d80/third_party/blink/renderer/core/exported/web_frame.cc [modify] https://crrev.com/1f4525242b17f03f4fe3edd8b24a4e6e19b61d80/third_party/blink/renderer/core/html/forms/external_popup_menu.h [modify] https://crrev.com/1f4525242b17f03f4fe3edd8b24a4e6e19b61d80/third_party/blink/renderer/platform/scroll/scrollbar.cc [modify] https://crrev.com/1f4525242b17f03f4fe3edd8b24a4e6e19b61d80/third_party/blink/renderer/platform/scroll/scrollbar_layer_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e976aa3ab8d1929c35df329337a333ece8d593e commit 9e976aa3ab8d1929c35df329337a333ece8d593e Author: Jeremy Roman <jbroman@chromium.org> Date: Wed May 16 22:39:14 2018 Squash ScrollbarThemeClient into Scrollbar. Bug: 841751 Change-Id: I6913fa775c3783f10d98a701479e403ca6fc92fc Reviewed-on: https://chromium-review.googlesource.com/1054146 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559318} [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/core/layout/layout_scrollbar.h [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/core/layout/layout_scrollbar_theme.cc [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/core/layout/layout_scrollbar_theme.h [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/BUILD.gn [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollable_area_test.cc [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar.h [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar_theme.cc [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar_theme.h [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar_theme_aura.cc [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar_theme_aura.h [delete] https://crrev.com/c2a8a1edde018e0b6663df282d4b51c3b0adf2f4/third_party/blink/renderer/platform/scroll/scrollbar_theme_client.h [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar_theme_mac.h [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar_theme_mac.mm [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar_theme_mock.cc [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar_theme_mock.h [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar_theme_overlay.cc [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar_theme_overlay.h [modify] https://crrev.com/9e976aa3ab8d1929c35df329337a333ece8d593e/third_party/blink/renderer/platform/scroll/scrollbar_theme_overlay_mock.h
Total delta: -1202 LOC :)
Comment 1 by bugdroid1@chromium.org
, May 10 2018