New issue
Advanced search Search tips

Issue 841743 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Leak in speechrecognitiondispatcherhost during teardown

Project Member Reported by maxmorin@chromium.org, May 10 2018

Issue description

There's a trampoline method like this, where |sender_| is a weak pointer:

void SpeechRecognitionDispatcherHost::Send(IPC::Message* message) {
  DCHECK_CURRENTLY_ON(BrowserThread::IO);
  // The weak ptr must only be accessed on the UI thread.
  BrowserThread::PostTask(
      BrowserThread::UI, FROM_HERE,
      base::BindOnce(base::IgnoreResult(&IPC::Sender::Send), sender_, message));

|message| is an owning raw pointer (a convention of Chrome legacy IPC). If the task is cancelled after being posted, the message is leaked.
 
Cc: -adithyas@chromium.org
Owner: adithyas@chromium.org
Status: Assigned (was: Available)
This should be fixed once https://crrev.com/c/1036230 lands.
Oh, excellent!
Status: Fixed (was: Assigned)
https://crrev.com/c/1036230 landed, so I think this is fixed.

Sign in to add a comment