New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841735 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Xoogler
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 470454



Sign in to add a comment

Blink Scheduler: cc::OrderedSimpleTaskRunner decommissioning

Project Member Reported by kraynov@chromium.org, May 10 2018

Issue description

We don't want to use it anymore in scheduler for sake of consistency and minimal dependency. Should be replace with base's ScopedTaskEnvironment or TestMockTimeTaskRunner.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96248a9d450793339e6c3a24c9a449cae4126fa9

commit 96248a9d450793339e6c3a24c9a449cae4126fa9
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu May 10 12:46:59 2018

Remove cc::OrderedSimpleTaskRunner in ShedulerHelper unit tests.

Bug:  841735 
Change-Id: I38872f08a406c208b65f15845293b2ad55d20b19
Reviewed-on: https://chromium-review.googlesource.com/1053767
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557496}
[modify] https://crrev.com/96248a9d450793339e6c3a24c9a449cae4126fa9/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc

Done:
XL scheduler/base/task_queue_manager_impl_unittests.cc (https://chromium-review.googlesource.com/1037144)
S  scheduler/common/scheduler_helper_unittest.cc

To do (with estimated effort):
S  scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
XL scheduler/child/idle_helper_unittest.cc (needs additional refactoring)
S  scheduler/child/worker_scheduler_proxy_unittest.cc
S  scheduler/common/throttling/budget_pool_unittest.cc
L  scheduler/common/throttling/task_queue_throttler_unittest.cc
S  scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc
S  scheduler/main_thread/deadline_task_runner_unittest.cc
S  scheduler/main_thread/frame_scheduler_impl_unittest.cc
M  scheduler/main_thread/idle_time_estimator_unittest.cc
S  scheduler/main_thread/main_thread_metrics_helper_unittest.cc
XL scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
L  scheduler/main_thread/page_scheduler_impl_unittest.cc
M  scheduler/worker/worker_thread_scheduler_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3a6a4989e636111cf168d4f41269e4da9c829b0

commit f3a6a4989e636111cf168d4f41269e4da9c829b0
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu May 10 16:31:07 2018

Remove cc::OrderedSimpleTaskRunner in WorkerSchedulerProxy tests.

Bug:  841735 
Change-Id: I268a97109e95d435a3cb64e8d04f8741ebc60bda
Reviewed-on: https://chromium-review.googlesource.com/1054028
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557552}
[modify] https://crrev.com/f3a6a4989e636111cf168d4f41269e4da9c829b0/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9ff47b820b2a6f9cba370b83a4cb9a8f82702c1

commit c9ff47b820b2a6f9cba370b83a4cb9a8f82702c1
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu May 10 16:34:41 2018

Remove cc::OrderedSimpleTaskRunner in AutoAdvancingVirtualTimeDomain tests.

Bug:  841735 
Change-Id: I8d87679e2c813b91a6c45981ef0cc0c73a90191e
Reviewed-on: https://chromium-review.googlesource.com/1053808
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557553}
[modify] https://crrev.com/c9ff47b820b2a6f9cba370b83a4cb9a8f82702c1/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5edc9400e83f170865beeb3be324c920f4845cb8

commit 5edc9400e83f170865beeb3be324c920f4845cb8
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu May 31 11:38:10 2018

Remove cc::OrderedSimpleTaskRunner in MainThreadMetricsHelper tests.

Bug:  841735 
Change-Id: I958e16579503c88b175a9e28ac9cbdbcb08fc7ae
Reviewed-on: https://chromium-review.googlesource.com/1080547
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563191}
[modify] https://crrev.com/5edc9400e83f170865beeb3be324c920f4845cb8/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cfc63bf4ee4118265a1c195b47f515d0997e9ee

commit 6cfc63bf4ee4118265a1c195b47f515d0997e9ee
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu May 31 11:40:20 2018

Remove cc::OrderedSimpleTaskRunner in FrameSchedulerImpl tests.

Bug:  841735 
Change-Id: I48c961ae0d98787d36de9d3017c764f836cde3aa
Reviewed-on: https://chromium-review.googlesource.com/1079573
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563192}
[modify] https://crrev.com/6cfc63bf4ee4118265a1c195b47f515d0997e9ee/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc

Started refactoring main_thread_scheduler_impl_unittest.cc

Other tests remaining:
S  scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
XL scheduler/child/idle_helper_unittest.cc
S  scheduler/common/throttling/budget_pool_unittest.cc
L  scheduler/common/throttling/task_queue_throttler_unittest.cc
S  scheduler/main_thread/deadline_task_runner_unittest.cc
M  scheduler/main_thread/idle_time_estimator_unittest.cc
L  scheduler/main_thread/page_scheduler_impl_unittest.cc
M  scheduler/worker/worker_thread_scheduler_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84607687d67666ff22d870f96f97d69b42c7dbca

commit 84607687d67666ff22d870f96f97d69b42c7dbca
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Jun 01 14:28:12 2018

Refactor MainThreadSchedulerImpl tests.

Bug:  841735 
Change-Id: Ieb6b6c2be0347ae67004ac62645ed303a3748a9f
Reviewed-on: https://chromium-review.googlesource.com/1080551
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563620}
[modify] https://crrev.com/84607687d67666ff22d870f96f97d69b42c7dbca/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc

Blocking: 470454
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca04c733ef42159ae8f952e9fe002e8a1251f8ad

commit ca04c733ef42159ae8f952e9fe002e8a1251f8ad
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Jun 08 13:09:13 2018

Remove cc::OrderedSimpleTaskRunner in DeadlineTaskRunner tests.

Bug:  841735 
Change-Id: I0c385ce6bdd147b859a553e0bcf820adf379fd71
Reviewed-on: https://chromium-review.googlesource.com/1092742
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565616}
[modify] https://crrev.com/ca04c733ef42159ae8f952e9fe002e8a1251f8ad/third_party/blink/renderer/platform/scheduler/main_thread/deadline_task_runner_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0276e117a9cf26ad5e7b8aed8d4b4e62d04b9151

commit 0276e117a9cf26ad5e7b8aed8d4b4e62d04b9151
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Jun 08 14:55:56 2018

Remove cc::OrderedSimpleTaskRunner in IdleTimeEstimator tests.

Bug:  841735 
Change-Id: I3b3e808fc2537da93cdf460cbc1da2c0cdbe35d7
Reviewed-on: https://chromium-review.googlesource.com/1092743
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565633}
[modify] https://crrev.com/0276e117a9cf26ad5e7b8aed8d4b4e62d04b9151/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator_unittest.cc

Also I plan to remove it from Blink entirely :)

Non-scheduler files:
platform/testing/testing_platform_support_with_mock_scheduler.cc
platform/timer_test.cc
Cc: briander...@chromium.org
 Issue 470454  has been merged into this issue.
Labels: -Pri-3 Pri-2
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64cd55fda8641aa94932c4ef5583c44f5824c7b5

commit 64cd55fda8641aa94932c4ef5583c44f5824c7b5
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Jun 08 15:17:38 2018

Refactor PageSchedulerImpl tests.

- Removed cc::OrderedSimpleTaskRunner.
- Removed redundant test fixture.
- WTF::Bind --> base::BindOnce.

Bug:  841735 
Change-Id: Iada37d1c7ad60149eb9a933b5968b6101a76bebc
Reviewed-on: https://chromium-review.googlesource.com/1092864
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565635}
[modify] https://crrev.com/64cd55fda8641aa94932c4ef5583c44f5824c7b5/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f42de30a8b88c8741581f12731b90a2df48f80b8

commit f42de30a8b88c8741581f12731b90a2df48f80b8
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu Jun 14 14:56:36 2018

Refactor WorkerThreadScheduler unit tests.

Bug:  841735 
Change-Id: I86007d80dd719cd00c4b224d9f88479daa1bb422
Reviewed-on: https://chromium-review.googlesource.com/1101019
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567263}
[modify] https://crrev.com/f42de30a8b88c8741581f12731b90a2df48f80b8/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc

Testing platform in review:
https://chromium-review.googlesource.com/1093095

Tests remaining:
S  scheduler/common/idle_canceled_delayed_task_sweeper_unittest.cc
XL scheduler/common/idle_helper_unittest.cc
S  scheduler/common/throttling/budget_pool_unittest.cc
L  scheduler/common/throttling/task_queue_throttler_unittest.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f55a4bc4da8eb9173637aeda77f7e91542421253

commit f55a4bc4da8eb9173637aeda77f7e91542421253
Author: Greg Kraynov <kraynov@chromium.org>
Date: Mon Jul 09 16:31:08 2018

Use NullTaskRunner in BudgetPool tests.

Bug:  841735 
Change-Id: I5a38422269e6635c6cc7b4880c1a9108b0bd3761
Reviewed-on: https://chromium-review.googlesource.com/1129231
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573330}
[modify] https://crrev.com/f55a4bc4da8eb9173637aeda77f7e91542421253/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4679480824b53bee194ae0ddd61a8b7ee7ea4d2

commit a4679480824b53bee194ae0ddd61a8b7ee7ea4d2
Author: Greg Kraynov <kraynov@chromium.org>
Date: Mon Jul 09 17:43:20 2018

Remove cc::OrderedSimpleTaskRunner in IdleCanceledDelayedTaskSweeper test.

Bug:  841735 
Change-Id: Iadce66ec21790bdf7ce9149452c4b158d3fc3db4
Reviewed-on: https://chromium-review.googlesource.com/1129234
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573356}
[modify] https://crrev.com/a4679480824b53bee194ae0ddd61a8b7ee7ea4d2/third_party/blink/renderer/platform/scheduler/common/idle_canceled_delayed_task_sweeper_unittest.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a17c7f0d1cb7f5582dbb88751e6605c8800b135

commit 1a17c7f0d1cb7f5582dbb88751e6605c8800b135
Author: Greg Kraynov <kraynov@chromium.org>
Date: Tue Jul 10 12:34:23 2018

Remove cc::OrderedSimpleTaskRunner in TaskQueueThrottler tests.

Bug:  841735 
Change-Id: Icc3e5b8762eac9785f08f2e6048688c2f591fd70
Reviewed-on: https://chromium-review.googlesource.com/1129521
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573691}
[modify] https://crrev.com/1a17c7f0d1cb7f5582dbb88751e6605c8800b135/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc

Project Member

Comment 22 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7edc3debe8cfd6252336e7e8c2cc9a705d1ce53

commit c7edc3debe8cfd6252336e7e8c2cc9a705d1ce53
Author: Greg Kraynov <kraynov@chromium.org>
Date: Tue Jul 10 15:48:57 2018

Auto-advancing clock for TaskQueueThrottler tests.

Bug:  841735 
Change-Id: I800c902a4c4a6c28a95279bb0b81a5d57c9402f6
Reviewed-on: https://chromium-review.googlesource.com/1131501
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573749}
[modify] https://crrev.com/c7edc3debe8cfd6252336e7e8c2cc9a705d1ce53/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0e2bb5892b82fcc5a3bdf7cbffec1d01e4a5214

commit d0e2bb5892b82fcc5a3bdf7cbffec1d01e4a5214
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed Jul 11 12:33:54 2018

Remove cc::OrderedSimpleTaskRunner in IdleHelper tests.

Bug:  841735 
Change-Id: I95f2c967423fd5419002527c2b18041b8e5d499a
Reviewed-on: https://chromium-review.googlesource.com/1131746
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574131}
[modify] https://crrev.com/d0e2bb5892b82fcc5a3bdf7cbffec1d01e4a5214/third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a7df13b2932f8f83559de4c263c972e08f9301b

commit 8a7df13b2932f8f83559de4c263c972e08f9301b
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu Jul 12 20:07:20 2018

Remove components/viz/test dependency from blink platform.

cc::OrderedSimpleTestTaskRunner isn't used there anymore.

Bug:  841735 
Change-Id: I88a5bfa2ebaf01a08943396ce20f63c483a19b3a
Reviewed-on: https://chromium-review.googlesource.com/1133177
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574694}
[modify] https://crrev.com/8a7df13b2932f8f83559de4c263c972e08f9301b/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/8a7df13b2932f8f83559de4c263c972e08f9301b/third_party/blink/renderer/platform/scheduler/child/DEPS
[delete] https://crrev.com/e95b7292bae44c8e6fb9af5801f102ae28587d6c/third_party/blink/renderer/platform/scheduler/common/DEPS
[modify] https://crrev.com/8a7df13b2932f8f83559de4c263c972e08f9301b/third_party/blink/renderer/platform/scheduler/main_thread/DEPS
[modify] https://crrev.com/8a7df13b2932f8f83559de4c263c972e08f9301b/third_party/blink/renderer/platform/scheduler/renderer/DEPS
[modify] https://crrev.com/8a7df13b2932f8f83559de4c263c972e08f9301b/third_party/blink/renderer/platform/scheduler/worker/DEPS
[modify] https://crrev.com/8a7df13b2932f8f83559de4c263c972e08f9301b/third_party/blink/renderer/platform/testing/DEPS

Status: Fixed (was: Started)
Done for Blink, so closing this bug.
Complete removal task:  https://crbug.com/863350 
Awesome!!! Thanks for doing this cleanup, hopefully we can drive the
remaining bits home and delete OrderedSimpleTaskRunner completely :)

Le ven. 13 juill. 2018 06 h 11, kraynov via monorail <
monorail+v2.3634340931@chromium.org> a écrit :

Sign in to add a comment