Multiple browser_test failures on Win,Mac,Linux trunk on continuous and on 68.0.3426.0 on official.desktop builder |
||||
Issue descriptionLink to the builder: ==================== official.desktop.continuous https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20trunk https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk official.desktop(68.0.3426.0) https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-clang/builds/993 https://uberchromegw.corp.google.com/i/official.desktop/builders/win-clang/builds/994 https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/961 https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/2941 https://uberchromegw.corp.google.com/i/official.desktop/builders/linux64/builds/1369 Some of the test failures: ========================== BrowserNavigatorTest.CloseSingletonTab BrowserNavigatorTest.Disposition_SingletonTabExistingSubPath_IgnorePath BrowserNavigatorTest.Disposition_SingletonTabExisting_IgnorePath BrowserNavigatorTest.Disposition_SingletonTabExisting_IgnoreQuery BrowserNavigatorTest.Disposition_SingletonTabFocused_IgnorePath BrowserNavigatorTest.Disposition_SingletonTabNew_IgnorePath BrowserNavigatorTest.Disposition_ViewSource_Settings_UseNonIncognitoWindow BrowserNavigatorTest.NavigateFromBlankToOptionsInSameTab BrowserNavigatorTest.NavigateFromDefaultToOptionsInSameTab BrowserNavigatorTest.NavigateFromNTPToOptionsInSameTab BrowserNavigatorTest.NavigateFromNTPToOptionsPageInSameTab BrowserNavigatorTest.NavigateFromNTPToOptionsSingleton BrowserNavigatorTest.NavigateFromOtherTabToSingletonOptions BrowserNavigatorTest.NavigateFromPageToOptionsInNewTab BrowserNavigatorTest.SingletonIncognitoLeak BrowserNavigatorTest.SwitchToTabIncognitoLeak BrowsingDataRemoverBrowserTest.CacheStorageDeletion BrowsingDataRemoverBrowserTest.CookieDeletion BrowsingDataRemoverBrowserTest.Database BrowsingDataRemoverBrowserTest.EmptyFileSystem BrowsingDataRemoverBrowserTest.EmptyIndexedDb BrowsingDataRemoverBrowserTest.EmptyWebSql BrowsingDataRemoverBrowserTest.ExternalProtocolHandlerPrefs BrowsingDataRemoverBrowserTest.FileSystemDeletion BrowsingDataRemoverBrowserTest.IndexedDbDeletion BrowsingDataRemoverBrowserTest.LocalStorageDeletion BrowsingDataRemoverBrowserTest.ServiceWorkerDeletion BrowsingDataRemoverBrowserTest.SessionStorageCounting BrowsingDataRemoverBrowserTest.WebSqlDeletion ChromePasswordProtectionServiceBrowserTest.OpenChromeSettingsViaPageInfo ChromePasswordProtectionServiceBrowserTest.SuccessfullyChangePassword ContentSettingBubbleModelPopupTest.PopupsActionsCount CrControlledButtonTest.All CrControlledRadioButtonTest.All CrSettingsAboutPageTest.AboutPage CrSettingsAboutPageTest.AboutPage_OfficialBuild CrSettingsAllSitesTest.All CrSettingsAppearanceFontsPageTest.All CrSettingsAppearancePageTest.All CrSettingsCategoryDefaultSettingTest.All CrSettingsCategorySettingExceptionsTest.All CrSettingsChangePasswordPageTest.All CrSettingsCheckboxTest.All CrSettingsChromeCleanupPageTest.All CrSettingsDefaultBrowserTest.All CrSettingsDownloadsPageTest.All CrSettingsDropdownMenuTest.All CrSettingsEditDictionaryPageTest.All CrSettingsExtensionControlledIndicatorTest.All Link to the error log: ====================== https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Flinux64_trunk%2F9876%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout Errorlog: ========= Unable to figureout any relevant info from the log. Changelog: ========== https://chromium.googlesource.com/chromium/src/+log/68.0.3425.0..68.0.3426.0?pretty=fuller&n=10000 Could all these test failures be related to P0 browser crash Issue 841685 and https://chromium-review.googlesource.com/c/chromium/src/+/1050976 from the regression range. One of the test failure has ChromePasswordProtectionServiceBrowserTest.OpenChromeSettingsViaPageInfo (../../chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc:284) and majority of the P0 crash Issue 841685 are seen while opening settings page. Assigning to nharper@ for more inputs on this.
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1772494e8fe6ed97c03577a1dde99bf4527bad76 commit 1772494e8fe6ed97c03577a1dde99bf4527bad76 Author: Nick Harper <nharper@chromium.org> Date: Thu May 10 19:52:55 2018 Enable Channel ID Too many places throughout the codebase assumed that an URLRequestContext would have a (non-null) ChannelIDService. When the base::Feature kChannelID is disabled, this results in a null ChannelIDService on the URLRequestContext, and results in crashes due to null derefs. Bug: 841730 , 841685 Change-Id: Iece0f584d7c05e90ea16da2ea9319b66768ded33 Reviewed-on: https://chromium-review.googlesource.com/1054177 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#557635} [modify] https://crrev.com/1772494e8fe6ed97c03577a1dde99bf4527bad76/components/network_session_configurator/common/network_features.cc
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c1c93db7c47aa39b55b4c3119ee481308b88422 commit 8c1c93db7c47aa39b55b4c3119ee481308b88422 Author: Nick Harper <nharper@chromium.org> Date: Thu May 10 20:50:38 2018 Enable Channel ID Too many places throughout the codebase assumed that an URLRequestContext would have a (non-null) ChannelIDService. When the base::Feature kChannelID is disabled, this results in a null ChannelIDService on the URLRequestContext, and results in crashes due to null derefs. Bug: 841730 , 841685 Change-Id: Iece0f584d7c05e90ea16da2ea9319b66768ded33 Reviewed-on: https://chromium-review.googlesource.com/1054177 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#557635}(cherry picked from commit 1772494e8fe6ed97c03577a1dde99bf4527bad76) Reviewed-on: https://chromium-review.googlesource.com/1054353 Reviewed-by: Abdul Syed <abdulsyed@google.com> Cr-Commit-Position: refs/branch-heads/3426@{#4} Cr-Branched-From: 2a324b4c3ab068ca99b5dead0b2a336a4776befb-refs/heads/master@{#557428} [modify] https://crrev.com/8c1c93db7c47aa39b55b4c3119ee481308b88422/components/network_session_configurator/common/network_features.cc
,
May 11 2018
Just to update: Still seeing the issue on Mac trunk builds.Please find the build url's as below Link to the builder: -------------------- https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20trunk/builds/12309 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac64%20trunk/builds/12308 Note: Remaining official and continuous builds are working fine. Link to the builder: -------------------- https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/962 https://uberchromegw.corp.google.com/i/official.desktop/builders/win-clang/builds/998 https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-clang/builds/997 https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/2944
,
May 11 2018
The blame CL https://chromium-review.googlesource.com/c/chromium/src/+/1050976 has been reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1054205 and https://chromium-review.googlesource.com/c/chromium/src/+/1054177. If this is still a problem, it's completely unrelated to the blame CL. |
||||
►
Sign in to add a comment |
||||
Comment 1 by nhar...@chromium.org
, May 10 2018