New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841727 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Layout Test http/tests/media/media-load-nonmedia-crossorigin.html is flaky

Project Member Reported by maxmorin@chromium.org, May 10 2018

Issue description

The following layout test is flaky on all the platforms

http/tests/media/media-load-nonmedia-crossorigin.html

See flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fmedia%2Fmedia-load-nonmedia-crossorigin.html
 
Owner: hubbe@chromium.org
Status: Assigned (was: Untriaged)
hubbe@, can you have a look at this given that the test is quite new?

Comment 2 by hubbe@chromium.org, May 15 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c3de04ee307a86b1f54f41ec3a3351aea33baee

commit 5c3de04ee307a86b1f54f41ec3a3351aea33baee
Author: Fredrik Hubinette <hubbe@google.com>
Date: Thu May 17 23:09:55 2018

Make media-load-nonmedia-crossorigin.html not flaky

The current test cares if a state change is discovered in
a timer callback or an event callback. The video tag will
change the state, then schedule an event callback, but if
a timer event is already scheduled, it will detect the
state change first.

This CL changes the collected events so that a state
change detected by a timer event looks the same as a
state change detected by an event callback, which should
make the test work reliably.

Bug:  841727 
Change-Id: I9607a247f3e57c21d3d4f8a0b84d6df3d66c17b7
Reviewed-on: https://chromium-review.googlesource.com/1060240
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559725}
[modify] https://crrev.com/5c3de04ee307a86b1f54f41ec3a3351aea33baee/third_party/WebKit/LayoutTests/http/tests/media/media-load-nonmedia-crossorigin.html

Comment 4 by hubbe@chromium.org, May 18 2018

Status: Verified (was: Started)
Fixed and verified. (Dashboard looks much better now)

Sign in to add a comment