New issue
Advanced search Search tips

Issue 841722 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: May 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Default focus is missing on 'Person name' text field in 'Add person' window.

Reported by avsha...@etouch.net, May 10 2018 
Chrome Version : 68.0.3426.0 (Official Build) ccd67e9feb61a58dd00a63b10cc08a36db957cba-refs/branch-heads/3426@{#1} 32/64-bit
OS : Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, click on Avatar button and go to 'Manage People' .
2. Click on 'ADD PERSON' button and observe the 'Person name' text field.

Actual Result : Default focus is missing on 'Person name' text field in 'Add person' window.

Expected Result : Default focus should be seen in 'Person name' text field in 'Add person' window.

This is a regression issue, broken in M-68 and will soon update other info.
Good Build : 68.0.3425.0 (Revision : 557063)
Bad Build : 68.0.3426.0 (Revision : 557428)
Actual_Result.mp4
314 KB View Download
Expected_Result.mp4
301 KB View Download

Comment 1 by avsha...@etouch.net, May 10 2018

Labels: hasbisect-per-revision RegressedIn-68 ET-MUM-Reported FoundIn-68 Target-68
Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-68 and providing the bisect using Per-Revision script:
Good Build : 68.0.3425.0 (Revision : 557063)
Bad Build : 68.0.3426.0 (Revision : 557428)

You are probably looking for a change made after 557076 (known good), but no later than 557077 (first known bad).

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/93e0c457e3eaa198899e7498526c24f1e1260ac0..ba0669a2a785eabe7b86248605579c7a2a66b96d

Suspect : https://chromium.googlesource.com/chromium/src/+/ba0669a2a785eabe7b86248605579c7a2a66b96d

@Hector : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by hcarmona@chromium.org, May 14 2018

Status: Started (was: Assigned)
Fix uploaded for regression: https://crrev.com/c/1058029
Project Member

Comment 3 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caf56a844bf0ba586978a332216438be4e88788b

commit caf56a844bf0ba586978a332216438be4e88788b
Author: Hector Carmona <hcarmona@chromium.org>
Date: Mon May 14 21:28:34 2018

WebUI: Fix regression in focus when adding a new person.

Bug:  841722 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If3e5e0c3866bee7660dfbab37b309f3c63978cdf
Reviewed-on: https://chromium-review.googlesource.com/1058029
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558468}
[modify] https://crrev.com/caf56a844bf0ba586978a332216438be4e88788b/chrome/browser/resources/md_user_manager/create_profile.js

Comment 4 by avsha...@etouch.net, May 15 2018 

Update : 
Retested above issue in latest Canary build #68.0.3431.0 on Mac(10.12.6, 10.13.1, 10.13.5) & Linux(14.04 LTS) OS and the issue is fixed on these two OS. But unable to test the same on Windows 32 & 64-bit canary (due to issue crbug.com/843012). Kindly review an attached screen-cast about latest behaviour on Mac OS.

Thank you..!
Canary_results.mov
3.1 MB View Download

Comment 5 by hcarmona@chromium.org, May 15 2018

Status: Fixed (was: Started)

Comment 6 by avsha...@etouch.net, May 16 2018

Labels: TE-Verified-68.0.3432.0 TE-Verified-M68
Update : 
Verified issue in today's Canary build #68.0.3432.0 on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5) & Linux(14.04 LTS) OS and the issue is fixed. Hence adding TE-Verified labels using canary build, kindly review an attached screen-cast.

Thank you..!
Windows_behaviour.mp4
308 KB View Download
►

Sign in to add a comment