New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841719 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 842476
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary Playstore text is seen in the header of Playstore window

Project Member Reported by kebalaji@chromium.org, May 10 2018

Issue description

Chrome Version:68.0.3425.0/10663.0.0 dev-channel Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Open playstore app and observe

Actual: Unnecessary Playstore text is seen in the header of Playstore window
Expected: No such issue should be seen

This is a Regression issue as same is working fine in 68.0.3423.0/10657.0.0 dev

@Khmel: Please confirm the issue

NOTE: Issue is seen for all the playstore installed apps too
 
ActualPlaystoretext.png
1.8 MB View Download
ExpectedPlaystoretext.png
1.6 MB View Download
Description: Show this description

Comment 2 by khmel@chromium.org, May 10 2018

Cc: skuhne@chromium.org
Owner: phshah@chromium.org
To WM experts

Comment 3 by skuhne@chromium.org, May 11 2018

Cc: osh...@chromium.org
Owner: osh...@chromium.org
As the Caption is being drawn now by chrome, this is clearly a Chrome bug.

Comment 4 by osh...@chromium.org, May 14 2018

Cc: shihuis@chromium.org
Owner: mukai@chromium.org
mukai@ I thought this was fixed. Can you look into it?

Comment 5 by mukai@chromium.org, May 14 2018

Mergedinto: 842476
Status: Duplicate (was: Assigned)
This is a regression.  Issue 842476  is tracking the same thing.

Comment 6 by est...@chromium.org, May 22 2018

Owner: est...@chromium.org
Status: Assigned (was: Duplicate)

Comment 7 by mukai@chromium.org, May 24 2018

Let me note that the reported behavior itself was already fixed along with Issue 842676 -- but some additional behavior is slightly different when debugging mode is turned on, which is why estade reopened/self-assigned at #c6.

Comment 8 by mukai@chromium.org, May 24 2018

Oops,  Issue 842476 , typo :-/
Project Member

Comment 9 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d

commit 42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d
Author: Evan Stade <estade@chromium.org>
Date: Thu May 31 16:37:09 2018

Only show extra title in ARC windows when extra title is set.

Don't also show the normal window title.

Bug:  841719 
Change-Id: Ib0a40b958feed1389fe3177c8a5185b43c0bb198
Reviewed-on: https://chromium-review.googlesource.com/1069321
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563272}
[modify] https://crrev.com/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d/ash/frame/custom_frame_view_ash.h
[modify] https://crrev.com/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d/ash/frame/frame_header.cc
[modify] https://crrev.com/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d/ash/frame/frame_header.h
[modify] https://crrev.com/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d/ash/frame/header_view.cc
[modify] https://crrev.com/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d/ash/frame/header_view.h
[modify] https://crrev.com/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d/components/exo/client_controlled_shell_surface_unittest.cc
[modify] https://crrev.com/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d/components/exo/shell_surface_base.cc
[modify] https://crrev.com/42fdc49a4d023b2c5878e1f6a09d4e9b6c0a056d/components/exo/shell_surface_base.h

Status: Fixed (was: Assigned)

Sign in to add a comment