New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841716 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

Regression: Unnecessary disabled full screen button is seen for recorded videos in Camera app

Project Member Reported by rkalavakuntla@chromium.org, May 10 2018

Issue description

Chrome Version:68.0.3245.0/10663.0.0 dev-channel Daisy,Candy,Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Open Camera app >> Do a sample video recording 
(2)go to Gallery >>Double click on the recording to open and observe

Actual:Unnecessary disabled full screen button is seen for recorded videos 
Expected: No such unnecessary disabled full screen button should be seen

This is a Regression issue seen as same is working fine in 66.0.3359.158/10452.85.0 stable

Note:
1.Issue is also seen in M-67 beta
2.Issue is not seen in Linux,Windows OS

Attached the screencast for reference..

@Yuli: Please confirm the behavior

 
Actual.jpg
3.7 MB View Download
Expecetd.jpg
4.6 MB View Download
Actual.mp4
12.1 MB View Download

Comment 1 by y...@chromium.org, May 10 2018

Cc: conradlo@chromium.org shenchao@chromium.org
shenchao@, it might be a regression from Chrome's video player?

Comment 2 by y...@chromium.org, May 11 2018

Cc: -shenchao@chromium.org shenghao@chromium.org
shenghao@, it might be a regression from Chrome's video player?
Seems that it's broken between 67 and 66.
Conrad, could you route this bug to video player team?
Cc: y...@chromium.org hiroh@chromium.org
Owner: posciak@chromium.org
Pawel/Hiro, do you know who owns this?

Comment 5 by hiroh@chromium.org, May 11 2018

How do we do full-screen in the expected one? I think we can't.
So looks just video player style change.
If we would like to enable full-screen, there should be the flag to video-player to enable full-screen.

Comment 6 by y...@chromium.org, May 11 2018

Camera app explicitly disabled the fullscreen by 'video.setAttribute('controlsList', 'nodownload nofullscreen').'

However, 67 seems no longer respecting the 'nofullscreen' attribute settings.
Owner: fukino@chromium.org
Status: Untriaged (was: Assigned)
fukino@: would you perhaps be able to triage this issue please? Thank you!
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Cc: fukino@chromium.org
Components: Blink>Media>Controls Blink>Media>Video
Owner: steimel@chromium.org
According to comment #6, controlList="nofullscreen" does not hide the fullscreen button in video tag control.

steimel@, is this a know issue?
Cc: mlamouri@chromium.org steimel@chromium.org
Owner: amyroberts@chromium.org
This was an intentional change to never hide the fullscreen and only disable it. However, I think we made that change mostly for the preload="none" -> metadata loaded transition where the mute and fullscreen buttons would just appear, and we wanted to keep things from moving around. Since in the case of controlsList="nofullscreen" we'll never have a fullscreen button, it might be worth hiding.

+amyroberts@ to make a UI decision on this.

Sign in to add a comment