New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841714 link

Starred by 5 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
█ spqc...@chromium.org
█ manoranj...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Touch-bar panel is not seen on MAC Touch-Bar.

Reported by shruti.j...@etouch.net, May 10 2018 
Chrome Version: 68.0.3426.0 (Official Build) (64-bit)Revision ccd67e9feb61a58dd00a63b10cc08a36db957cba-refs/branch-heads/3426@{#1}
OS:Mac(10.13.5)

Pre-Condition:Enable 'Use Views browser windows instead of Cocoa'from chrome://flags.

Steps to reproduce:
1.Launch chrome and observe the Macbook touchbar panel

Actual Result : Macbook touchbar panel is not seen on MAC Touch-bar after enabling the above mentioned flag.
Expected Result :Macbook touchbar panel should be seen even after enabling the above mention flag.

This is a Non-regression issue seen from ‘M-67’ series(#67.0.3381.0)

Note:
1.Issue is MAC Specific only.
2.Touch panel is seen when flag is set to 'Default' the issue is seen only after enabling the flag.

Kindly review the attached screen-cast from the drive link (https://drive.google.com/open?id=1qWDSdJ2NX0ks38cda2yffGruMxGPRqq4) .

Thank You!

Comment 1 by rbasuvula@chromium.org, May 10 2018

Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!

Comment 2 by manoranj...@chromium.org, May 10 2018

Cc: ellyjo...@chromium.org

Comment 3 by spqc...@chromium.org, May 10 2018

Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by spqc...@chromium.org, May 30 2018

Status: Started (was: Assigned)

Comment 5 by spqc...@chromium.org, May 30 2018

Labels: Proj-MacViews
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eea870b8ecd2123ccf364b04f1f09b50fccddb8

commit 1eea870b8ecd2123ccf364b04f1f09b50fccddb8
Author: spqchan <spqchan@chromium.org>
Date: Fri Jun 08 06:13:36 2018

Remove Cocoa Dependency from BrowserWindowTouchBar

To make the BrowserWindowTouchBar available to MacViews,
modify the class so that it no longer depends on Cocoa
code to receive updates for the touch bar item states.

This CL converts BookmarkTabHelperDelegate to
BookmarkTabHelperObserver so that BrowserWindowTouchBar
can observe the current web contents for starred changes.

Overview CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1086867

Bug:  841714 
Change-Id: Id8944ad085d87288bcda767a53bb1abfe5c0eab9
Reviewed-on: https://chromium-review.googlesource.com/1090315
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565570}
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/bookmarks/bookmark_browsertest.cc
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/bookmarks/bookmark_tab_helper.h
[delete] https://crrev.com/c85e64e9f0b9258712c4a9bed5bfb70aa546d639/chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.cc
[rename] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/bookmarks/bookmark_tab_helper_observer.h
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/browser.cc
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/browser.h
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/cocoa/browser_window_touch_bar.h
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/cocoa/browser_window_touch_bar_browsertest.mm
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/exclusive_access/fullscreen_controller.cc
[modify] https://crrev.com/1eea870b8ecd2123ccf364b04f1f09b50fccddb8/chrome/browser/ui/exclusive_access/fullscreen_controller.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1836139435bfc124ffecbc2bda60ae8e31371166

commit 1836139435bfc124ffecbc2bda60ae8e31371166
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Jun 08 09:32:44 2018

Revert "Remove Cocoa Dependency from BrowserWindowTouchBar"

This reverts commit 1eea870b8ecd2123ccf364b04f1f09b50fccddb8.

Reason for revert: Consistent failures on Mac10.10 Tests in
BrowserWindowTouchBarUnitTest.BackForwardCommandUpdate
BrowserWindowTouchBarUnitTest.TouchBarItems
BrowserWindowTouchBarUnitTest.ReloadOrStopTouchBarIte
since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/32927 which introduced this change.

Original change's description:
> Remove Cocoa Dependency from BrowserWindowTouchBar
> 
> To make the BrowserWindowTouchBar available to MacViews,
> modify the class so that it no longer depends on Cocoa
> code to receive updates for the touch bar item states.
> 
> This CL converts BookmarkTabHelperDelegate to
> BookmarkTabHelperObserver so that BrowserWindowTouchBar
> can observe the current web contents for starred changes.
> 
> Overview CL:
> https://chromium-review.googlesource.com/c/chromium/src/+/1086867
> 
> Bug:  841714 
> Change-Id: Id8944ad085d87288bcda767a53bb1abfe5c0eab9
> Reviewed-on: https://chromium-review.googlesource.com/1090315
> Commit-Queue: Sarah Chan <spqchan@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565570}

TBR=ellyjones@chromium.org,spqchan@chromium.org

Change-Id: Ib94fb94b70fbbd103ea73c570577e728e4e96b2d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  841714 
Reviewed-on: https://chromium-review.googlesource.com/1092538
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565594}
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/bookmarks/bookmark_browsertest.cc
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/bookmarks/bookmark_tab_helper.h
[add] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.cc
[rename] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.h
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/browser.cc
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/browser.h
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/cocoa/browser_window_touch_bar.h
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/cocoa/browser_window_touch_bar_browsertest.mm
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/exclusive_access/fullscreen_controller.cc
[modify] https://crrev.com/1836139435bfc124ffecbc2bda60ae8e31371166/chrome/browser/ui/exclusive_access/fullscreen_controller.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0aecdf533a150ca2867efb7cd55e1ef47378a39

commit b0aecdf533a150ca2867efb7cd55e1ef47378a39
Author: spqchan <spqchan@chromium.org>
Date: Mon Jun 11 20:16:09 2018

Reland "Remove Cocoa Dependency from BrowserWindowTouchBar"

This is a reland of the CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1086867

The CL was reverted because of test failures in
Mac OSX 10.10. This CL fixes those issues.

Bug:  841714 
Change-Id: Ib5ecd6494f4818540eff180b69103eb93a8b8f70
Reviewed-on: https://chromium-review.googlesource.com/1094259
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566123}
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/bookmarks/bookmark_browsertest.cc
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/bookmarks/bookmark_tab_helper.h
[delete] https://crrev.com/bb251ffbd5d5ca1155b030ec23e417ca16b28481/chrome/browser/ui/bookmarks/bookmark_tab_helper_delegate.cc
[rename] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/bookmarks/bookmark_tab_helper_observer.h
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/browser.cc
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/browser.h
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/cocoa/browser_window_controller.h
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/cocoa/browser_window_touch_bar.h
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/cocoa/browser_window_touch_bar_browsertest.mm
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/exclusive_access/fullscreen_controller.cc
[modify] https://crrev.com/b0aecdf533a150ca2867efb7cd55e1ef47378a39/chrome/browser/ui/exclusive_access/fullscreen_controller.h

Comment 9 by spqc...@chromium.org, Jun 19 2018

Cc: spqc...@chromium.org
 Issue 854269  has been merged into this issue.

Comment 10 by robliao@chromium.org, Jun 20 2018

Labels: -Target-68 Target-69
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1

commit f011f9bbd8d74e7bcef65baf2303b43a3f0371b1
Author: spqchan <spqchan@chromium.org>
Date: Fri Jun 22 04:48:33 2018

[MacViews] Hook Browser Window Touch Bar

Move browser_window_touch_bar.h/mm to
chrome/browser/ui so it can also be used by MacViews.

Introduced browser_window_touch_bar_delegate.h so that
it can serve as a bridge between BrowserWindowTouchBar
and NativeWidgetMacNSWindow. BrowserFrameMac will create
BrowserWindowTouchBar and pass the NSTouchBar to
NativeWidgetMacNSWindow.

Bug:  841714 
Change-Id: I059e8cb2f91bc6fad73393cfb1a59802398bccc9
Reviewed-on: https://chromium-review.googlesource.com/1106599
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569531}
[modify] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/chrome/browser/ui/BUILD.gn
[rename] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/chrome/browser/ui/browser_window_touch_bar_mac.h
[rename] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/chrome/browser/ui/browser_window_touch_bar_mac.mm
[modify] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/chrome/browser/ui/cocoa/browser_window_touch_bar_browsertest.mm
[modify] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm
[modify] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/chrome/browser/ui/cocoa/framed_browser_window.mm
[modify] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/chrome/browser/ui/views/frame/browser_frame_mac.h
[modify] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/chrome/browser/ui/views/frame/browser_frame_mac.mm
[modify] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/ui/views/BUILD.gn
[modify] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/ui/views/cocoa/native_widget_mac_nswindow.h
[modify] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/ui/views/cocoa/native_widget_mac_nswindow.mm
[add] https://crrev.com/f011f9bbd8d74e7bcef65baf2303b43a3f0371b1/ui/views/cocoa/window_touch_bar_delegate.h

Comment 12 by spqc...@chromium.org, Jun 25 2018

Status: Fixed (was: Started)

Comment 13 by aiman.an...@etouch.net, Jul 16

Labels: TE-Verified-69.0.3493.0 TE-Verified-M69
Hi,

Retested the above issue on Mac(10.13.6 Touchbar) using latest canary build #69.0.3493.0 and Issue is fixed.

Able to see touch-bar panel when MacViews flag is Enabled.

Kindly refer the screen-cast for reference from below link.

https://drive.google.com/drive/folders/1q_47FqmVwPcr37IBiJhA7KNwEbQpuIu8?usp=sharing

Thank You!
►

Sign in to add a comment