Search download icon gets hide on resizing the browser on chrome://downloads page.
Reported by
dchau...@etouch.net,
May 10 2018
|
|||||||
Issue descriptionChrome Version: 66.0.3359.170 (Official Build) Revision 30c511add11ae3d417d1ca5e010152fce57fa128-refs/branch-heads/3359@{#814} 32/64-bit. OS: Windows (7,8,8.1,10),Linux (14.04 LTS) & Mac OS X(10.12.6,10.13.1,10.13.5). What steps will reproduce the problem? 1. Launch Chrome and navigate to chrome://downloads page. 2. Now resize the browser from RHS to LHS and observe the search download icon at header. Actual: Search download icon gets hide on resizing the browser. Expected: Search download icon should not hide on resizing the browser. NOTE: Search icon doesn’t get hide on chrome://settings, chrome://history and chrome://bookmarks page even horizontal scroll bar appears on chrome://settings and chrome://history page. This is a non-regression issue, seen from M-60 series. Note: Issue is also seen on M-67 Beta (build #67.0.3396.40),M-68 Dev (build #68.0.3423.2) and M-68 Canary (build #68.0.3425.0) Kindly review the attached screen-cast for reference.
,
May 10 2018
michaelpg@ - Do you know if there is a general owner for the WebUI pages or would this still fall under us (Downloads)? Thanks!
,
May 10 2018
Since this is using cr-toolbar, it might make sense for dpapad's team to take a look (if we decide it should be fixed). the icon isn't being "hidden" AFAICT, the page just has a minimum width, so I'd argue this is WAI at least to some extent.
,
May 10 2018
The History and Downloads pages have different min-width specified. Even though the search icon gets hidden, there is a scrollbar appearing at the bottom, allowing the user to still get to the search icon button, see screenshot. Reducing priority since this is not preventing the user from reaching any functionality, just a matter of polish and consistency between WebUI pages.
,
Jul 3
,
Jul 3
Screenshot for CL https://chromium-review.googlesource.com/c/chromium/src/+/1124982.
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a76b5ec55bca210fa0601a64e9724bf1dd528961 commit a76b5ec55bca210fa0601a64e9724bf1dd528961 Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Jul 11 20:46:22 2018 Downloads WebUI: allow toolbar to resize along with decreased window widths Bug: 841708 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iae485cc912bed7bcbb3ebd6e435c5f3d0208a550 Reviewed-on: https://chromium-review.googlesource.com/1124982 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#574319} [modify] https://crrev.com/a76b5ec55bca210fa0601a64e9724bf1dd528961/chrome/browser/resources/md_downloads/manager.html
,
Jul 11
,
Jul 12
Update: Rechecked the above issue on Win (7,8,8.1,10), Mac OS X (10.12.6,10.13.1,10.13.6) & Linux (14.04 LTS) machines using latest canary #69.0.3489.0 and issue is fixed. Hence adding TE-Verified labels. please refer below attached screen-cast for reference. Thank You. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rbasuvula@chromium.org
, May 10 2018