New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841693 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: May 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ scottchen@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unable to Enable/Disable toggle buttons through 'Spacebar' key on chrome://extensions

Reported by avsha...@etouch.net, May 10 2018 
Chrome Version : 68.0.3426.0 (Official Build) ccd67e9feb61a58dd00a63b10cc08a36db957cba-refs/branch-heads/3426@{#1} 32/64-bit
OS : Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://extensions page.
2. Click on the toggle button of any extension and hit 'Spacebar' from keyboard.
3. Observe.

Actual Result : Unable to enable/disable toggle buttons through 'Spacebar' key after clicking on it.

Expected Result : Spacebar key should work as expected for all toggle buttons on chrome://extensions page

This is a regression issue, broken in M-68 and will soon update other details.
Actual_Result.mp4
280 KB View Download
Expected_Result.mp4
296 KB View Download

Comment 1 by avsha...@etouch.net, May 10 2018

Labels: hasbisect-per-revision RegressedIn-68 ET-MUM-Reported FoundIn-68 Target-68 OS-Linux OS-Mac
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-68 and providing the bisect using Per-Revision script:
Good Build : 68.0.3418.0 (Revision : 555652)
Bad Build : 68.0.3419.0 (Revision : 555962)

You are probably looking for a change made after 555943 (known good), but no later than 555944 (first known bad).

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/b68698e6c0c71af8f3b667ad547fc9d7ca2d1ef3..79985f94e043bd4de3f3652a19f4b7698291cdd7

Suspect : https://chromium.googlesource.com/chromium/src/+/79985f94e043bd4de3f3652a19f4b7698291cdd7

@dpapad : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Issue is also observed in Mac(10.12.6, 10.13.1, 10.13.5) and Linux(14.04 LTS) OS

Comment 2 by dpa...@chromium.org, May 14 2018

Components: -UI>Browser>ExtensionsManagement UI>Browser>WebUI
I am able to reproduce this. Also happens in Settings, and anywhere where cr-toggle is used. Investigating.

Comment 3 by dpa...@chromium.org, May 14 2018

Cc: scottchen@chromium.org
Status: Started (was: Assigned)
This also happens on cr-checkbox.
Project Member

Comment 4 by bugdroid1@chromium.org, May 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dd6975d66203e2e566d1fe2a4113a519153996f

commit 4dd6975d66203e2e566d1fe2a4113a519153996f
Author: dpapad <dpapad@chromium.org>
Date: Tue May 15 19:49:07 2018

WebUI cr-toggle/cr-checkbox: Fix case where space toggles twice.

It was possible for the user to focus the inner <button> element via click
(otherwise button has tabindex -1). After that, pressing 'Space' once would
trigger both 'click' and 'keypress' toggling the state twice.

Bug:  841693 , 840723 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If1200b6d39ac3eb4d6dc44e5622b75ed7f8beab8
Reviewed-on: https://chromium-review.googlesource.com/1058249
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558811}
[modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/chrome/test/data/webui/cr_elements/cr_checkbox_test.js
[modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js
[modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/chrome/test/data/webui/cr_elements/cr_elements_focus_test.js
[modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/chrome/test/data/webui/cr_elements/cr_toggle_test.js
[modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html
[modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.js
[modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.html
[modify] https://crrev.com/4dd6975d66203e2e566d1fe2a4113a519153996f/ui/webui/resources/cr_elements/cr_toggle/cr_toggle.js

Comment 5 by dpa...@chromium.org, May 15 2018

Status: Fixed (was: Started)
►

Sign in to add a comment