New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841671 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

Log Apps as a key for UKM metrics

Project Member Reported by pdyson@chromium.org, May 10 2018

Issue description

Allow logging of Chrome apps, ARC++ apps, PWAs and Crostini apps with UKM.

The apps will be the key for the logging of other metrics.

See doc: go/cros-apps-ukm

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36ee0ad7558682953cebfcab4caeba4b6a196e9e

commit 36ee0ad7558682953cebfcab4caeba4b6a196e9e
Author: Paul Dyson <pdyson@chromium.org>
Date: Mon Jun 25 02:53:24 2018

Add a new scheme for logging apps in UKM.

Add the scheme "app" for logging apps.

Bug: 841671
Change-Id: I05af14327dba5ad422b9784205229f914641aa1a
Reviewed-on: https://chromium-review.googlesource.com/1053342
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569952}
[modify] https://crrev.com/36ee0ad7558682953cebfcab4caeba4b6a196e9e/components/ukm/ukm_recorder_impl.cc
[modify] https://crrev.com/36ee0ad7558682953cebfcab4caeba4b6a196e9e/components/ukm/ukm_service_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00c4ceddeedea41dc8484c42ef803c74d0b359b4

commit 00c4ceddeedea41dc8484c42ef803c74d0b359b4
Author: Paul Dyson <pdyson@chromium.org>
Date: Mon Jun 25 04:06:47 2018

Add mechanism for logging App ids in UKM.

Allow a SourceId to be obtained and the url set to
app://[chrome|play]/id.

Add a new SourceType to govern the creation of urls
with scheme "app".

Bug: 841671
Change-Id: I1ed98722cdeb78ffd9944548901089e28f64181a
Reviewed-on: https://chromium-review.googlesource.com/1058736
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569962}
[modify] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/components/ukm/content/BUILD.gn
[add] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/components/ukm/content/app_source_url_recorder.cc
[add] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/components/ukm/content/app_source_url_recorder.h
[add] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/components/ukm/content/app_source_url_recorder_test.cc
[modify] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/components/ukm/ukm_recorder_impl.cc
[modify] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/components/ukm/ukm_recorder_impl.h
[modify] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/services/metrics/public/cpp/delegating_ukm_recorder.cc
[modify] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/services/metrics/public/cpp/delegating_ukm_recorder.h
[modify] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/services/metrics/public/cpp/mojo_ukm_recorder.cc
[modify] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/services/metrics/public/cpp/mojo_ukm_recorder.h
[modify] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/services/metrics/public/cpp/ukm_recorder.h
[modify] https://crrev.com/00c4ceddeedea41dc8484c42ef803c74d0b359b4/services/metrics/public/cpp/ukm_source_id.h

Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment