New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 841669 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

remove force-clamshell-power-button

Project Member Reported by warx@chromium.org, May 10 2018

Issue description

It is not used in chrome. The cleanup needs both chrome and chromeos side work.

Create a bug so that it is tracked. Dan, assigned to you since you added it. But either me or Min can take it if you are busy.


 

Comment 1 by derat@chromium.org, May 10 2018

Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64

commit 64a85649d3d0aad028fdd4f74b3c9bc3ea853d64
Author: Daniel Erat <derat@chromium.org>
Date: Thu May 10 17:50:06 2018

ash: Remove --force-clamshell-power-button.

Remove the --force-clamshell-power-button switch and related
code from ash. This is no longer used starting with M67.

Bug:  841669 
Change-Id: Ifca6c0757f4dd077973b489b58030388251f250d
Reviewed-on: https://chromium-review.googlesource.com/1053565
Reviewed-by: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557575}
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/public/cpp/ash_features.h
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/system/power/power_button_controller.cc
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/system/power/power_button_controller.h
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/system/power/power_button_controller_test_api.cc
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/system/power/power_button_controller_test_api.h
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/system/power/power_button_controller_unittest.cc
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/system/power/power_button_test_base.cc
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/system/power/power_button_test_base.h
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/chrome/browser/about_flags.cc
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/64a85649d3d0aad028fdd4f74b3c9bc3ea853d64/chrome/browser/flag_descriptions.h

Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/bacb8f7193fccc60c96e13b83fd21034874ba0e0

commit bacb8f7193fccc60c96e13b83fd21034874ba0e0
Author: Daniel Erat <derat@chromium.org>
Date: Fri May 11 19:10:52 2018

login: Stop passing various obsolete switches to Chrome.

Make session_manager stop passing various seemingly-unneeded
switches to Chrome:

  --force-clamshell-power-button (unused starting at M67)
  --enable-features=QuickUnlockPin (on by default in Chrome)
  --oobe-bootstrapping-slave (no longer exists in Chrome)
  --vmodule=tablet_power_button_controller=1 (736936 closed)
  --vmodule=automatic_reboot_manager=1 (b:69546724 closed)
  --vmodule=arc_kiosk*=2 (812594 closed)
  --vmodule=*zygote*=1,*plugin*=2 (314301 closed)

BUG= chromium:841669 , chromium:736936 ,chromium:812594,chromium:314301,b:69546724
TEST=none

Change-Id: Idc402edd68c831e958372afbdc988ced732f82d1
Reviewed-on: https://chromium-review.googlesource.com/1053566
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/bacb8f7193fccc60c96e13b83fd21034874ba0e0/login_manager/chrome_setup.cc

Comment 4 by derat@chromium.org, May 11 2018

Status: Fixed (was: Started)

Sign in to add a comment