"ParallelDownloadTest.NoPartialResponse" is flaky |
|||
Issue description"ParallelDownloadTest.NoPartialResponse" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMQsSBUZsYWtlIiZQYXJhbGxlbERvd25sb2FkVGVzdC5Ob1BhcnRpYWxSZXNwb25zZQw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/130774334da28312cc7f9fbbdecd8ad3bed9f9ee commit 130774334da28312cc7f9fbbdecd8ad3bed9f9ee Author: Yutaka Hirano <yhirano@chromium.org> Date: Thu May 10 10:17:56 2018 Revert "Cancel parallel download request if server doesn't send partial response" This reverts commit 189d1033d966ab0795e5391c2c56838a7f4ce64a. Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666. Original change's description: > Cancel parallel download request if server doesn't send partial response > > If the server doesn't support partial responses, Chrome should cancel > parallel download requests. > These requests result in the wrong write offset and makes the file larger > than the original > > BUG= 838627 > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba > Reviewed-on: https://chromium-review.googlesource.com/1048130 > Commit-Queue: Min Qin <qinmin@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557252} TBR=qinmin@chromium.org,xingliu@chromium.org Change-Id: I995c3c48fe39c535275a353130b10204009c5e30 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838627 , 841666 Reviewed-on: https://chromium-review.googlesource.com/1053470 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#557489} [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/components/download/internal/common/download_file_impl.cc [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/components/download/internal/common/download_file_unittest.cc [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/components/download/internal/common/download_item_impl.cc [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/components/download/internal/common/download_job_factory.cc [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/components/download/internal/common/download_worker.cc [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/components/download/internal/common/download_worker.h [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/components/download/internal/common/parallel_download_job.cc [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/components/download/internal/common/parallel_download_job.h [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/components/download/internal/common/parallel_download_job_unittest.cc [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/content/browser/download/download_browsertest.cc [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/content/public/test/test_download_http_response.cc [modify] https://crrev.com/130774334da28312cc7f9fbbdecd8ad3bed9f9ee/content/public/test/test_download_http_response.h
,
May 10 2018
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05267e5edb3a2e33fcbb969a4318b0bd117d19b7 commit 05267e5edb3a2e33fcbb969a4318b0bd117d19b7 Author: Min Qin <qinmin@chromium.org> Date: Fri May 11 00:09:36 2018 Reland "Cancel parallel download request if server doesn't send partial response" This reverts commit 130774334da28312cc7f9fbbdecd8ad3bed9f9ee. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Cancel parallel download request if server doesn't send partial response" > > This reverts commit 189d1033d966ab0795e5391c2c56838a7f4ce64a. > > Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666. > > Original change's description: > > Cancel parallel download request if server doesn't send partial response > > > > If the server doesn't support partial responses, Chrome should cancel > > parallel download requests. > > These requests result in the wrong write offset and makes the file larger > > than the original > > > > BUG= 838627 > > > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba > > Reviewed-on: https://chromium-review.googlesource.com/1048130 > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#557252} > > TBR=qinmin@chromium.org,xingliu@chromium.org > > Change-Id: I995c3c48fe39c535275a353130b10204009c5e30 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 838627 , 841666 > Reviewed-on: https://chromium-review.googlesource.com/1053470 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557489} TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org Change-Id: I47a2d4131efa8b863d9868eeca74e99d7beeaa8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838627 , 841666 Reviewed-on: https://chromium-review.googlesource.com/1054887 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557734} [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/components/download/internal/common/download_file_impl.cc [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/components/download/internal/common/download_file_unittest.cc [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/components/download/internal/common/download_item_impl.cc [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/components/download/internal/common/download_job_factory.cc [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/components/download/internal/common/download_worker.cc [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/components/download/internal/common/download_worker.h [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/components/download/internal/common/parallel_download_job.cc [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/components/download/internal/common/parallel_download_job.h [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/components/download/internal/common/parallel_download_job_unittest.cc [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/content/browser/download/byte_stream_input_stream.cc [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/content/browser/download/byte_stream_input_stream.h [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/content/browser/download/download_browsertest.cc [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/content/public/test/test_download_http_response.cc [modify] https://crrev.com/05267e5edb3a2e33fcbb969a4318b0bd117d19b7/content/public/test/test_download_http_response.h
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e127247ef7e8c02498522c5e2e507cc8b39af278 commit e127247ef7e8c02498522c5e2e507cc8b39af278 Author: Max Morin <maxmorin@chromium.org> Date: Fri May 11 10:12:39 2018 Revert "Reland "Cancel parallel download request if server doesn't send partial response"" This reverts commit 05267e5edb3a2e33fcbb969a4318b0bd117d19b7. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Cancel parallel download request if server doesn't send partial response" > > This reverts commit 130774334da28312cc7f9fbbdecd8ad3bed9f9ee. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "Cancel parallel download request if server doesn't send partial response" > > > > This reverts commit 189d1033d966ab0795e5391c2c56838a7f4ce64a. > > > > Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666. > > > > Original change's description: > > > Cancel parallel download request if server doesn't send partial response > > > > > > If the server doesn't support partial responses, Chrome should cancel > > > parallel download requests. > > > These requests result in the wrong write offset and makes the file larger > > > than the original > > > > > > BUG= 838627 > > > > > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba > > > Reviewed-on: https://chromium-review.googlesource.com/1048130 > > > Commit-Queue: Min Qin <qinmin@chromium.org> > > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#557252} > > > > TBR=qinmin@chromium.org,xingliu@chromium.org > > > > Change-Id: I995c3c48fe39c535275a353130b10204009c5e30 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 838627 , 841666 > > Reviewed-on: https://chromium-review.googlesource.com/1053470 > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#557489} > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org > > Change-Id: I47a2d4131efa8b863d9868eeca74e99d7beeaa8e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 838627 , 841666 > Reviewed-on: https://chromium-review.googlesource.com/1054887 > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557734} TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org Change-Id: I7a618b9533229ea1bb97ff65470e9c60fe580a49 No-Try: true Bug: 838627 , 841666 Reviewed-on: https://chromium-review.googlesource.com/1053729 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557834} [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/components/download/internal/common/download_file_impl.cc [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/components/download/internal/common/download_file_unittest.cc [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/components/download/internal/common/download_item_impl.cc [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/components/download/internal/common/download_job_factory.cc [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/components/download/internal/common/download_worker.cc [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/components/download/internal/common/download_worker.h [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/components/download/internal/common/parallel_download_job.cc [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/components/download/internal/common/parallel_download_job.h [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/components/download/internal/common/parallel_download_job_unittest.cc [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/content/browser/download/byte_stream_input_stream.cc [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/content/browser/download/byte_stream_input_stream.h [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/content/browser/download/download_browsertest.cc [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/content/public/test/test_download_http_response.cc [modify] https://crrev.com/e127247ef7e8c02498522c5e2e507cc8b39af278/content/public/test/test_download_http_response.h
,
May 11 2018
TSan found a UAF, looks like the TestRequestPauseHandler is used after free:
WARNING: ThreadSanitizer: use of an invalid mutex (e.g. uninitialized or destroyed) (pid=242265)
#0 pthread_mutex_lock /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:4027:3 (content_browsertests+0x5e94de)
#1 base::internal::LockImpl::Lock() base/synchronization/lock_impl_posix.cc:102:12 (libbase.so+0x2948d5)
#2 Acquire base/synchronization/lock.h:45:11 (libbase.so+0x1b9715)
#3 AutoLock base/synchronization/lock.h:115 (libbase.so+0x1b9715)
#4 base::SequenceCheckerImpl::CalledOnValidSequence() const base/sequence_checker_impl.cc:40 (libbase.so+0x1b9715)
#5 running base/run_loop.h:84:5 (content_browsertests+0x77feea)
#6 content::(anonymous namespace)::TestRequestPauseHandler::OnPauseHandler(base::RepeatingCallback<void ()> const&) content/browser/download/download_browsertest.cc:703 (content_browsertests+0x77feea)
#7 Invoke<void (content::(anonymous namespace)::TestRequestPauseHandler::*)(const base::RepeatingCallback<void ()> &), content::(anonymous namespace)::TestRequestPauseHandler *, const base::RepeatingCallback<void ()> &> base/bind_internal.h:447:12 (content_browsertests+0x77ffef)
#8 MakeItSo<void (content::(anonymous namespace)::TestRequestPauseHandler::*const &)(const base::RepeatingCallback<void ()> &), content::(anonymous namespace)::TestRequestPauseHandler *, const base::RepeatingCallback<void ()> &> base/bind_internal.h:547 (content_browsertests+0x77ffef)
#9 RunImpl<void (content::(anonymous namespace)::TestRequestPauseHandler::*const &)(const base::RepeatingCallback<void ()> &), const std::__1::tuple<base::internal::UnretainedWrapper<content::(anonymous namespace)::TestRequestPauseHandler> > &, 0> base/bind_internal.h:621 (content_browsertests+0x77ffef)
#10 base::internal::Invoker<base::internal::BindState<void (content::(anonymous namespace)::TestRequestPauseHandler::*)(base::RepeatingCallback<void ()> const&), base::internal::UnretainedWrapper<content::(anonymous namespace)::TestRequestPauseHandler> >, void (base::RepeatingCallback<void ()> const&)>::Run(base::internal::BindStateBase*, base::RepeatingCallback<void ()> const&) base/bind_internal.h:603 (content_browsertests+0x77ffef)
#11 Run base/callback.h:136:12 (content_browsertests+0xc0fdbd)
#12 void base::internal::FunctorTraits<base::RepeatingCallback<void (base::RepeatingCallback<void ()> const&)>, void>::Invoke<base::RepeatingCallback<void (base::RepeatingCallback<void ()> const&)>, base::RepeatingCallback<void ()> >(base::RepeatingCallback<void (base::RepeatingCallback<void ()> const&)>&&, base::RepeatingCallback<void ()>&&) base/bind_internal.h:523 (content_browsertests+0xc0fdbd)
#13 MakeItSo<base::RepeatingCallback<void (const base::RepeatingCallback<void ()> &)>, base::RepeatingCallback<void ()> > base/bind_internal.h:547:12 (content_browsertests+0xc0fcbe)
#14 RunImpl<base::RepeatingCallback<void (const base::RepeatingCallback<void ()> &)>, std::__1::tuple<base::RepeatingCallback<void ()> >, 0> base/bind_internal.h:621 (content_browsertests+0xc0fcbe)
#15 base::internal::Invoker<base::internal::BindState<base::RepeatingCallback<void (base::RepeatingCallback<void ()> const&)>, base::RepeatingCallback<void ()> >, void ()>::RunOnce(base::internal::BindStateBase*) base/bind_internal.h:589 (content_browsertests+0xc0fcbe)
#16 Run base/callback.h:96:12 (libbase.so+0x1119eb)
#17 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:101 (libbase.so+0x1119eb)
#18 base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) base/message_loop/incoming_task_queue.cc:124:19 (libbase.so+0x1570de)
#19 base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:319:25 (libbase.so+0x15cac3)
#20 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:329:5 (libbase.so+0x15d3dc)
#21 base::MessageLoop::DoWork() base/message_loop/message_loop.cc:373:16 (libbase.so+0x15d775)
#22 HandleDispatch base/message_loop/message_pump_glib.cc:263:25 (libbase.so+0x162f97)
#23 base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) base/message_loop/message_pump_glib.cc:109 (libbase.so+0x162f97)
#24 g_main_context_dispatch <null> (libglib-2.0.so.0+0x4a7f6)
#25 base::MessageLoop::Run(bool) base/message_loop/message_loop.cc:271:12 (libbase.so+0x15c1b7)
#26 non-virtual thunk to base::MessageLoop::Run(bool) base/message_loop/message_loop.cc (libbase.so+0x15c2a4)
#27 base::RunLoop::Run() base/run_loop.cc:131:14 (libbase.so+0x1b28bf)
#28 base::RunLoop::RunUntilIdle() base/run_loop.cc:144:3 (libbase.so+0x1b30a8)
#29 content::Shell::CloseAllWindows() content/shell/browser/shell.cc:170:19 (content_browsertests+0x124ad73)
#30 content::ContentBrowserTest::PostRunTestOnMainThread() content/public/test/content_browser_test.cc:153:3 (content_browsertests+0x114ceca)
#31 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:410:3 (content_browsertests+0x115f24a)
#32 Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase *> base/bind_internal.h:447:12 (content_browsertests+0x1160368)
#33 MakeItSo<void (content::BrowserTestBase::*const &)(), content::BrowserTestBase *> base/bind_internal.h:547 (content_browsertests+0x1160368)
#34 RunImpl<void (content::BrowserTestBase::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase> > &, 0> base/bind_internal.h:621 (content_browsertests+0x1160368)
#35 base::internal::Invoker<base::internal::BindState<void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase> >, void ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:603 (content_browsertests+0x1160368)
#36 Run base/callback.h:125:12 (content_browsertests+0x124f50c)
#37 content::ShellBrowserMainParts::PreMainMessageLoopRun() content/shell/browser/shell_browser_main_parts.cc:202 (content_browsertests+0x124f50c)
#38 content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:959:13 (libcontent.so+0x14647b0)
#39 Invoke<int (content::BrowserMainLoop::*)(), content::BrowserMainLoop *> base/bind_internal.h:447:12 (libcontent.so+0x1467f28)
#40 MakeItSo<int (content::BrowserMainLoop::*const &)(), content::BrowserMainLoop *> base/bind_internal.h:547 (libcontent.so+0x1467f28)
#41 RunImpl<int (content::BrowserMainLoop::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserMainLoop> > &, 0> base/bind_internal.h:621 (libcontent.so+0x1467f28)
#42 base::internal::Invoker<base::internal::BindState<int (content::BrowserMainLoop::*)(), base::internal::UnretainedWrapper<content::BrowserMainLoop> >, int ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:603 (libcontent.so+0x1467f28)
#43 Run base/callback.h:125:12 (libcontent.so+0x1c1561a)
#44 content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:44 (libcontent.so+0x1c1561a)
#45 content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:870:25 (libcontent.so+0x1462bfa)
#46 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) content/browser/browser_main_runner_impl.cc:148:15 (libcontent.so+0x1468521)
#47 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner_impl.cc:66:10 (libcontent.so+0x1468430)
#48 ShellBrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserMainRunner, std::__1::default_delete<content::BrowserMainRunner> > const&) content/shell/browser/shell_browser_main.cc:22:32 (content_browsertests+0x124e9ea)
#49 content::ShellMainDelegate::RunProcess(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&) content/shell/app/shell_main_delegate.cc:333:16 (content_browsertests+0x11d3642)
#50 content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) content/app/content_main_runner_impl.cc:605:31 (libcontent.so+0x253d012)
#51 content::ContentMainRunnerImpl::Run() content/app/content_main_runner_impl.cc:959:12 (libcontent.so+0x253e49e)
#52 content::ContentServiceManagerMainDelegate::RunEmbedderProcess() content/app/content_service_manager_main_delegate.cc:51:32 (libcontent.so+0x253a82f)
#53 service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:459:29 (libembedder.so+0x259c0)
#54 content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 (libcontent.so+0x253bc7e)
#55 content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:323:3 (content_browsertests+0x115ea73)
#56 content::ContentBrowserTest::SetUp() content/public/test/content_browser_test.cc:100:20 (content_browsertests+0x114cbfb)
#57 testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc (content_browsertests+0xfce86b)
#58 testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11 (content_browsertests+0xfcfa4c)
#59 testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28 (content_browsertests+0xfd02c6)
#60 testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43 (content_browsertests+0xfe0866)
#61 testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc (content_browsertests+0xfe016b)
#62 RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 (content_browsertests+0x11bac66)
#63 base::TestSuite::Run() base/test/test_suite.cc:275 (content_browsertests+0x11bac66)
#64 content::ContentTestLauncherDelegate::RunTestSuite(int, char**) content/test/content_test_launcher.cc:108:48 (content_browsertests+0x115366b)
#65 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:625:31 (content_browsertests+0x11907e9)
#66 main content/test/content_test_launcher.cc:138:10 (content_browsertests+0x11535fd)
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6682345bfdc63949ff35f771cbde0ea90852202e commit 6682345bfdc63949ff35f771cbde0ea90852202e Author: Min Qin <qinmin@chromium.org> Date: Fri May 11 19:06:33 2018 Reland "Reland "Cancel parallel download request if server doesn't send partial response"" This reverts commit e127247ef7e8c02498522c5e2e507cc8b39af278. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Reland "Cancel parallel download request if server doesn't send partial response"" > > This reverts commit 05267e5edb3a2e33fcbb969a4318b0bd117d19b7. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Reland "Cancel parallel download request if server doesn't send partial response" > > > > This reverts commit 130774334da28312cc7f9fbbdecd8ad3bed9f9ee. > > > > Reason for revert: <INSERT REASONING HERE> > > > > Original change's description: > > > Revert "Cancel parallel download request if server doesn't send partial response" > > > > > > This reverts commit 189d1033d966ab0795e5391c2c56838a7f4ce64a. > > > > > > Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666. > > > > > > Original change's description: > > > > Cancel parallel download request if server doesn't send partial response > > > > > > > > If the server doesn't support partial responses, Chrome should cancel > > > > parallel download requests. > > > > These requests result in the wrong write offset and makes the file larger > > > > than the original > > > > > > > > BUG= 838627 > > > > > > > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba > > > > Reviewed-on: https://chromium-review.googlesource.com/1048130 > > > > Commit-Queue: Min Qin <qinmin@chromium.org> > > > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#557252} > > > > > > TBR=qinmin@chromium.org,xingliu@chromium.org > > > > > > Change-Id: I995c3c48fe39c535275a353130b10204009c5e30 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 838627 , 841666 > > > Reviewed-on: https://chromium-review.googlesource.com/1053470 > > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#557489} > > > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org > > > > Change-Id: I47a2d4131efa8b863d9868eeca74e99d7beeaa8e > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 838627 , 841666 > > Reviewed-on: https://chromium-review.googlesource.com/1054887 > > Reviewed-by: Min Qin <qinmin@chromium.org> > > Commit-Queue: Min Qin <qinmin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#557734} > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org > > Change-Id: I7a618b9533229ea1bb97ff65470e9c60fe580a49 > No-Try: true > Bug: 838627 , 841666 > Reviewed-on: https://chromium-review.googlesource.com/1053729 > Reviewed-by: Max Morin <maxmorin@chromium.org> > Commit-Queue: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557834} TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org,maxmorin@chromium.org Change-Id: I4a0d7eb869a61e38d01424427976121fe7f13384 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838627 , 841666 Reviewed-on: https://chromium-review.googlesource.com/1055710 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557969} [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/components/download/internal/common/download_file_impl.cc [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/components/download/internal/common/download_file_unittest.cc [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/components/download/internal/common/download_item_impl.cc [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/components/download/internal/common/download_job_factory.cc [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/components/download/internal/common/download_worker.cc [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/components/download/internal/common/download_worker.h [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/components/download/internal/common/parallel_download_job.cc [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/components/download/internal/common/parallel_download_job.h [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/components/download/internal/common/parallel_download_job_unittest.cc [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/content/browser/download/byte_stream_input_stream.cc [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/content/browser/download/byte_stream_input_stream.h [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/content/browser/download/download_browsertest.cc [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/content/public/test/test_download_http_response.cc [modify] https://crrev.com/6682345bfdc63949ff35f771cbde0ea90852202e/content/public/test/test_download_http_response.h
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1259cf8446247ad265dcbd611ec4bab7b91c9ba7 commit 1259cf8446247ad265dcbd611ec4bab7b91c9ba7 Author: Min Qin <qinmin@chromium.org> Date: Fri May 11 19:08:27 2018 Revert "Reland "Reland "Cancel parallel download request if server doesn't send partial response""" This reverts commit 6682345bfdc63949ff35f771cbde0ea90852202e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Reland "Cancel parallel download request if server doesn't send partial response"" > > This reverts commit e127247ef7e8c02498522c5e2e507cc8b39af278. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "Reland "Cancel parallel download request if server doesn't send partial response"" > > > > This reverts commit 05267e5edb3a2e33fcbb969a4318b0bd117d19b7. > > > > Reason for revert: <INSERT REASONING HERE> > > > > Original change's description: > > > Reland "Cancel parallel download request if server doesn't send partial response" > > > > > > This reverts commit 130774334da28312cc7f9fbbdecd8ad3bed9f9ee. > > > > > > Reason for revert: <INSERT REASONING HERE> > > > > > > Original change's description: > > > > Revert "Cancel parallel download request if server doesn't send partial response" > > > > > > > > This reverts commit 189d1033d966ab0795e5391c2c56838a7f4ce64a. > > > > > > > > Reason for revert: "ParallelDownloadTest.NoPartialResponse" is flaky. See https://crbug.com/841666. > > > > > > > > Original change's description: > > > > > Cancel parallel download request if server doesn't send partial response > > > > > > > > > > If the server doesn't support partial responses, Chrome should cancel > > > > > parallel download requests. > > > > > These requests result in the wrong write offset and makes the file larger > > > > > than the original > > > > > > > > > > BUG= 838627 > > > > > > > > > > Change-Id: I1fa878854579a1572e6e2f90f3bb932b59b333ba > > > > > Reviewed-on: https://chromium-review.googlesource.com/1048130 > > > > > Commit-Queue: Min Qin <qinmin@chromium.org> > > > > > Reviewed-by: Xing Liu <xingliu@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#557252} > > > > > > > > TBR=qinmin@chromium.org,xingliu@chromium.org > > > > > > > > Change-Id: I995c3c48fe39c535275a353130b10204009c5e30 > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 838627 , 841666 > > > > Reviewed-on: https://chromium-review.googlesource.com/1053470 > > > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > > > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#557489} > > > > > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org > > > > > > Change-Id: I47a2d4131efa8b863d9868eeca74e99d7beeaa8e > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 838627 , 841666 > > > Reviewed-on: https://chromium-review.googlesource.com/1054887 > > > Reviewed-by: Min Qin <qinmin@chromium.org> > > > Commit-Queue: Min Qin <qinmin@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#557734} > > > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org > > > > Change-Id: I7a618b9533229ea1bb97ff65470e9c60fe580a49 > > No-Try: true > > Bug: 838627 , 841666 > > Reviewed-on: https://chromium-review.googlesource.com/1053729 > > Reviewed-by: Max Morin <maxmorin@chromium.org> > > Commit-Queue: Max Morin <maxmorin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#557834} > > TBR=yhirano@chromium.org,qinmin@chromium.org,xingliu@chromium.org,maxmorin@chromium.org > > Change-Id: I4a0d7eb869a61e38d01424427976121fe7f13384 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 838627 , 841666 > Reviewed-on: https://chromium-review.googlesource.com/1055710 > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557969} TBR=qinmin@chromium.org,xingliu@chromium.org Change-Id: I6081079beaca50c3c9dc0fae53f665c68cd97eda No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838627 , 841666 Reviewed-on: https://chromium-review.googlesource.com/1055482 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557970} [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/components/download/internal/common/download_file_impl.cc [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/components/download/internal/common/download_file_unittest.cc [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/components/download/internal/common/download_item_impl.cc [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/components/download/internal/common/download_job_factory.cc [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/components/download/internal/common/download_worker.cc [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/components/download/internal/common/download_worker.h [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/components/download/internal/common/parallel_download_job.cc [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/components/download/internal/common/parallel_download_job.h [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/components/download/internal/common/parallel_download_job_unittest.cc [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/content/browser/download/byte_stream_input_stream.cc [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/content/browser/download/byte_stream_input_stream.h [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/content/browser/download/download_browsertest.cc [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/content/public/test/test_download_http_response.cc [modify] https://crrev.com/1259cf8446247ad265dcbd611ec4bab7b91c9ba7/content/public/test/test_download_http_response.h |
|||
►
Sign in to add a comment |
|||
Comment 1 by Findit
, May 10 2018