New issue
Advanced search Search tips

Issue 841659 link

Starred by 3 users
Status: Started
Owner:
slangley@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 729442

Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Cleanup & Modernize ChromeOS file system code

Project Member Reported by slangley@chromium.org, May 10 2018 
When making modifications to the code we generally also tend to fix up style/modernization issues as we see them - this can obfuscate the actual change being made.

This is a general bug to cleanup the chromeos file system code, like

- Proper macro usage for ThreadChecker
- s/DCHECK(!callback.is_null())/DCHECK(callback)/
- clang tidy checks such as
 -- modernize-use-emplace
 -- modernize-use-equals-default
 -- modernize-use-nullptr 
 -- modernize-raw-string-literal 
 -- modernize-make-unique
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be40357406155063c188290e93c19a6f5b3aa742

commit be40357406155063c188290e93c19a6f5b3aa742
Author: Stuart Langley <slangley@chromium.org>
Date: Thu May 10 05:32:27 2018

Cleanup/Modernize code in components/drive/chromeos/

Some cleanup work for components/drive/chromeos/ briging it in line
with recomended practices/c++ modernization.

- Use ThreadChecker macros.
- s/DCHECK(!callback.is_null())/DCHECK(callback)/
- clang tidy:
-- modernize-use-default
-- modernize-make-unique

This CL introduces NO logic changes.

Bug: 841659
Change-Id: Ic6f8829a983b14e955c858ed864dcadbc41f9506
Reviewed-on: https://chromium-review.googlesource.com/1053335
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557458}
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/about_resource_loader.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/change_list_loader.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/change_list_loader.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/change_list_loader_observer.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/change_list_processor.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/directory_loader.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/directory_loader.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/dummy_file_system.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/fake_file_system.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/fake_free_disk_space_getter.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/file_cache.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/file_cache.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/file_cache_unittest.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/file_system.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/file_system.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/file_system_interface.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/file_system_observer.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/resource_metadata.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/resource_metadata.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/search_metadata.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/sync/entry_revert_performer.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/sync/entry_revert_performer.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/sync/entry_update_performer.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/sync/entry_update_performer.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/sync/remove_performer.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/sync/remove_performer.h
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/sync_client.cc
[modify] https://crrev.com/be40357406155063c188290e93c19a6f5b3aa742/components/drive/chromeos/sync_client.h
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cd0da345beb51c4caa1846eb1dc281e79f24889

commit 0cd0da345beb51c4caa1846eb1dc281e79f24889
Author: Stuart Langley <slangley@chromium.org>
Date: Thu May 10 09:58:58 2018

Cleanup/Modernize code in chrome/browser/chromeos/file_manager/

Some cleanup work for chrome/browser/chromeos/file_manager/ briging it in line
with recomended practices/c++ modernization.

Modernize clang-tidy checks that were used:
-- modernize-use-default
-- modernize-make-unique
-- modernize-raw-string-literal
-- modernize-use-emplace
-- modernize-use-nullptr

This CL introduces NO logic changes.

Bug: 841659
Change-Id: Icb8803941bd7f2230cb0174c8e307d712ed0e10a
Reviewed-on: https://chromium-review.googlesource.com/1053668
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557488}
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/fake_disk_mount_manager.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/file_tasks.h
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/file_watcher.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/fileapi_util.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/fileapi_util_unittest.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/open_util.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/snapshot_manager.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/url_util_unittest.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/volume_manager.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/volume_manager_factory.cc
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/volume_manager_observer.h
[modify] https://crrev.com/0cd0da345beb51c4caa1846eb1dc281e79f24889/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/177388b6d3c742e88e275daf0bb8a1e7bd6a2c82

commit 177388b6d3c742e88e275daf0bb8a1e7bd6a2c82
Author: Noel Gordon <noel@chromium.org>
Date: Thu May 10 14:06:07 2018

FileManagerBrowserTestBase: fix include style after clang-tidy

Tbr: slangley
Bug: 841659
Change-Id: I2f7e55e103f91c563600a29632c59fade44fba3b
Reviewed-on: https://chromium-review.googlesource.com/1053676
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557504}
[modify] https://crrev.com/177388b6d3c742e88e275daf0bb8a1e7bd6a2c82/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
Project Member

Comment 4 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4e18ebd847a64ab98ee9eabe7ec625a06209765

commit d4e18ebd847a64ab98ee9eabe7ec625a06209765
Author: Noel Gordon <noel@chromium.org>
Date: Fri May 11 10:59:28 2018

FileManagerBrowserTestBase: C includes before C++ includes

Tbr: slangley
Bug: 841659
Change-Id: Ie9c79c80a3105ced7d97636ad8cb519e66d99244
Reviewed-on: https://chromium-review.googlesource.com/1055409
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557839}
[modify] https://crrev.com/d4e18ebd847a64ab98ee9eabe7ec625a06209765/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
Project Member

Comment 5 by bugdroid1@chromium.org, May 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5faa7615eddd46e07578730ecfda97e5561989d5

commit 5faa7615eddd46e07578730ecfda97e5561989d5
Author: Noel Gordon <noel@chromium.org>
Date: Sat May 12 07:17:48 2018

Add #include <utility> for std::move

Code is using std::move, defined in <utility>. Maybe clang-tidy has a
feature for this, but anyho.

Tbr: slangley
Bug: 841659
Change-Id: I01d81203a77e96bc0115980eda43a442944abb31
Reviewed-on: https://chromium-review.googlesource.com/1056508
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558123}
[modify] https://crrev.com/5faa7615eddd46e07578730ecfda97e5561989d5/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

Comment 6 by sashab@chromium.org, May 14 2018

Labels: CrOSFilesCategory-CodeHealth
Project Member

Comment 7 by bugdroid1@chromium.org, May 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094

commit 2fc3bfd72185f0b825e2c1ff9a72f91f369c6094
Author: Stuart Langley <slangley@chromium.org>
Date: Wed May 16 02:39:08 2018

Cleanup/Modernize code in components/drive/chromeos/file_system/

Some cleanup work for components/drive/chromeos/file_system/ briging it in line
with recomended practices/c++ modernization.

- Use ThreadChecker macros.
- s/DCHECK(!callback.is_null())/DCHECK(callback)/
- clang tidy modernize-use-default.

This CL introduces NO logic changes.

Bug: 841659
Change-Id: I4c725a48d7e9dc2b0291969a0887409c263f53d9
Reviewed-on: https://chromium-review.googlesource.com/1053040
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558933}
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/copy_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/copy_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/create_directory_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/create_directory_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/create_file_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/create_file_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/download_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/download_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/get_file_for_saving_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/get_file_for_saving_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/move_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/move_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/open_file_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/open_file_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/remove_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/remove_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/search_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/search_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/set_property_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/set_property_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/touch_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/touch_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/truncate_operation.cc
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system/truncate_operation.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system_interface.h
[modify] https://crrev.com/2fc3bfd72185f0b825e2c1ff9a72f91f369c6094/components/drive/chromeos/file_system_observer.h
Project Member

Comment 8 by bugdroid1@chromium.org, May 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8

commit 1cad1223d861b72ed6f755cef5eebd4bb7c18ce8
Author: Stuart Langley <slangley@chromium.org>
Date: Tue May 29 18:58:44 2018

Use clang-tidy modernize-use-equals-default on components/drive/*.

Continue modernization of the drive code, using clang-tidy. This
change replaces empty constructors/destructors with = default.

Steps:

$ autoninja -C out/Default chrome
$ tools/clang/scripts/generate_compdb.py -p \
  out/Default > compile_commands.json
$ cd out/Default/
$ /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \
-p ../.. \
-clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \
-clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \
-checks=-*,modernize-use-equals-default \
-header-filter= \
-fix components/drive

No logic changes. No new tests.

Bug: 841659
Change-Id: If1a85084575b632d3d29bd0dea021acbd8168b81
Reviewed-on: https://chromium-review.googlesource.com/1076570
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562531}
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/chromeos/file_system_interface.h
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/chromeos/file_system_observer.h
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/drive_app_registry.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/drive_app_registry_observer.h
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/drive_notification_manager.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/drive_notification_observer.h
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/drive_uploader.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/drive_uploader.h
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/event_logger.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/file_change.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/file_system_metadata.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/file_system_unittest.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/file_write_watcher.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/job_list.h
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/job_queue.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/local_file_reader.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/resource_metadata_storage.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/resource_metadata_storage_unittest.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/service/drive_service_interface.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/service/drive_service_interface.h
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/service/dummy_drive_service.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/service/fake_drive_service.cc
[modify] https://crrev.com/1cad1223d861b72ed6f755cef5eebd4bb7c18ce8/components/drive/service/fake_drive_service.h
Project Member

Comment 9 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fda065fcec0c94391561788da4b05ef305de74e6

commit fda065fcec0c94391561788da4b05ef305de74e6
Author: Stuart Langley <slangley@chromium.org>
Date: Wed May 30 03:01:05 2018

clang-tidy modernize-(use-nullptr|raw-string-literal) components/drive/*.

Continue modernization of the drive code, using clang-tidy. This
change replaces NULL with nullptr and strings like
"embedded \"quotes\"" with R"(embedded "quotes")".

Steps:

$ autoninja -C out/Default chrome
$ tools/clang/scripts/generate_compdb.py -p \
  out/Default > compile_commands.json
$ cd out/Default/
$ /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \
-p ../.. \
-clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \
-clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \
-checks=-*,modernize-use-nullptr,modernize-raw-string-literal \
-header-filter= \
-fix components/drive

No logic changes. No new tests.

Bug: 841659
Change-Id: I0ff0f09d3089aa4c72da7d39ef9698140f4a26aa
Reviewed-on: https://chromium-review.googlesource.com/1077107
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562710}
[modify] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/components/drive/about_resource_loader_unittest.cc
[modify] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/components/drive/change_list_loader_unittest.cc
[modify] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/components/drive/directory_loader_unittest.cc
[modify] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/components/drive/file_system_core_util.cc
[modify] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/components/drive/file_system_core_util_unittest.cc
[modify] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/components/drive/search_metadata_unittest.cc
[modify] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/components/drive/start_page_token_loader_unittest.cc
[modify] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/components/drive/sync_client_unittest.cc
[modify] https://crrev.com/fda065fcec0c94391561788da4b05ef305de74e6/components/drive/team_drive_list_loader_unittest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d63f68f834fa65fbdc39431cf1f1fe27c4b8d92f

commit d63f68f834fa65fbdc39431cf1f1fe27c4b8d92f
Author: Sasha Morrissey <sashab@chromium.org>
Date: Wed Jun 06 10:52:25 2018

Replace DCHECK(!callback.is_null()) with DCHECK(callback) in FDS

Replace DCHECK(!callback.is_null()) with DCHECK(callback) in
FakeDriveService

Bug: 841659
Change-Id: I88620b26e321a202ef4c73f5aed5cc7d352b9d7a
Reviewed-on: https://chromium-review.googlesource.com/1088456
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564847}
[modify] https://crrev.com/d63f68f834fa65fbdc39431cf1f1fe27c4b8d92f/components/drive/service/fake_drive_service.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b785f8445cde1f53029527e4e1213b58d9a22ea

commit 6b785f8445cde1f53029527e4e1213b58d9a22ea
Author: Stuart Langley <slangley@chromium.org>
Date: Wed Jun 13 05:32:20 2018

Cleanup/Modernize code in components/drive/

Some cleanup work for components/drive/ briging it in line
with recomended practices/c++ modernization.

- clang tidy modernize-make-unique.
- Fix up headers.

This CL introduces NO logic changes.

Bug: 841659
Change-Id: I9b8e1dfbacee96c4411abd304c8faf0feb24e118
Reviewed-on: https://chromium-review.googlesource.com/1093334
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566728}
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/about_resource_loader_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/change_list_loader_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/change_list_processor_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/chromeos/change_list_loader.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/directory_loader_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/drive_app_registry_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/drive_file_util_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/drive_uploader.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/drive_uploader_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/fake_file_system_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/file_system/copy_operation_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/file_system/download_operation_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/file_system/get_file_for_saving_operation_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/file_system/move_operation_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/file_system/open_file_operation_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/file_system/operation_test_base.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/file_system/truncate_operation_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/file_system_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/job_scheduler.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/job_scheduler_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/local_file_reader_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/remove_stale_cache_files_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/resource_metadata_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/search_metadata_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/service/drive_api_service.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/service/fake_drive_service.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/start_page_token_loader_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/sync/entry_revert_performer_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/sync/entry_update_performer_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/sync_client_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/team_drive_change_list_loader_unittest.cc
[modify] https://crrev.com/6b785f8445cde1f53029527e4e1213b58d9a22ea/components/drive/team_drive_list_loader_unittest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fdb31c52387dd691eb4611f3968949cf822f02c

commit 9fdb31c52387dd691eb4611f3968949cf822f02c
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Jun 19 19:00:01 2018

Run modernize-use-nullptr on chrome/browser/chromeos/extensions/file_manager

Steps I followed:

autoninja -C out/Default chrome

tools/clang/scripts/generate_compdb.py -p out/Default > compile_commands.json

cd out/Default

/usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \
-p ../.. \
-clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \
-clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \
-checks=-*,modernize-use-nullptr \
-header-filter=chrome/browser/chromeos/extensions/file_manager/* \
-fix chrome/browser/chromeos/extensions/file_manager

git cl format

Bug: 841659
Change-Id: I61747c05ca97127ad190de3e11337b0045128fea
Reviewed-on: https://chromium-review.googlesource.com/1106578
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568547}
[modify] https://crrev.com/9fdb31c52387dd691eb4611f3968949cf822f02c/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/9fdb31c52387dd691eb4611f3968949cf822f02c/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc
[modify] https://crrev.com/9fdb31c52387dd691eb4611f3968949cf822f02c/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc
[modify] https://crrev.com/9fdb31c52387dd691eb4611f3968949cf822f02c/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/9fdb31c52387dd691eb4611f3968949cf822f02c/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/9fdb31c52387dd691eb4611f3968949cf822f02c/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9441fc0b02b6ffc6b82064f42ebd659a311dee7a

commit 9441fc0b02b6ffc6b82064f42ebd659a311dee7a
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Jun 19 19:01:07 2018

Run modernize-use-equals-default on chrome/browser/chromeos/extensions/file_manager

Steps I followed:

autoninja -C out/Default chrome

tools/clang/scripts/generate_compdb.py -p out/Default > compile_commands.json

cd out/Default

/usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \
-p ../.. \
-clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \
-clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \
-checks=-*,modernize-use-equals-default \
-header-filter=chrome/browser/chromeos/extensions/file_manager/* \
-fix chrome/browser/chromeos/extensions/file_manager

git cl format

Bug: 841659
Change-Id: I1df81598c3d7b7dc18dc3326de410cc91f5de4b9
Reviewed-on: https://chromium-review.googlesource.com/1106577
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568549}
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/device_event_router.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/device_event_router_unittest.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/event_router_factory.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.h
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/file_stream_md5_digester.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/job_event_router.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_base.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.h
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_mount.h
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
[modify] https://crrev.com/9441fc0b02b6ffc6b82064f42ebd659a311dee7a/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9539e40482b05c1df00243c58a8f8b42aa0eaff5

commit 9539e40482b05c1df00243c58a8f8b42aa0eaff5
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Jun 19 19:01:11 2018

Run modernize-make-unique on chrome/browser/chromeos/extensions/file_manager

Steps I followed:

autoninja -C out/Default chrome

tools/clang/scripts/generate_compdb.py -p out/Default > compile_commands.json

cd out/Default

/usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \
-p ../.. \
-clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \
-clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \
-checks=-*,modernize-make-unique \
-header-filter=chrome/browser/chromeos/extensions/file_manager/* \
-fix chrome/browser/chromeos/extensions/file_manager

git cl format

No logic changes, No new tests.

Bug: 841659
Change-Id: Ia04e2880847d34dcc11b071c53c610a7c9afb4fb
Reviewed-on: https://chromium-review.googlesource.com/1106579
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568550}
[modify] https://crrev.com/9539e40482b05c1df00243c58a8f8b42aa0eaff5/chrome/browser/chromeos/extensions/file_manager/device_event_router_unittest.cc
[modify] https://crrev.com/9539e40482b05c1df00243c58a8f8b42aa0eaff5/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/9539e40482b05c1df00243c58a8f8b42aa0eaff5/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc
[modify] https://crrev.com/9539e40482b05c1df00243c58a8f8b42aa0eaff5/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/9539e40482b05c1df00243c58a8f8b42aa0eaff5/chrome/browser/chromeos/extensions/file_manager/job_event_router.cc
[modify] https://crrev.com/9539e40482b05c1df00243c58a8f8b42aa0eaff5/chrome/browser/chromeos/extensions/file_manager/job_event_router_unittest.cc
[modify] https://crrev.com/9539e40482b05c1df00243c58a8f8b42aa0eaff5/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/9539e40482b05c1df00243c58a8f8b42aa0eaff5/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/9539e40482b05c1df00243c58a8f8b42aa0eaff5/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
[modify] https://crrev.com/9539e40482b05c1df00243c58a8f8b42aa0eaff5/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46931e2df7ad0925086b34329cc83479dd0fb31c

commit 46931e2df7ad0925086b34329cc83479dd0fb31c
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Jun 19 19:24:14 2018

Run modernize-emplace-back on chrome/browser/chromeos/extensions/file_manager

Steps I followed:

autoninja -C out/Default chrome

tools/clang/scripts/generate_compdb.py -p out/Default > compile_commands.json

cd out/Default

/usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \
-p ../.. \
-clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \
-clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \
-checks=-*,modernize-emplace-back \
-header-filter=chrome/browser/chromeos/extensions/file_manager/* \
-fix chrome/browser/chromeos/extensions/file_manager

git cl format

No logic changes, No new tests.

Bug: 841659
Change-Id: Ie194e7cc68289e6ec8d04e699ba7bdaeed5c5c07
Reviewed-on: https://chromium-review.googlesource.com/1106580
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568562}
[modify] https://crrev.com/46931e2df7ad0925086b34329cc83479dd0fb31c/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc
[modify] https://crrev.com/46931e2df7ad0925086b34329cc83479dd0fb31c/chrome/browser/chromeos/extensions/file_manager/private_api_dialog.cc
[modify] https://crrev.com/46931e2df7ad0925086b34329cc83479dd0fb31c/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/46931e2df7ad0925086b34329cc83479dd0fb31c/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/46931e2df7ad0925086b34329cc83479dd0fb31c/chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
[modify] https://crrev.com/46931e2df7ad0925086b34329cc83479dd0fb31c/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff0cfa628b94a725c90a14b06b7fb9422a9db2af

commit ff0cfa628b94a725c90a14b06b7fb9422a9db2af
Author: Stuart Langley <slangley@chromium.org>
Date: Tue Jun 19 23:26:41 2018

Use correct Threadhecker macros in chrome/browser/chromeos/extensions/file_manager/*

ThreadChecker has a set of boilerplate macros that should be used so that it is
compiled out correctly on non DCHECK enabled builds.

No Logic Changed, No New Tests.

Bug: 841659
Change-Id: I93369ee67285ace07b630cd05b11b9e1d1cc9cfc
Reviewed-on: https://chromium-review.googlesource.com/1107017
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568638}
[modify] https://crrev.com/ff0cfa628b94a725c90a14b06b7fb9422a9db2af/chrome/browser/chromeos/extensions/file_manager/device_event_router.cc
[modify] https://crrev.com/ff0cfa628b94a725c90a14b06b7fb9422a9db2af/chrome/browser/chromeos/extensions/file_manager/device_event_router.h
[modify] https://crrev.com/ff0cfa628b94a725c90a14b06b7fb9422a9db2af/chrome/browser/chromeos/extensions/file_manager/job_event_router.cc
[modify] https://crrev.com/ff0cfa628b94a725c90a14b06b7fb9422a9db2af/chrome/browser/chromeos/extensions/file_manager/job_event_router.h
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b360c07bf04649a85dda705c00134ed0e8573ce8

commit b360c07bf04649a85dda705c00134ed0e8573ce8
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Jul 02 05:10:12 2018

Run clang-tidy modernize on chrome/browser/chromeos/drive

Command Run:

$ /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \
-p ../.. \
-clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \
-clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \
-checks=-*,modernize-use-nullptr,modernize-raw-string-literal,modernize-make-unique \
-header-filter= \
-fix chrome/browser/chromeos/drive

$ git cl format

There are no logic changes.

Bug: 841659
Change-Id: I6d2e7e6e31a53fb662586b823e9084fc1009a82a
Reviewed-on: https://chromium-review.googlesource.com/1121674
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571820}
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/download_handler_unittest.cc
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/drive_file_stream_reader.cc
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/drive_file_stream_reader_unittest.cc
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/drive_integration_service.cc
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/drive_integration_service_unittest.cc
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/file_system_util.cc
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/file_system_util_unittest.cc
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/fileapi/fileapi_worker_unittest.cc
[modify] https://crrev.com/b360c07bf04649a85dda705c00134ed0e8573ce8/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl_unittest.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1cdab9d22d08f902c6dbd5c9fd994c11de92904

commit e1cdab9d22d08f902c6dbd5c9fd994c11de92904
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Jul 02 22:21:08 2018

clang-tidy modernize-use-equals-default chrome/browser/chromeos/drive

$ /usr/local/google/code/llvm/tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py \
-p ../.. \
-clang-tidy-binary /usr/local/google/code/build/bin/clang-tidy \
-clang-apply-replacements-binary /usr/local/google/code/build/bin/clang-apply-replacements \
-checks=-*,modernize-use-equals-default,modernize-use-emplace \
-header-filter= \
-fix chrome/browser/chromeos/drive

$ git cl format

No logic changes in this cl.

Bug: 841659
Change-Id: Ie62dcf1cf34065d88cc31dfae481fbb7fa90ef9e
Reviewed-on: https://chromium-review.googlesource.com/1122017
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572018}
[modify] https://crrev.com/e1cdab9d22d08f902c6dbd5c9fd994c11de92904/chrome/browser/chromeos/drive/debug_info_collector.cc
[modify] https://crrev.com/e1cdab9d22d08f902c6dbd5c9fd994c11de92904/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/e1cdab9d22d08f902c6dbd5c9fd994c11de92904/chrome/browser/chromeos/drive/drive_file_stream_reader.cc
[modify] https://crrev.com/e1cdab9d22d08f902c6dbd5c9fd994c11de92904/chrome/browser/chromeos/drive/drive_integration_service.cc
[modify] https://crrev.com/e1cdab9d22d08f902c6dbd5c9fd994c11de92904/chrome/browser/chromeos/drive/file_task_executor.cc
[modify] https://crrev.com/e1cdab9d22d08f902c6dbd5c9fd994c11de92904/chrome/browser/chromeos/drive/fileapi/async_file_util.cc
[modify] https://crrev.com/e1cdab9d22d08f902c6dbd5c9fd994c11de92904/chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc
[modify] https://crrev.com/e1cdab9d22d08f902c6dbd5c9fd994c11de92904/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7667e30fdbee03129ff475e122a7fd28afa4f973

commit 7667e30fdbee03129ff475e122a7fd28afa4f973
Author: Stuart Langley <slangley@chromium.org>
Date: Mon Jul 02 22:21:28 2018

Cleanup/Modernize code in chrome/browser/chromeos/drive

Some cleanup work for chrome/browser/chromeos/drive briging it in line
with recomended practices/c++ modernization.

- Use ThreadChecker macros.
- s/DCHECK(!callback.is_null())/DCHECK(callback)/

Ths CL introduces no logic changes.

Bug: 841659
Change-Id: I5a5784d2de7d8f1be0e6240414d7c64c921d3cff
Reviewed-on: https://chromium-review.googlesource.com/1122029
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572019}
[modify] https://crrev.com/7667e30fdbee03129ff475e122a7fd28afa4f973/chrome/browser/chromeos/drive/debug_info_collector.cc
[modify] https://crrev.com/7667e30fdbee03129ff475e122a7fd28afa4f973/chrome/browser/chromeos/drive/debug_info_collector.h
[modify] https://crrev.com/7667e30fdbee03129ff475e122a7fd28afa4f973/chrome/browser/chromeos/drive/drive_file_stream_reader.cc
[modify] https://crrev.com/7667e30fdbee03129ff475e122a7fd28afa4f973/chrome/browser/chromeos/drive/drive_file_stream_reader.h
[modify] https://crrev.com/7667e30fdbee03129ff475e122a7fd28afa4f973/chrome/browser/chromeos/drive/drive_integration_service.cc
[modify] https://crrev.com/7667e30fdbee03129ff475e122a7fd28afa4f973/chrome/browser/chromeos/drive/file_system_util.cc
[modify] https://crrev.com/7667e30fdbee03129ff475e122a7fd28afa4f973/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc
[modify] https://crrev.com/7667e30fdbee03129ff475e122a7fd28afa4f973/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_writer_impl.cc
[modify] https://crrev.com/7667e30fdbee03129ff475e122a7fd28afa4f973/chrome/browser/chromeos/drive/write_on_cache_file.cc

Comment 20 by slangley@chromium.org, Sep 9

Blockedon: 729442
►

Sign in to add a comment