bluetooth/testing/clusterfuzz/PRESUBMIT.py always fails |
||
Issue description
Chrome Version: ToT
OS: Mac (Probably, all)
What steps will reproduce the problem?
(1) touch an existing file in third_party/blink/renderer/modules/bluetooth/testing/clusterfuzz/
E.g.
diff --git a/third_party/blink/renderer/modules/bluetooth/testing/clusterfuzz/PRESUBMIT.py b/third_party/blink/renderer/modules/bluetooth/testing/clusterfuzz/PRESUBMIT.py
index 39bd805..666f956 100644
--- a/third_party/blink/renderer/modules/bluetooth/testing/clusterfuzz/PRESUBMIT.py
+++ b/third_party/blink/renderer/modules/bluetooth/testing/clusterfuzz/PRESUBMIT.py
@@ -7,6 +7,7 @@
def _RunTests(input_api, output_api):
"""Runs all test files in the directory."""
+
cmd_name = 'all_python_tests'
cmd = ['python', '-m', 'unittest', 'discover', '-p', '*test.py']
test_cmd = input_api.Command(
(2) Make a local commit for it.
(3) git cl presubmit -u
What is the expected result?
PRESUBMIT.py passes.
What happens instead?
Have the following error:
** Presubmit ERRORS **
all_python_tests (0.26s) failed
E
======================================================================
ERROR: testCanGenerate100Files (fuzz_integration_test.WebBluetoothFuzzerTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/tkent/chrome/src/third_party/blink/renderer/modules/bluetooth/testing/clusterfuzz/fuzz_integration_test.py", line 21, in setUp
self._resources_path = setup.RetrieveResources()
File "/Users/tkent/chrome/src/third_party/blink/renderer/modules/bluetooth/testing/clusterfuzz/setup.py", line 60, in RetrieveResources
shutil.copy(os.path.join(current_path, r), resources_path)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py", line 119, in copy
copyfile(src, dst)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shutil.py", line 82, in copyfile
with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory: '/Users/tkent/chrome/src/third_party/blink/renderer/modules/bluetooth/testing/clusterfuzz/../../../../../../../third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js'
----------------------------------------------------------------------
Ran 1 test in 0.006s
FAILED (errors=1)
'resources' folder already exists. Clearing it...
Copying: /Users/tkent/chrome/src/third_party/WebKit/LayoutTests/resources/testharness.js
Copying: /Users/tkent/chrome/src/third_party/WebKit/LayoutTests/resources/testharnessreport.js
Copying: /Users/tkent/chrome/src/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dec5afddcc71114e20f7bd9696e86ce82d7b3331 commit dec5afddcc71114e20f7bd9696e86ce82d7b3331 Author: Ovidio Henriquez <odejesush@chromium.org> Date: Thu May 17 14:42:38 2018 bluetooth: Fix clusterfuzz presubmit script This change fixes the Bluetooth clusterfuzz presubmit script by updating the setup to use the new location of the bluetooth-helpers.js file. This file was moved to wpt/ to allow Bluetooth tests to be migrated to wpt/. Bug: 841656 Change-Id: I7e83b90a1be86963ed36014861179dd281ae1fb8 Reviewed-on: https://chromium-review.googlesource.com/1063123 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#559532} [modify] https://crrev.com/dec5afddcc71114e20f7bd9696e86ce82d7b3331/third_party/blink/renderer/modules/bluetooth/testing/clusterfuzz/setup.py
,
May 17 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by reillyg@chromium.org
, May 16 2018Status: Assigned (was: Untriaged)