New issue
Advanced search Search tips

Issue 841654 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
noel@chromium.org
fukino@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Audio Player: Clicking tracks does not have ripple effect.

Project Member Reported by fukino@chromium.org, May 10 2018 
Chrome Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Open built-in audio player by double-clicking audio file from Files app.
(2) Click the open-playlist button (the right-most button on the control panel.)
(3) Click any row in the playlist.

What is the expected result?
Clicking a row in step 3 should have ripple effect.

What happens instead?
It doesn't have ripple effect.
paper-ripple_extracted.js output an error "Uncaught TypeError: Cannot read property 'appendChild' of null."


We use a forked version of paper-ripple.
There might be an issue in it, or our usage might be wrong.

Comment 1 by noel@chromium.org, May 10 2018 

This was noticed in  crbug.com/835626#c3  .. result is: no ripple effect due to the JS exception.

In real Files.app, we don't get ripple feedback when user clicks tasks in play list, but it does not break the Files.app UI.

The AudioPlayerBrowserTests: changeTracksPlayList and changeTracksPlayListICon
(see crrev.com/557434) repro the error "Uncaught TypeError: Cannot read property 'appendChild' of null." in browser testing.

In the real File.app, the "audio.play() JS was interrupted by a pause()" error is often seen in conjunction with this paper-ripple problem.  This play->pause error does not harm the audio player's function, best we can tell.

Comment 2 by noel@chromium.org, May 10 2018 

For "audio.play() JS was interrupted by a pause()" error part, see:
https://developers.google.com/web/updates/2017/06/play-request-was-interrupted

Comment 3 by weifangsun@chromium.org, Jun 7 2018

Labels: -Pri-2 Pri-3
►

Sign in to add a comment