New issue
Advanced search Search tips

Issue 841651 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::ScriptableDocumentParser::GetInlineScriptCacheHandler

Project Member Reported by ClusterFuzz, May 10 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5269639383482368

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000040
Crash State:
  blink::ScriptableDocumentParser::GetInlineScriptCacheHandler
  GetInlineCacheHandler
  blink::ClassicPendingScript::GetSource
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=556805:556806

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5269639383482368

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 10 2018

Components: Blink>DOM Blink>HTML>Script
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 10 2018

Labels: Test-Predator-Auto-Owner
Owner: leszeks@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/d955606c25c5ef9cc634cd91c37fb89939600c51 (Add fieldtrial config for V8CacheInlineScriptCode).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
I can't repro this, but I can add a null check.
Project Member

Comment 4 by bugdroid1@chromium.org, May 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a952cba207e630aef8c3bde137017294a5a37c8

commit 6a952cba207e630aef8c3bde137017294a5a37c8
Author: Leszek Swirski <leszeks@chromium.org>
Date: Sat May 12 02:46:28 2018

Handle null parser in inline code caching

Add a null check for document.GetScriptableDocumentParser() when getting
an inline cache handler.

Bug:  chromium:841651 
Change-Id: Ie34c23a49c5725766ddf75e5667eb1b2dc7c0baf
Reviewed-on: https://chromium-review.googlesource.com/1052698
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558100}
[modify] https://crrev.com/6a952cba207e630aef8c3bde137017294a5a37c8/third_party/blink/renderer/core/script/classic_pending_script.cc

Project Member

Comment 5 by ClusterFuzz, May 12 2018

ClusterFuzz has detected this issue as fixed in range 558099:558100.

Detailed report: https://clusterfuzz.com/testcase?key=5269639383482368

Fuzzer: inferno_twister_c
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000040
Crash State:
  blink::ScriptableDocumentParser::GetInlineScriptCacheHandler
  GetInlineCacheHandler
  blink::ClassicPendingScript::GetSource
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=556805:556806
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=558099:558100

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5269639383482368

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, May 12 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5269639383482368 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment