New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841649 link

Starred by 2 users
Status: Fixed
Owner:
█ junwei...@intel.com
Last visit > 30 days ago
Closed: May 2018
Cc:
reillyg@chromium.org
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Consider using TypeConverter to convert the type of landmark from Mojo to IDL

Project Member Reported by junwei...@intel.com, May 10 2018 

The task comes form the comments[1]:

consider using a TypeConverter just so we can try to keep an eye on the places in Blink that need to do these sorts of conversions. By using a consistent mechanism, we can hopefully find these conversion locations in the future if we find a better solution for Mojo-IDL interop.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1020385/8/third_party/blink/renderer/modules/shapedetection/face_detector.cc#87
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc0d744af5fb54728fe5af5c6e52b1ae6419a1c1

commit dc0d744af5fb54728fe5af5c6e52b1ae6419a1c1
Author: junweifu <junwei.fu@intel.com>
Date: Thu May 24 00:49:47 2018

ShapeDetection: Convert mojom::LandmarkType to String with TypeConvert

We can hopefully find these conversion locations in the future if we find a
better solution for Mojo-IDL intero although TypeConvert is deprecated.

Use LUCI for chromium tests on Windows 10 in PRSUBMITs.py.

BUG= 841649 

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng
Change-Id: Ic235bcf98ecd53c5d873a8faf4ed72f1f60530b3
Reviewed-on: https://chromium-review.googlesource.com/1063291
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561343}
[modify] https://crrev.com/dc0d744af5fb54728fe5af5c6e52b1ae6419a1c1/services/shape_detection/PRESUBMIT.py
[modify] https://crrev.com/dc0d744af5fb54728fe5af5c6e52b1ae6419a1c1/third_party/blink/renderer/modules/shapedetection/BUILD.gn
[modify] https://crrev.com/dc0d744af5fb54728fe5af5c6e52b1ae6419a1c1/third_party/blink/renderer/modules/shapedetection/DEPS
[modify] https://crrev.com/dc0d744af5fb54728fe5af5c6e52b1ae6419a1c1/third_party/blink/renderer/modules/shapedetection/OWNERS
[modify] https://crrev.com/dc0d744af5fb54728fe5af5c6e52b1ae6419a1c1/third_party/blink/renderer/modules/shapedetection/face_detector.cc
[add] https://crrev.com/dc0d744af5fb54728fe5af5c6e52b1ae6419a1c1/third_party/blink/renderer/modules/shapedetection/shape_detection_type_converter.h

Comment 2 by junwei...@intel.com, May 25 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment