New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 841638 link

Starred by 1 user
Status: Verified
Owner:
lijeffrey@chromium.org
Closed: May 2018
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Make upper bound build number optional to supply to GetIsolateShaPipeline

Project Member Reported by lijeffrey@chromium.org, May 10 2018 
Getting the isolate sha is limited to the analysis' build number when trying to determine the nearest builds. This however is not always the case, as rerunning a recent build is part of the analysis at the end before filing a bug, which will assert later on.
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/be786835d41e5225329ef86fc97d58625d7b0c34

commit be786835d41e5225329ef86fc97d58625d7b0c34
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu May 10 16:25:04 2018

[Findit] Flake Analyzer - Adding upper bound build number as get isolate sha input

When determining nearby builds to a build number, an optional parameter is supplied
for the latest build number to check. For flake analysis, the analysis' triggering
build number is fine, but when verifying flakiness in a recent build that value will
be out dated. This change introduces a parameter for the calling code to specify the
upper bound instead of relying on the analysis' pre-stored value.

Bug:  841638 
Change-Id: I7462faac2db5b81ce2e5f830baa886e7f8e1031a
Reviewed-on: https://chromium-review.googlesource.com/1053422
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/be786835d41e5225329ef86fc97d58625d7b0c34/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py
[modify] https://crrev.com/be786835d41e5225329ef86fc97d58625d7b0c34/appengine/findit/pipelines/flake_failure/test/get_isolate_sha_pipeline_test.py
[modify] https://crrev.com/be786835d41e5225329ef86fc97d58625d7b0c34/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[modify] https://crrev.com/be786835d41e5225329ef86fc97d58625d7b0c34/appengine/findit/pipelines/flake_failure/get_isolate_sha_pipeline.py
[modify] https://crrev.com/be786835d41e5225329ef86fc97d58625d7b0c34/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py
[modify] https://crrev.com/be786835d41e5225329ef86fc97d58625d7b0c34/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py

Comment 2 by lijeffrey@chromium.org, May 21 2018

Status: Verified (was: Assigned)
►

Sign in to add a comment